Skip to content

Update Italy holidays: add Whit Monday in Bolzano (BZ)#3236

Merged
arkid15r merged 1 commit intovacanza:devfrom
KJhellico:upd-italy
Jan 22, 2026
Merged

Update Italy holidays: add Whit Monday in Bolzano (BZ)#3236
arkid15r merged 1 commit intovacanza:devfrom
KJhellico:upd-italy

Conversation

@KJhellico
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico commented Jan 21, 2026

Proposed change

Update Italy holidays: add Whit Monday as province holiday in Bolzano (BZ).
Resolves #3234.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 21, 2026 •
edited
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Updated Italy's Bolzano Province holiday calendar: Whit Monday is now observed from 1993 onwards, replacing Assumption Day during this period.

  • Documentation

    • Updated holiday documentation for Bolzano Province regulations.

  • Tests

    • Added test coverage for Whit Monday holiday observance.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This pull request restores Whit Monday as an official holiday for Italy's Bolzano (BZ) province from 1993 onward, replacing Assumption Day. The change updates the holiday logic, localization mappings, test coverage, and snapshot data to reflect this correction.

Changes

Cohort / File(s) Summary
Core logic
holidays/countries/italy.py		 Replaces unconditional Assumption Day with conditional Whit Monday addition for BZ subdivision when year ≥ 1993
Localization
holidays/locale/en_US/LC_MESSAGES/IT.po, holidays/locale/it_IT/LC_MESSAGES/IT.po		 Updates metadata (version 0.86→0.90, date 2025-11-23→2026-01-22) and replaces Assumption Day translation block with Whit Monday entry; reintroduces Assumption Day entry later in file
Test coverage
tests/countries/test_italy.py		 Adds new test_bz_whit_monday() test function validating Whit Monday presence for BZ subdivision across multiple years and date ranges
Snapshot data
snapshots/countries/IT_BZ.json		 Standardizes holiday labels from dual format to "Assumption Of Mary Day" and introduces recurring Whit Monday entries across multiple years; large homogeneous data update

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

l10n, snapshot, test

Suggested reviewers

  • dr-prodigy
  • PPsyrius
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding Whit Monday as a holiday for Bolzano (BZ) in Italy.
Description check ✅ Passed The description is directly related to the changeset, explaining the update to Italy holidays and linking to the resolved issue #3234.
Linked Issues check ✅ Passed The PR successfully addresses the core requirement from issue #3234: re-adding Whit Monday as a dynamic holiday for the BZ subdivision in Italy with proper year-dependent logic (from 1993 onward).
Out of Scope Changes check ✅ Passed All changes are scoped to the Italy holiday definitions and localization files needed to support Whit Monday for BZ, with corresponding test updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (095e64d) to head (87e3bd9).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18309     18310    +1     
  Branches      2330      2331    +1     
=========================================
+ Hits         18309     18310    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r
arkid15r approved these changes Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Jan 21, 2026
Merged via the queue into vacanza:dev with commit 3ce408f Jan 22, 2026
32 checks passed
@KJhellico KJhellico deleted the upd-italy branch January 22, 2026 08:56
@KJhellico KJhellico mentioned this pull request Feb 2, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Mar 11, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Whit Monday missing for Italian "BZ" subdivision

2 participants

@KJhellico @arkid15r