Skip to content

Add archive-links Makefile target#3218

Merged
arkid15r merged 3 commits intovacanza:devfrom
arkid15r:ark/add-archive-links-target
Jan 17, 2026
Merged

Add archive-links Makefile target#3218
arkid15r merged 3 commits intovacanza:devfrom
arkid15r:ark/add-archive-links-target

Conversation

@arkid15r
Copy link
Copy Markdown
Collaborator

Proposed change

Add archive-links Makefile target

Archive some URLs.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 17, 2026

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

  • New Features

    • Added an archive-links command to update reference URLs via the Wayback Machine.
  • Chores

    • Improved Makefile help with a default goal and phony declaration.
    • Replaced live reference links with archived URLs across multiple country holiday definitions (Australia, Estonia, Italy, Sweden, Venezuela).

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Updates documentation/reference URLs in multiple country holiday modules to archived Web Archive links and adds a new Makefile target archive-links (with .DEFAULT_GOAL := help and .PHONY: help) and help text advertising that target.

Changes

Cohort / File(s) Summary
Build Configuration
Makefile
Added .DEFAULT_GOAL := help and .PHONY: help; added archive-links target running uv run --no-sync scripts/archive_links.py; updated help output to list archive-links.
Reference URL updates
holidays/countries/australia.py, holidays/countries/estonia.py, holidays/countries/italy.py, holidays/countries/sweden.py, holidays/countries/venezuela.py
Replaced live/legal/documentation URLs with Web Archive/Wayback Machine archived URLs in docstrings and reference blocks; no logic or API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • KJhellico
  • PPsyrius
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new Makefile target named archive-links.
Description check ✅ Passed The description explains the purpose of the change (archiving URLs) and is clearly related to the modifications across multiple country holiday files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@arkid15r arkid15r marked this pull request as ready for review January 17, 2026 00:44
@arkid15r arkid15r enabled auto-merge January 17, 2026 00:44
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (43ccde3) to head (83b9070).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #3218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18314     18314           
  Branches      2339      2339           
=========================================
  Hits         18314     18314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛠️

@arkid15r arkid15r added this pull request to the merge queue Jan 17, 2026
Merged via the queue into vacanza:dev with commit 68365d4 Jan 17, 2026
32 checks passed
@arkid15r arkid15r deleted the ark/add-archive-links-target branch January 17, 2026 02:04
@twilight93
Copy link
Copy Markdown

I think it would be worth adding an option to run the archiver on a single .py file (e.g., python archive_links.py countries/united_states.py) instead of scanning the entire library every time. It would be especially helpful when we are just adding or updating a specific country and want to verify those references quickly.

Just a thought!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants