Skip to content

Update Australia holidays: move Anzac Day in 2026 (ACT)#3216

Merged
arkid15r merged 2 commits intovacanza:devfrom
simongreen-net:anzac-day-act-au-2026
Jan 17, 2026
Merged

Update Australia holidays: move Anzac Day in 2026 (ACT)#3216
arkid15r merged 2 commits intovacanza:devfrom
simongreen-net:anzac-day-act-au-2026

Conversation

@simongreen-net
Copy link
Copy Markdown
Contributor

@simongreen-net simongreen-net commented Jan 16, 2026

Proposed change

ACT (a territory of Australia) passed a law on 28/11/2025 that changed the date of Anzac Day in 2026 (only). This PR follows the change, and adds a check for it.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@github-actions github-actions bot added the test label Jan 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 16, 2026 •
edited
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Corrected ANZAC Day observance for Australian Capital Territory in 2026. The public holiday will now be observed on Monday, April 27 instead of Saturday, April 25.

  • Tests

    • Added test coverage to validate the updated ANZAC Day observance date for ACT in 2026.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds a 2026-specific ANZAC Day observation rule for ACT (move to Monday using SAT_SUN_TO_NEXT_MON) while preserving the existing 1959+ SUN_TO_NEXT_MON behavior; updates tests to assert ACT-specific 2026 behavior.

Changes

Cohort / File(s) Summary
Australia ANZAC Day Special Case
holidays/countries/australia.py		 Adds ACT declaration link and implements a 2026-specific observer rule: ANZAC Day uses SAT_SUN_TO_NEXT_MON for 2026; for years ≥ 1959 (excluding 2026) retains SUN_TO_NEXT_MON.
Test Coverage for 2026 Adjustment
tests/countries/test_australia.py		 Switches iteration to items() to access subdivisions and adds ACT-specific assertions: ANZAC Day not observed on 2026-04-25 and observed on 2026-04-27.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

snapshot

Suggested reviewers

  • PPsyrius
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: updating Australia holidays to move Anzac Day in 2026 for the ACT subdivision.
Description check ✅ Passed The description is related to the changeset, explaining the legal change in ACT that prompted the update and confirming the corresponding code and test changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@simongreen-net
Copy link
Copy Markdown
Contributor Author

simongreen-net commented Jan 16, 2026 •
edited
Loading

The law change is mentioned in the references section. WBM doesn't appear to have archived it yet. I've checked all other sub-divisions in Australia, and New Zealand, and the holidays module has the correct dates.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 16, 2026
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (be0e765) to head (dc1f5ec).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18313     18315    +2     
  Branches      2338      2339    +1     
=========================================
+ Hits         18313     18315    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simongreen-net
Copy link
Copy Markdown
Contributor Author

simongreen-net commented Jan 16, 2026

Since the law change is specifically for the holiday in 2026, I've used == 2026. The next time Anzac Day falls on a Saturday is 2037. Who knows what will happen that year :P

@KJhellico KJhellico changed the title Move Anzac Day in 2026 in the ACT sub-division of Australia Update Australia holidays: move Anzac Day in 2026 (ACT) Jan 16, 2026
KJhellico
KJhellico previously approved these changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

PPsyrius
PPsyrius previously approved these changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇦🇺

I'm waiting for the wayback machine to archive our links ATM (2 hrs queue is quite unusual), if this situation continues tomorrow I got an archive.today/.ph/.is archive as well - in any case, we can probably merge as-is then update the links later.

@arkid15r
Copy link
Copy Markdown
Collaborator

arkid15r commented Jan 16, 2026

LGTM 🇦🇺

I'm waiting for the wayback machine to archive our links ATM (2 hrs queue is quite unusual), if this situation continues tomorrowI got an archive.today/.ph/.is archive as well - in any case, we can probably merge as-is then update the links later.

This PR doesn't have Maintainers are allowed to edit this pull request. enabled.

@arkid15r arkid15r added this pull request to the merge queue Jan 16, 2026
arkid15r
arkid15r reviewed Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Merged via the queue into vacanza:dev with commit d1dc1c5 Jan 17, 2026
4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 17, 2026
Merged
9 tasks
@KJhellico KJhellico mentioned this pull request Jan 19, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 15, 2026
Merged
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 24, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@KJhellico KJhellico KJhellico left review comments

@PPsyrius PPsyrius PPsyrius left review comments

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simongreen-net @arkid15r @KJhellico @PPsyrius