Skip to content

Update README: update Available Countries table#3201

Merged
arkid15r merged 3 commits intovacanza:devfrom
PPsyrius:us_virgin_docu_typo
Jan 8, 2026
Merged

Update README: update Available Countries table#3201
arkid15r merged 3 commits intovacanza:devfrom
PPsyrius:us_virgin_docu_typo

Conversation

@PPsyrius
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius commented Jan 8, 2026 •
edited
Loading

Proposed change

Removing redundant entry for U.S. Virgin Islands not handled earlier in #3135

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 8, 2026 •
edited
Loading

Walkthrough

Removed the README table row for "United States Virgin Islands (the)" from the Available Countries list; this deleted the country name, code, subdivisions, languages, and categories entry. No code or exported-public-entity changes.

Changes

Cohort / File(s) Change Summary
Documentation
README.md		 Deleted the table row for "United States Virgin Islands (the)" from the Available Countries list (data row removed: name, code, subdivisions, languages, categories).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • KJhellico
  • arkid15r
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining the removal of a redundant U.S. Virgin Islands entry and referencing the related issue #3135.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Update README: update Available Countries table' accurately reflects the main change—removing a redundant U.S. Virgin Islands entry from the README's country table.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0ae6b9f) to head (0e20cb5).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18309     18309           
  Branches      2337      2337           
=========================================
  Hits         18309     18309

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 8, 2026
View reviewed changes
arkid15r
arkid15r reviewed Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need some tests.

@PPsyrius
Copy link
Copy Markdown
Collaborator Author

PPsyrius commented Jan 8, 2026

It looks like we need some tests.

AFAIK, it's the only odd one out at the moment and is already included as "Virgin Islands (U.S.)" as well. The reason it wasn't tested before was that it doesn't have an entity code (and thus wasn't covered by our existing test cases) - IMO, removing this particular table entry altogether might be better. 👀

@KJhellico
Copy link
Copy Markdown
Collaborator

KJhellico commented Jan 8, 2026

emoving this particular table entry altogether might be better

Yes, I also don't understand why it's here, without a code.

@PPsyrius PPsyrius requested a review from arkid15r January 8, 2026 11:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KJhellico KJhellico changed the title Update Available Countries table Update README: update Available Countries table Jan 8, 2026
KJhellico
KJhellico approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Jan 8, 2026
Merged via the queue into vacanza:dev with commit 60ff43c Jan 8, 2026
32 checks passed
@PPsyrius PPsyrius deleted the us_virgin_docu_typo branch January 9, 2026 05:12
@coderabbitai coderabbitai bot mentioned this pull request Jan 12, 2026
Merged
@KJhellico KJhellico mentioned this pull request Jan 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @KJhellico @arkid15r