Skip to content

Update CONTRIBUTORS#3193

Merged
KJhellico merged 1 commit intovacanza:devfrom
rpanai:patch-1
Jan 6, 2026
Merged

Update CONTRIBUTORS#3193
KJhellico merged 1 commit intovacanza:devfrom
rpanai:patch-1

Conversation

@rpanai
Copy link
Copy Markdown
Contributor

@rpanai rpanai commented Jan 6, 2026

I made this PR #236

Proposed change

Your PR description goes here.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@rpanai
Update CONTRIBUTORS
81124f1 
I made this PR vacanza#236

Signed-off-by: Roberto Panai <[email protected]>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 6, 2026 •
edited
Loading

Summary by CodeRabbit

  • Chores
    • Updated contributors list

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

A new contributor entry for Roberto Panai is added to the CONTRIBUTORS list. The entry is inserted in alphabetical order between existing contributors, with no other modifications to the file.

Changes

Cohort / File(s) Summary
Contributor list update
CONTRIBUTORS		 Added "Roberto Panai" entry in alphabetical sequence between "Robert Tran" and "Robin Emeršič"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update CONTRIBUTORS' directly matches the changeset, which adds a new contributor entry to the CONTRIBUTORS file.
Description check ✅ Passed The description references the contributor's own PR and explains the change (adding their name to CONTRIBUTORS), which is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a98b0e and 81124f1.

📒 Files selected for processing (1)
  • CONTRIBUTORS
🔇 Additional comments (1)
CONTRIBUTORS (1)

142-142: Alphabetical ordering is correct; entry looks good.

The addition of "Roberto Panai" is properly positioned between "Robert Tran" and "Robin Emeršič" in alphabetical order.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6a98b0e) to head (81124f1).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18307     18307           
  Branches      2337      2337           
=========================================
  Hits         18307     18307

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius
PPsyrius approved these changes Jan 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗒️

Thanks for the correction, sorry that we missed this earlier.

@KJhellico
Copy link
Copy Markdown
Collaborator

KJhellico commented Jan 6, 2026

@rpanai, thank you for your contribution to out project and welcome to contributors list! Your name was not included in the initial list because only full names were considered when building it, and your commit didn't contain it. 🤷‍♂️

KJhellico
KJhellico approved these changes Jan 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KJhellico KJhellico added this pull request to the merge queue Jan 6, 2026
Merged via the queue into vacanza:dev with commit 9a96606 Jan 6, 2026
33 checks passed
@KJhellico KJhellico mentioned this pull request Jan 19, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Mar 12, 2026
Merged
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 23, 2026
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@PPsyrius PPsyrius PPsyrius approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rpanai @KJhellico @PPsyrius