Migrate I-L countries to new test case standards by PPsyrius · Pull Request #3187 · vacanza/holidays

PPsyrius · 2026-01-02T05:01:18Z

Proposed change

Migrate I-L countries to new test case standards (except India, as they're supposed to get full refactor as part of WoC anyway)

Part of #3065

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2026-01-02T05:01:41Z

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

Refactor
- Minor holiday naming and comment/formatting cleanup across several country definitions.
Tests
- Large expansion and rework of country test suites: many per-holiday tests added, dynamic multi‑year ranges adopted, explicit observed vs non‑observed checks, improved localization coverage, new range/count helpers, and numerous test methods renamed or split for finer-grained validation across many countries.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Refactors two small country modules and converts many country test suites to per‑holiday, range‑aware tests; standardizes observed/non‑observed handling, introduces category-aware test helpers, expands Islamic holiday coverage, and adds numerous localization checks.

Changes

Cohort / File(s)	Summary
Production — small refactors `holidays/countries/jordan.py`, `holidays/countries/kyrgyzstan.py`	Minor local refactor in Jordan (reuse local `name = tr("...")` for repeated Eid labels) and comment/whitespace/name tweaks in Kyrgyzstan. No behavioral/API changes.
Gulf / Middle East tests `tests/countries/test_jordan.py`, `tests/countries/test_kuwait.py`, `tests/countries/test_iran.py`	Added extensive per‑holiday tests for Gregorian and Islamic (no‑estimated) holidays, explicit multi‑year date assertions, holiday/holiday‑variant checks, and l10n verifications.
Large test-suite migrations — range-based setup `tests/countries/test_iceland.py`, `tests/countries/test_ireland.py`, `tests/countries/test_isle_of_man.py`, `tests/countries/test_israel.py`, `tests/countries/test_ivory_coast.py`, `tests/countries/test_jamaica.py`, `tests/countries/test_jersey.py`, `tests/countries/test_kazakhstan.py`, `tests/countries/test_kenya.py`, `tests/countries/test_kiribati.py`, `tests/countries/test_latvia.py`, `tests/countries/test_lesotho.py`, `tests/countries/test_liberia.py`, `tests/countries/test_libya.py`, `tests/countries/test_liechtenstein.py`, `tests/countries/test_lithuania.py`, `tests/countries/test_luxembourg.py`	Removed explicit year ranges from setUpClass in many tests; migrated assertions to use `self.full_range` / `self.start_year` / `self.end_year`; renamed and split tests into per‑holiday methods; updated observed/substitute‑day assertions.
Test infra — category‑aware helpers & new assertions `tests/countries/test_iraq.py`, `tests/countries/test_laos.py`, `tests/countries/test_lebanon.py`	Introduced and used category-aware helpers (Christian/Hebrew/Sabian/Yazidi/Bank/Government/IslamicNoEstimated helpers), count-based assertions, and refactored tests to rely on these helpers and dynamic ranges.
Observed / non‑observed handling (standardization) `tests/countries/*` (multiple files referenced above)	Standardized observed-date sequences (`obs_dts`), substitute-day naming, and clarified observed vs non‑observed assertions across many country test modules.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related issues

Test Case Refactor for remaining countries to New Testing Standard #3065 — Matches the cross‑country test-suite migration to per‑holiday/full_range testing standard applied here.

Possibly related PRs

Add Kiribati holidays #2778 — Overlaps Kiribati test/module changes present in this diff.
Update Luxembourg holidays: add bank holidays #2751 — Related to Luxembourg bank‑holiday population and corresponding tests added here.

Suggested reviewers

KJhellico
arkid15r

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main objective of the pull request: migrating test cases for countries starting with I-L to new standards.
Description check	✅ Passed	The description provides relevant context about the migration to new test case standards, references the related issue, and explains the exclusion of India.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-02T05:03:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6a98b0e) to head (22706a5).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3187   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          307       307           
  Lines        18307     18309    +2     
  Branches      2337      2337           
=========================================
+ Hits         18307     18309    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r

LGTM

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Panpakorn Siripanich <[email protected]>

sonarqubecloud · 2026-01-06T12:27:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico

LGTM!

PPsyrius added 4 commits January 2, 2026 11:56

Refactor I countries test cases (excl. India)

fea3475

Refactor J countries test cases

440fecb

Refactor K countries test cases

76e7e87

Refactor L countries test cases

f7579e5

github-actions bot added the test label Jan 2, 2026

PPsyrius mentioned this pull request Jan 2, 2026

Test Case Refactor for remaining countries to New Testing Standard #3065

Open

5 tasks

PPsyrius marked this pull request as ready for review January 2, 2026 05:35

PPsyrius requested review from KJhellico and arkid15r as code owners January 2, 2026 05:35

arkid15r reviewed Jan 5, 2026

View reviewed changes

Comment thread tests/countries/test_liberia.py Outdated

arkid15r enabled auto-merge January 5, 2026 00:21

PPsyrius added 2 commits January 5, 2026 12:17

In-line Liberia test case

5f528fc

Merge branch 'dev' into i_l_countries

179e97e

PPsyrius requested a review from arkid15r January 5, 2026 05:18

coderabbitai bot previously approved these changes Jan 5, 2026

View reviewed changes

arkid15r previously approved these changes Jan 5, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Jan 5, 2026

KJhellico removed this pull request from the merge queue due to a manual request Jan 5, 2026

KJhellico reviewed Jan 5, 2026

View reviewed changes

PPsyrius added 2 commits January 6, 2026 09:16

Merge branch 'dev' into i_l_countries

4902690

Code Review Comments

1b0b650

PPsyrius dismissed stale reviews from arkid15r and coderabbitai[bot] via 1b0b650 January 6, 2026 04:33

Some test_no_holidays could use Category-specific tests instead

012ef99

PPsyrius requested review from KJhellico and arkid15r January 6, 2026 05:46

coderabbitai bot previously approved these changes Jan 6, 2026

View reviewed changes

PR Code Review Comment

ab2458a

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Panpakorn Siripanich <[email protected]>

PPsyrius dismissed coderabbitai[bot]’s stale review via ab2458a January 6, 2026 11:13

coderabbitai bot previously approved these changes Jan 6, 2026

View reviewed changes

KJhellico reviewed Jan 6, 2026

View reviewed changes

Comment thread tests/countries/test_kazakhstan.py Outdated

Remove duplicate

22706a5

Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Panpakorn Siripanich <[email protected]>

PPsyrius dismissed coderabbitai[bot]’s stale review via 22706a5 January 6, 2026 12:26

KJhellico approved these changes Jan 6, 2026

View reviewed changes

coderabbitai bot approved these changes Jan 6, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Jan 6, 2026

Merged via the queue into vacanza:dev with commit f5203bd Jan 6, 2026
33 checks passed

PPsyrius deleted the i_l_countries branch January 7, 2026 02:30

PPsyrius mentioned this pull request Jan 7, 2026

Refactor test_no_holidays, now also test supported_categories by default #3197

Merged

9 tasks

KJhellico mentioned this pull request Jan 19, 2026

v0.89 #3229

Merged

coderabbitai bot mentioned this pull request Feb 12, 2026

Refactor United Kingdom holidays #3262

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate I-L countries to new test case standards#3187

Migrate I-L countries to new test case standards#3187
arkid15r merged 11 commits intovacanza:devfrom
PPsyrius:i_l_countries

PPsyrius commented Jan 2, 2026

Uh oh!

coderabbitai bot commented Jan 2, 2026 •

edited

Loading

Review failed

Uh oh!

codecov bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 6, 2026

Uh oh!

KJhellico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PPsyrius commented Jan 2, 2026

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 6, 2026

Quality Gate passed

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Jan 2, 2026 •

edited

Loading

codecov bot commented Jan 2, 2026 •

edited

Loading