Skip to content

Update United States holidays: update Alaska (AK) state holidays#3174

Merged
arkid15r merged 2 commits intovacanza:devfrom
KJhellico:upd-us-ak
Dec 29, 2025
Merged

Update United States holidays: update Alaska (AK) state holidays#3174
arkid15r merged 2 commits intovacanza:devfrom
KJhellico:upd-us-ak

Conversation

@KJhellico
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico commented Dec 28, 2025

Proposed change

Update United States holidays: update Alaska (AK) state holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 28, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

  • New Features

    • Alaska-specific holiday workflow added: MLK Jr.'s Birthday observed from 1990; Lincoln's Birthday used in earlier years; Presidents' Day/Washington's Birthday handling adjusted by year.
    • Seward's Day fixed to last Monday in March; Alaska Day consistently observed via Oct 18.
    • Alaska included in subdivision-level holiday gating where applicable.

  • Localization

    • Added English and Thai entries for Martin Luther King Jr.'s Birthday and Lincoln's Birthday.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds Alaska-specific holiday handling to US holidays: introduces an AK public-holidays workflow with year-based rules for MLK Jr./Lincoln's Birthday, Presidents'/Washington's Day, Seward's Day, and Alaska Day. Updates translations, AK snapshots, and tests to reflect the new AK behavior.

Changes

Cohort / File(s) Summary
Core Holiday Logic
holidays/countries/united_states.py		 Adds AK-specific subdivision handling and a dedicated AK public-holidays flow: MLK Jr. vs Lincoln gating by year, Presidents' Day/Washington's Birthday handling by year, Seward's Day fixed to last Monday of March, Alaska Day always observed; AK added to subdivision exclusion sets.
Translations
holidays/locale/en_US/LC_MESSAGES/US.po, <br>holidays/locale/th/LC_MESSAGES/US.po`		 Added entries for "Martin Luther King Jr.'s Birthday" and "Lincoln's Birthday"; repositioned and removed duplicate Lincoln entry; added Thai translations.
Snapshots (AK)
snapshots/countries/US_AK.json		 Updated AK snapshot: added many Lincoln's Birthday entries, adjusted MLK Jr. naming, modified Presidents'/Washington's Birthday labels, and changed Alaska Day occurrences to match new rules.
Tests
tests/countries/test_united_states.py		 Introduced AK-specific assertions across multiple tests: MLK Jr. (1990+), Washington's Birthday, Seward's Day (range from 1959), Lincoln's Birthday (observed variants), and Alaska Day (starts 1959); replaced hard-coded lists with range-based checks.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • arkid15r
  • PPsyrius

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the main changeset: updating Alaska state holidays in the US holidays implementation.
Description check ✅ Passed The description accurately describes the PR's purpose of updating Alaska state holidays, matching the changeset across multiple files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (29a3103) to head (e333d53).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18288     18288           
  Branches      2336      2335    -1     
=========================================
  Hits         18288     18288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 28, 2025
View reviewed changes
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 28, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arkid15r arkid15r enabled auto-merge December 28, 2025 23:14
arkid15r
arkid15r reviewed Dec 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

PPsyrius
PPsyrius approved these changes Dec 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇺🇸

@arkid15r arkid15r added this pull request to the merge queue Dec 29, 2025
Merged via the queue into vacanza:dev with commit a7a7aef Dec 29, 2025
33 checks passed
@KJhellico KJhellico deleted the upd-us-ak branch December 29, 2025 18:02
@arkid15r arkid15r mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius