Skip to content

Update make script for Windows#3173

Merged
arkid15r merged 1 commit intovacanza:devfrom
KJhellico:upd-make-cmd
Dec 28, 2025
Merged

Update make script for Windows#3173
arkid15r merged 1 commit intovacanza:devfrom
KJhellico:upd-make-cmd

Conversation

@KJhellico
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico commented Dec 27, 2025

Proposed change

Update make script for Windows (add dependency upgrade target).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 27, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

  • New Features
    • Added a new upgrade command to the build system, enabling users to perform dependency updates through a dedicated workflow.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds an "upgrade" command to the make.cmd script with corresponding help documentation. The new command runs uv lock --upgrade followed by uv sync --all-groups to enable dependency upgrade workflows. No existing functionality is modified or removed.

Changes

Cohort / File(s) Summary
Build Script Enhancement
make.cmd		 Added new "upgrade" command to help output and implemented :Upgrade section with uv lock and sync operations for dependency management

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • vacanza/holidays#3166 — Introduces the same "upgrade" build target with identical uv commands and help documentation updates.

Suggested labels

script

Suggested reviewers

  • arkid15r
  • PPsyrius

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a dependency upgrade target to the Windows make script (make.cmd).
Description check ✅ Passed The description is directly related to the changeset, clearly explaining the purpose of updating the make script to add a dependency upgrade target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0f65700) to head (5c5cd74).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18288     18288           
  Branches      2336      2336           
=========================================
  Hits         18288     18288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius
PPsyrius approved these changes Dec 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛠️

@arkid15r arkid15r added this pull request to the merge queue Dec 28, 2025
arkid15r
arkid15r reviewed Dec 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, 🪟...

Thanks for keeping that consistent 👍

Merged via the queue into vacanza:dev with commit 8d38ad7 Dec 28, 2025
33 checks passed
@KJhellico KJhellico deleted the upd-make-cmd branch December 28, 2025 19:21
@arkid15r arkid15r mentioned this pull request Jan 5, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 19, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius