Skip to content

Add dependency upgrade Makefile target#3166

Merged
arkid15r merged 3 commits intovacanza:devfrom
arkid15r:try-uv-upgrade
Dec 25, 2025
Merged

Add dependency upgrade Makefile target#3166
arkid15r merged 3 commits intovacanza:devfrom
arkid15r:try-uv-upgrade

Conversation

@arkid15r
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r commented Dec 25, 2025

Proposed change

Add dependency upgrade Makefile target

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 25, 2025 •
edited
Loading

Summary by CodeRabbit

  • New Features

    • Added a new public "upgrade" command to upgrade and synchronize project dependencies.

  • Documentation

    • Help output updated to document the new "upgrade" command and its purpose (dependency upgrade).

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds a new upgrade Makefile target that runs uv lock --upgrade followed by uv sync --all-groups. Updates the Makefile help output to document the new upgrade target.

Changes

Cohort / File(s) Summary
Makefile targets and help
Makefile		 Adds new upgrade target with recipe uv lock --upgrade then uv sync --all-groups; updates help text to include the upgrade entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding a Makefile target for dependency upgrades.
Description check ✅ Passed The description is directly related to the changeset, stating the purpose of adding a dependency upgrade Makefile target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ac9d20 and 8ca0e04.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Makefile
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings 
Learnt from: PPsyrius
Repo: vacanza/holidays PR: 2398
File: holidays/groups/islamic.py:301-301
Timestamp: 2025-04-01T14:14:01.519Z
Learning: Running `make pre-commit` in the holidays project can automatically fix common code style issues like whitespace in blank lines.
📚 Learning: 2025-04-01T14:14:01.519Z 
Learnt from: PPsyrius
Repo: vacanza/holidays PR: 2398
File: holidays/groups/islamic.py:301-301
Timestamp: 2025-04-01T14:14:01.519Z
Learning: Running `make pre-commit` in the holidays project can automatically fix common code style issues like whitespace in blank lines.

Applied to files:

  • Makefile
📚 Learning: 2025-06-10T05:07:29.372Z 
Learnt from: PPsyrius
Repo: vacanza/holidays PR: 2608
File: holidays/locale/en_VC/LC_MESSAGES/VC.po:61-66
Timestamp: 2025-06-10T05:07:29.372Z
Learning: For missing translator comments in .po localization files in the holidays repository, direct authors to run `make l10n` or `make check` commands instead of suggesting manual fixes, as these commands automatically handle translator comment generation.

Applied to files:

  • Makefile
📚 Learning: 2025-06-10T05:08:07.939Z 
Learnt from: PPsyrius
Repo: vacanza/holidays PR: 2608
File: holidays/locale/en_US/LC_MESSAGES/VC.po:76-76
Timestamp: 2025-06-10T05:08:07.939Z
Learning: For the holidays project, localization file formatting issues (like missing terminal periods in .po files) should be automatically fixed by running `make l10n` command (which is included in `make check`). Authors should be directed to use this automated tooling instead of manual formatting fixes.

Applied to files:

  • Makefile
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Test Python 3.14 on windows-latest
  • GitHub Check: Test Python 3.13 on windows-latest
  • GitHub Check: Test Python 3.12 on windows-latest
  • GitHub Check: Test Python 3.11 on windows-latest
  • GitHub Check: Test Python 3.10 on windows-latest
🔇 Additional comments (2)
Makefile (2)

11-11: LGTM!

Help text is consistent with the existing format and accurately describes the new target.

62-64: Clarify intended behavior vs. past feedback.

The current implementation runs both lock upgrade and sync. A previous reviewer suggested just uv lock --upgrade.

Consider:

  • Current approach: updates lock file and installs new versions immediately
  • Simpler approach: updates lock file only, leaves installation as a separate step

Which behavior do you prefer for the upgrade target?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6ac9d20) to head (8ca0e04).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18249     18249           
  Branches      2327      2327           
=========================================
  Hits         18249     18249

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico reviewed Dec 25, 2025
View reviewed changes
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arkid15r arkid15r marked this pull request as ready for review December 25, 2025 18:01
@arkid15r arkid15r requested a review from PPsyrius as a code owner December 25, 2025 18:01
@arkid15r arkid15r enabled auto-merge December 25, 2025 18:01
@arkid15r arkid15r requested a review from KJhellico December 25, 2025 18:01
KJhellico
KJhellico approved these changes Dec 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Dec 25, 2025
Merged via the queue into vacanza:dev with commit 22b7f89 Dec 25, 2025
33 checks passed
@arkid15r arkid15r deleted the try-uv-upgrade branch December 25, 2025 23:05
@coderabbitai coderabbitai bot mentioned this pull request Dec 27, 2025
Merged
9 tasks
@arkid15r arkid15r mentioned this pull request Jan 5, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 17, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @KJhellico