Skip to content

Move version source of truth to holidays/VERSION#3157

Merged
arkid15r merged 1 commit intovacanza:devfrom
arkid15r:update-version-handling
Dec 21, 2025
Merged

Move version source of truth to holidays/VERSION#3157
arkid15r merged 1 commit intovacanza:devfrom
arkid15r:update-version-handling

Conversation

@arkid15r
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r commented Dec 20, 2025

Proposed change

Resolve dependabot problem.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 20, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

  • Chores
    • Updated version handling: package version is now read from a VERSION file and resolved at runtime; build configuration adjusted accordingly.
    • Internal version declaration replaced with dynamic resolution to reflect the packaged version without changing public APIs.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Refactors version management: adds a top-level VERSION file, updates pyproject.toml to source version from that file, changes holidays/version.py to read the installed package version via importlib.metadata, and updates RELEASE.md to reference the new VERSION path.

Changes

Cohort / File(s) Summary
Version file & build config
VERSION, pyproject.toml		 Added VERSION containing 0.88; changed packaging config to read version from the top-level VERSION file instead of the package attribute.
Runtime version retrieval
holidays/version.py		 Replaced static __version__ assignment with dynamic retrieval: from importlib.metadata import version and __version__ = version("holidays").
Release docs
RELEASE.md		 Updated post-release instruction to reference VERSION (top-level) instead of holidays/version.py.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Check holidays/version.py for compatibility with supported Python versions (availability of importlib.metadata) and behavior in editable/dev installs.
  • Verify pyproject.toml correctly resolves the top-level VERSION during build and packaging.
  • Confirm VERSION content and installed package metadata stay synchronized to avoid mismatches.

Suggested reviewers

  • KJhellico
  • PPsyrius

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: moving version source of truth to holidays/VERSION file.
Description check ✅ Passed The description is related to the changeset, mentioning resolving a dependabot problem and indicating the contributor ran checks locally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1db6d4c) to head (6d945ed).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18248     18249    +1     
  Branches      2327      2327           
=========================================
+ Hits         18248     18249    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkid15r arkid15r marked this pull request as ready for review December 20, 2025 20:28
KJhellico
KJhellico approved these changes Dec 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Dec 21, 2025
Merged via the queue into vacanza:dev with commit a9d4d78 Dec 21, 2025
33 checks passed
@arkid15r arkid15r deleted the update-version-handling branch December 21, 2025 01:07
@arkid15r arkid15r mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @KJhellico