Update Taiwan holidays in 2025-2026 by orcahmlee · Pull Request #3156 · vacanza/holidays

orcahmlee · 2025-12-20T07:24:12Z

Proposed change

Since the Taiwan government issued the revised calendar on 2025-06-17, we have two fewer days off, specifically 2025-09-29 and 2025-10-24, related to #3155 .

REF:

Original 2025 calendar issued on 2024-07-09: https://www.dgpa.gov.tw/en/information?uid=353&pid=11979
Revised 2025 calendar issued on 2025-06-17: https://www.dgpa.gov.tw/en/information?uid=353&pid=12579

After adding the missing day off, the output would be:

from datetime import date
import holidays

holidays.TW().get(date(2025, 9, 29))
# "Confucius' Birthday (observed)"
holidays.TW().get(date(2025, 10, 24))
# 'Taiwan Restoration and Guningtou Victory Memorial Day (observed)'

Resolves #3155 .

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2025-12-20T07:24:26Z

Walkthrough

Updates Taiwan holiday rules and tests: several holidays (Labor Day, Confucius' Birthday, Taiwan Restoration & Guningtou Memorial Day, Constitution Day) are now collected as observed dates for year thresholds (2025/2026); static-source URLs for 2025/2026 updated; tests adjusted for new substituted-observed dates; Andrew Li added to CONTRIBUTORS.

Changes

Cohort / File(s)	Summary
Holiday logic & static data `holidays/countries/taiwan.py`	For year thresholds (>=2025/>=2026) several holidays (Labor Day, Confucius' Birthday, Taiwan Restoration & Guningtou Memorial Day, Constitution Day) are now appended to an observed-dates collection (`dts_observed`) instead of being added directly. `TaiwanStaticHolidays.special_public_holidays_observed` doc/data updated: 2025 source URL replaced (archived) and a 2026 URL entry added.
Tests `tests/countries/test_taiwan.py`	Adds expected substituted/observed holiday assertions for 2025: `2025-09-29` (孔子誕辰紀念日（補假）) and `2025-10-24` (臺灣光復暨金門古寧頭大捷紀念日（補假）). Also adds multiple other substituted-date checks across years for Labor Day, Confucius' Birthday, Taiwan Retrocession Day, and Constitution Day.
Meta / Contributors `CONTRIBUTORS`	Inserts contributor name `Andrew Li`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Review year-gated logic (>=2025 / >=2026) and ensure observed-date collection is populated and later applied correctly.
Verify updated 2025 URL and added 2026 URL in TaiwanStaticHolidays.special_public_holidays_observed.
Run tests, focusing on the new substituted/observed assertions and the broader set of added substituted-date checks.

Possibly related PRs

Update Taiwan holidays #2653 — Overlapping changes to Taiwan holiday handling and observed-date logic for the same holidays/year thresholds.
Update Taiwan holidays: add categories support #2349 — Similar modifications to how observed/substituted Taiwan holidays are populated.

Suggested labels

snapshot

Suggested reviewers

arkid15r
PPsyrius

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is well-related to the changeset, explaining the government-issued revised calendar, referencing issue #3155, and providing concrete examples of the expected output.
Linked Issues check	✅ Passed	The PR changes meet the linked issue #3155 requirements by adding observed holidays for 2025-09-29 and 2025-10-24, with code updates to handle the revised Taiwan government calendar.
Out of Scope Changes check	✅ Passed	All changes align with issue #3155: Taiwan holiday data for 2025. The addition of Andrew Li to CONTRIBUTORS is a minor attribution change commonly included with code contributions.
Title check	✅ Passed	The title accurately captures the main change: updating Taiwan holiday observances for 2025-2026 to reflect government calendar revisions.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

orcahmlee · 2025-12-20T07:27:47Z

Hi @arkid15r @KJhellico @PPsyrius ,
Would you like to review it?

codecov · 2025-12-20T07:28:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8de88f2) to head (717e15c).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18249     18249           
  Branches      2327      2327           
=========================================
  Hits         18249     18249

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

holidays/countries/taiwan.py

KJhellico · 2025-12-20T19:12:30Z

I think it would be more correct to simply add these holidays to dts_observed, since the dates correspond to the standard rule. (This also applies to Labor Day and Constitution Day, although we will be able to check this only in 2027)

Signed-off-by: Andrew Li <[email protected]>

…dated the reference in docstring (vacanza#3155) Signed-off-by: Andrew Li <[email protected]>

orcahmlee · 2025-12-21T15:31:13Z

I think it would be more correct to simply add these holidays to dts_observed, since the dates correspond to the standard rule. (This also applies to Labor Day and Constitution Day, although we will be able to check this only in 2027)

Thanks for your review. I've rebased a new version.

KJhellico

And I propose to add the same to Labor Day and Constitution Day.

holidays/countries/taiwan.py

KJhellico · 2025-12-21T16:11:28Z

I've rebased a new version.

Please refrain from rebasing on the published PR branch in the future.

…d dec_25 (vacanza#3155) Signed-off-by: Andrew Li <[email protected]>

orcahmlee · 2025-12-22T07:39:57Z

And I propose to add the same to Labor Day and Constitution Day.

Thanks for your review. Already added these holidays.

PPsyrius

LGTM 🇹🇼

sonarqubecloud · 2025-12-22T12:33:27Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico

LGTM.

arkid15r

Thank you @orcahmlee
Merging this 👍

orcahmlee requested review from KJhellico, PPsyrius and arkid15r as code owners December 20, 2025 07:24

github-actions bot added the test label Dec 20, 2025

coderabbitai bot previously approved these changes Dec 20, 2025

View reviewed changes

orcahmlee dismissed coderabbitai[bot]’s stale review via 1c43940 December 20, 2025 07:32

coderabbitai bot previously approved these changes Dec 20, 2025

View reviewed changes

PPsyrius reviewed Dec 20, 2025

View reviewed changes

holidays/countries/taiwan.py Show resolved Hide resolved

orcahmlee dismissed coderabbitai[bot]’s stale review via db51697 December 20, 2025 08:05

coderabbitai bot previously approved these changes Dec 20, 2025

View reviewed changes

orcahmlee added 3 commits December 21, 2025 22:57

test(test_taiwan): update the test case (vacanza#3155)

cc07012

Signed-off-by: Andrew Li <[email protected]>

docs(contributors): updated the list of contributors (vacanza#3155)

b7ce6de

Signed-off-by: Andrew Li <[email protected]>

fix(taiwan): fix(taiwan): added thees holidays to dts_observed and up…

c9a9327

…dated the reference in docstring (vacanza#3155) Signed-off-by: Andrew Li <[email protected]>

orcahmlee dismissed coderabbitai[bot]’s stale review via c9a9327 December 21, 2025 15:29

orcahmlee force-pushed the update-2025 branch from db51697 to c9a9327 Compare December 21, 2025 15:29

coderabbitai bot previously approved these changes Dec 21, 2025

View reviewed changes

KJhellico reviewed Dec 21, 2025

View reviewed changes

holidays/countries/taiwan.py Show resolved Hide resolved

holidays/countries/taiwan.py Show resolved Hide resolved

orcahmlee added 3 commits December 22, 2025 09:11

Merge branch 'vacanza:dev' into update-2025

582f8dc

Merge branch 'vacanza:dev' into update-2025

1bd4601

fix(taiwan): refactored the sep_28, oct_25 and added the labor_day an…

eedc39e

…d dec_25 (vacanza#3155) Signed-off-by: Andrew Li <[email protected]>

orcahmlee dismissed coderabbitai[bot]’s stale review via eedc39e December 22, 2025 07:37

orcahmlee requested a review from KJhellico December 22, 2025 07:40

coderabbitai bot previously approved these changes Dec 22, 2025

View reviewed changes

PPsyrius previously approved these changes Dec 22, 2025

View reviewed changes

Add observed holidays tests

717e15c

KJhellico dismissed stale reviews from PPsyrius and coderabbitai[bot] via 717e15c December 22, 2025 12:32

coderabbitai bot approved these changes Dec 22, 2025

View reviewed changes

PPsyrius approved these changes Dec 22, 2025

View reviewed changes

KJhellico approved these changes Dec 22, 2025

View reviewed changes

PPsyrius changed the title ~~Update Taiwan holidays in 2025~~ Update Taiwan holidays in 2025-2026 Dec 23, 2025

arkid15r reviewed Dec 23, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Dec 23, 2025

Merged via the queue into vacanza:dev with commit 7eebcee Dec 23, 2025
33 checks passed

arkid15r mentioned this pull request Jan 5, 2026

v0.88 #3192

Merged

Uh oh!

Conversation

orcahmlee commented Dec 20, 2025 • edited by PPsyrius Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

orcahmlee commented Dec 20, 2025

Uh oh!

codecov bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

KJhellico commented Dec 20, 2025

Uh oh!

orcahmlee commented Dec 21, 2025

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KJhellico commented Dec 21, 2025

Uh oh!

orcahmlee commented Dec 22, 2025

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Dec 22, 2025

Quality Gate passed

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

orcahmlee commented Dec 20, 2025 •

edited by PPsyrius

Loading

coderabbitai bot commented Dec 20, 2025 •

edited

Loading

codecov bot commented Dec 20, 2025 •

edited

Loading