Skip to content

Library-wide th l10n typo cleanup#3097

Merged
arkid15r merged 6 commits intovacanza:devfrom
PPsyrius:th_typo_maundy_thursday
Dec 1, 2025
Merged

Library-wide th l10n typo cleanup#3097
arkid15r merged 6 commits intovacanza:devfrom
PPsyrius:th_typo_maundy_thursday

Conversation

@PPsyrius
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius commented Dec 1, 2025 •
edited
Loading

Proposed change

Thai (th) language l10n typo cleanups as initially spotted by the dependabot in #3096 . Others are th l10 unification/ensuring they fits better with the original holiday names wording.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 1, 2025 •
edited
Loading

Summary by CodeRabbit

  • Localization

    • Improved Thai holiday name translations across multiple country locales with spelling corrections and diacritic adjustments.
    • Fixed duplicated words and refined translation consistency.

  • Tests

    • Updated test expectations to align with corrected Thai translations.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This PR updates Thai locale translations across multiple holiday calendars and corresponding test expectations. Changes include correcting diacritics in "Maundy Thursday" translations, removing duplicate words, and refining holiday phrase translations. No logic or functional code is modified—only locale data.

Changes

Cohort / File(s) Summary
Maundy Thursday Thai localization corrections
holidays/locale/th/LC_MESSAGES/DK.po, ES.po, NO.po, TL.po, US.po, VA.po		 Diacritic and spelling corrections to "Maundy Thursday" translation across multiple locale files: "วันพฤหัสศักดิสิทธิ์" → "วันพฤหัสศักดิ์สิทธิ์"
Other Thai locale updates
holidays/locale/th/LC_MESSAGES/CA.po, CN.po, FI.po, HK.po		 Updated translations: Discovery Day phrase refined (CA), Youth Day string preserved (CN), duplicate word removed from Minna Canth Day (FI), Christmas Day variants reworded (HK)
Maundy Thursday test expectations
tests/countries/test_denmark.py, test_spain.py, test_norway.py, test_timor_leste.py, test_united_states.py, test_united_states_virgin_islands.py, test_vatican_city.py		 Test assertions updated to match corrected Thai diacritics for Maundy Thursday
Other test expectations
tests/countries/test_aland_islands.py, test_canada.py, test_china.py, test_finland.py, test_hongkong.py, test_svalbard_and_jan_mayen.py		 Test expectations updated for Discovery Day, Youth Day, Minna Canth Day, and Christmas Day variants

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • The majority of changes follow a repetitive pattern (same diacritic fix across multiple files), reducing cognitive overhead
  • Thai language correctness should be spot-checked, particularly for the non-standard fixes (Discovery Day, Minna Canth Day, Christmas Day variants)
  • All changes are confined to locale data and test expectations—no functional code review needed

Possibly related PRs

Suggested reviewers

  • arkid15r
  • KJhellico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: library-wide Thai localization typo corrections.
Description check ✅ Passed The description clearly relates to the changeset: Thai localization typo cleanups across multiple locale files and corresponding test files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8bd4018) to head (285a0b6).
⚠️ Report is 5 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3097   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18085     18085           
  Branches      2311      2311           
=========================================
  Hits         18085     18085

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico approved these changes Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

arkid15r
arkid15r approved these changes Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted by the dependabot

🤔

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Dec 1, 2025
Merged via the queue into vacanza:dev with commit badf422 Dec 1, 2025
33 checks passed
@arkid15r arkid15r mentioned this pull request Dec 1, 2025
Merged
@PPsyrius PPsyrius deleted the th_typo_maundy_thursday branch December 2, 2025 02:08
@coderabbitai coderabbitai bot mentioned this pull request Mar 30, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

l10n test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico