Add assert{variant}HolidayDatesInYear, assert{variant}HolidaysInYear test methods#3090
Add assert{variant}HolidayDatesInYear, assert{variant}HolidaysInYear test methods#3090arkid15r merged 9 commits intovacanza:devfrom
assert{variant}HolidayDatesInYear, assert{variant}HolidaysInYear test methods#3090Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 48 files out of 155 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3090 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 306 306
Lines 18108 18108
Branches 2309 2309
=========================================
Hits 18108 18108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit d2baa91.
Co-authored-by: ~Jhellico <[email protected]> Signed-off-by: Panpakorn Siripanich <[email protected]>
|



Proposed change
I tried to better utilise the now centralised test setups implemented in #2881 by switching to
assert{variant}HolidayDatesInYearandassert{variant}HolidaysInYeartest methods to avoid duplicate test setups.While not as blazingly fast as before that PR was implemented, which was ~55-70s (as we've yet to port all remaining countries' tests to the new system - see #3065 ), this should help us a bit.
Note that this still excludes cases where we did year-specific checks for multiple categories at the same time.
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.