Update Sri Lanka holidays in 2026 by PPsyrius · Pull Request #3033 · vacanza/holidays

PPsyrius · 2025-10-30T09:10:56Z

Proposed change

Update Sri Lanka holidays in 2026.
Move start_year to 2003 (we don't really have Poya Full Moon Day sources before this on our hands anyway)
Refactor Sri Lanka's test cases to modern library-wide standards.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2025-10-30T09:11:12Z

Summary by CodeRabbit

New Features
- Extended Sri Lanka holiday calendar coverage through 2026 with all major observances including Poya Days, Islamic holidays (Eid al-Adha, Eid al-Fitr, Mawlid), Hindu holidays (Diwali), and Christian holidays (Good Friday, Christmas Day).
- Updated supported year range from 1972–2025 to 2003–2026.
Chores
- Updated locale translations for Sinhala and Tamil language support.

Walkthrough

Extended Sri Lanka holiday data to include 2026: added 2026 Poya dates, Islamic and Hindu holiday entries, adjusted Sri Lanka start/end year bounds, updated Vesak handling and locale translations, removed older snapshot history, and expanded tests to cover the new ranges and entries. (≈50 words)

Changes

Cohort / File(s)	Summary
Sinhala calendar data `holidays/calendars/sinhala.py`	Added 2026 entries to all Poya date mappings and bumped `_SinhalaLunar.END_YEAR` 2025 → 2026.
Sri Lanka holiday definitions `holidays/countries/sri_lanka.py`	Updated `start_year` 1972 → 2003 and `end_year` 2025 → 2026; added 2026 dates for Islamic (Eid al‑Adha, Eid al‑Fitr, Mawlid), Hindu (Diwali), Good Friday, Christmas and other holiday mappings; added special public/workday 2026 entry; adjusted Vesak follow-up logic to use `vesak_poya`.
Localization (PO files) `holidays/locale/en_US/LC_MESSAGES/LK.po`, `holidays/locale/si_LK/LC_MESSAGES/LK.po`, `holidays/locale/ta_LK/LC_MESSAGES/LK.po`	Bumped PO metadata (Project-Id-Version, PO-Revision-Date, X-Generator); inserted consolidated Good Friday and Christmas translations and removed duplicates/reordered entries.
Snapshot data `snapshots/countries/LK_COMMON.json`	Removed historical 1972–2002 sequence; adjusted 2025 formatting and appended comprehensive 2026 holiday entries.
Tests `tests/countries/test_sri_lanka.py`	Updated test year ranges and added extensive tests validating Poya days, Tamil Pongal, Deepavali, Good Friday, Vesak logic, Maha Sivarathri, and numerous 2026-specific cases.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Verify changing SriLanka.start_year (1972 → 2003) and snapshot removals do not drop required historical behaviors.
Spot-check all newly added 2026 date constants and country mappings for typos or off-by-one/year errors.
Review Vesak follow-up logic change to ensure consistency with prior behavior.
Run and inspect expanded tests for flakiness, duplicated assertions, or incorrect expected dates.

Possibly related PRs

Update Sri Lanka holidays: testcase name typo fixed #2940 — modifies tests/countries/test_sri_lanka.py; likely overlaps with test adjustments and naming changes in this PR.

Suggested reviewers

arkid15r
KJhellico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.33% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Update Sri Lanka holidays in 2026" directly summarizes the primary objective of this pull request. The changeset extends Sri Lanka holiday support to include the year 2026 across multiple calendar systems (Sinhala lunar calendar, Christian holidays, Islamic holidays, Hindu holidays, and special public holidays). While the PR also includes secondary changes like moving start_year to 2003 and refactoring test cases, the title appropriately captures the main focus. The phrasing is concise, clear, and specific enough that a teammate scanning the commit history would understand the primary change.
Description Check	✅ Passed	The description is clearly related to the changeset and provides specific information about the three main aspects of the change. It explicitly mentions updating Sri Lanka holidays in 2026, explains the reasoning for moving start_year to 2003 (noting lack of available sources for Poya Full Moon Day before 2003), and describes the test case refactoring to modern standards. The description is neither vague nor generic, and directly aligns with the actual modifications visible in the raw summary across all affected files.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3fc16 and 48fc1e0.

📒 Files selected for processing (1)

holidays/calendars/sinhala.py (13 hunks)

🧰 Additional context used

🧠 Learnings (15)

📓 Common learnings

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_indonesia.py:221-223
Timestamp: 2025-09-28T05:42:12.777Z
Learning: In tests/countries/test_indonesia.py, the manual set inclusion checks using get_named and years_found for Lunar New Year (test_lunar_new_year) and Vesak Day (test_vesak_day) are intentional and should remain until both holidays get their own `{insert}_no_estimated` flags implemented, rather than using standard harness assertions like assertHolidayName/assertNoHolidayName.

Learnt from: KJhellico
PR: vacanza/holidays#2777
File: holidays/countries/gambia.py:120-122
Timestamp: 2025-08-03T13:48:11.910Z
Learning: When reviewing holiday implementations in the holidays library, defer to the maintainers' choice of start years for specific holiday policies, as they likely have access to more reliable primary sources and official documentation than what can be found through web searches.

Learnt from: KJhellico
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:171-183
Timestamp: 2025-03-29T15:15:05.919Z
Learning: In the Fiji holidays implementation, the maintainers are aware of the need to extend the MAWLID_DATES dictionary beyond 2025 when future official references become available, and will do so when appropriate. No suggestions about extending this dictionary should be made in future reviews.

Learnt from: PPsyrius
PR: vacanza/holidays#2537
File: tests/countries/test_finland.py:23-26
Timestamp: 2025-05-09T18:36:09.607Z
Learning: The holidays project prioritizes complete historical coverage in tests, verifying holidays from their first year of observance (e.g., 1853 for Finland) through future projections, rather than using shorter sliding windows.

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_south_africa.py:22-22
Timestamp: 2025-09-14T04:41:10.139Z
Learning: South Africa's observed holiday system only started in 1995, so in tests/countries/test_south_africa.py, using years_non_observed=range(1995, 2050) is intentional to limit testing to years where observed holidays actually exist, improving both correctness and performance.

Learnt from: PPsyrius
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:146-159
Timestamp: 2025-03-19T16:54:58.657Z
Learning: In the holidays library implementation, explicit holiday dates (like Diwali in Fiji) are only defined for historical years with official sources (2016-2025). Future dates beyond the explicitly defined range are automatically calculated by methods like `_add_diwali`, which provide approximations when official dates aren't yet available.

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_curacao.py:29-29
Timestamp: 2025-09-20T12:24:28.864Z
Learning: For Curacao in the holidays library, PUBLIC and HALF_DAY categories have different start years - PUBLIC holidays begin at the country's start_year while HALF_DAY holidays begin in 2010. When testing no_holidays methods, each category should be tested separately with appropriate pre-start years rather than using a unified supported_categories approach.

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_belgium.py:28-30
Timestamp: 2025-09-20T12:21:50.877Z
Learning: Belgium holidays implementation currently lacks a start_year attribute. In tests/countries/test_belgium.py, do not suggest adding test_no_holidays methods that rely on start_year until the start_year attribute is introduced to Belgium's holiday implementation.

Learnt from: KJhellico
PR: vacanza/holidays#2530
File: tests/countries/test_andorra.py:23-28
Timestamp: 2025-05-06T21:07:11.577Z
Learning: In the holidays project, test methods for country holidays follow a standard form where year ranges are explicitly recreated in each test method rather than being stored as class variables, to maintain consistency across all country tests.

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_saint_helena_ascension_and_tristan_da_cunha.py:209-209
Timestamp: 2025-09-14T17:17:14.387Z
Learning: In tests/countries/test_saint_helena_ascension_and_tristan_da_cunha.py, the explicit loop iteration pattern for subdivision-specific holiday checks (like Anniversary Day for TA subdivision) is intentionally preferred over using assertSubdivTa helper methods, as confirmed by PPsyrius.

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_argentina.py:375-375
Timestamp: 2025-09-03T16:49:35.246Z
Learning: In the holidays library, national holiday tests use self.full_range (or similar comprehensive year ranges) even when explicit test dates only show modern observance. This is intentional for correctness and comprehensive coverage, unlike subdivision-specific holidays which have explicit year boundaries based on known start dates.

Learnt from: PPsyrius
PR: vacanza/holidays#2833
File: holidays/countries/uganda.py:50-56
Timestamp: 2025-08-25T09:57:22.291Z
Learning: In the holidays package, when adding comments for year-restricted holidays in Uganda and similar country modules, include specific legal or historical context such as the actual laws, parliamentary acts, or government decisions that established the holidays, rather than just generic "since YEAR" information. For example, reference the specific Parliament act, decree, or historical event that created the holiday.

Learnt from: PPsyrius
PR: vacanza/holidays#2489
File: holidays/countries/sao_tome_and_principe.py:22-26
Timestamp: 2025-04-23T14:55:35.504Z
Learning: References in holidays classes should only be included if they're used for test case cross-checks or provide historical context about when holidays were added/removed, not just for the sake of having more references.

Learnt from: PPsyrius
PR: vacanza/holidays#2489
File: holidays/countries/sao_tome_and_principe.py:22-26
Timestamp: 2025-04-23T14:55:35.504Z
Learning: References in holidays classes should only be included if they're used for test case cross-checks or provide historical context about when holidays were added/removed, not just for the sake of having more references.

📚 Learning: 2025-03-19T16:54:58.657Z

Learnt from: PPsyrius
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:146-159
Timestamp: 2025-03-19T16:54:58.657Z
Learning: In the holidays library implementation, explicit holiday dates (like Diwali in Fiji) are only defined for historical years with official sources (2016-2025). Future dates beyond the explicitly defined range are automatically calculated by methods like `_add_diwali`, which provide approximations when official dates aren't yet available.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-03-29T15:15:05.919Z

Learnt from: KJhellico
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:171-183
Timestamp: 2025-03-29T15:15:05.919Z
Learning: In the Fiji holidays implementation, the maintainers are aware of the need to extend the MAWLID_DATES dictionary beyond 2025 when future official references become available, and will do so when appropriate. No suggestions about extending this dictionary should be made in future reviews.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-09-17T15:15:24.269Z

Learnt from: KJhellico
PR: vacanza/holidays#2944
File: holidays/countries/myanmar.py:112-121
Timestamp: 2025-09-17T15:15:24.269Z
Learning: The Myanmar government's "continuous public days for 2024-2025" policy specifically covers Tabaung and Tazaungmon full moon days by bridging gaps with weekends, but does not apply to Myanmar New Year (Thingyan) extra days, which follow a separate policy that correctly uses `self._year >= 2024`.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-09-28T05:42:12.777Z

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_indonesia.py:221-223
Timestamp: 2025-09-28T05:42:12.777Z
Learning: In tests/countries/test_indonesia.py, the manual set inclusion checks using get_named and years_found for Lunar New Year (test_lunar_new_year) and Vesak Day (test_vesak_day) are intentional and should remain until both holidays get their own `{insert}_no_estimated` flags implemented, rather than using standard harness assertions like assertHolidayName/assertNoHolidayName.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-08-21T05:56:33.276Z

Learnt from: PPsyrius
PR: vacanza/holidays#2843
File: holidays/countries/burundi.py:15-16
Timestamp: 2025-08-21T05:56:33.276Z
Learning: In the holidays library, when importing Gregorian month constants from holidays.calendars.gregorian, only import the months that are actually used in the date data. For example, if Islamic holiday dates only reference JUN, JUL, SEP, OCT, then only import those specific constants rather than importing additional unused months.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-06-14T20:12:37.212Z

Learnt from: KJhellico
PR: vacanza/holidays#2614
File: holidays/countries/guyana.py:146-179
Timestamp: 2025-06-14T20:12:37.212Z
Learning: The `_CustomHinduHolidays` mechanism works through `_CustomCalendarType` metaclass which renames public attributes (like `DIWALI_INDIA_DATES`) with a postfix, allowing `_HinduLunisolar::_get_holiday` to find and use custom holiday dates. When `_add_diwali_india()` is called, it uses the custom dates if available rather than calculated dates.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-04-03T16:58:27.175Z

Learnt from: Wasif-Shahzad
PR: vacanza/holidays#2409
File: holidays/countries/qatar.py:27-46
Timestamp: 2025-04-03T16:58:27.175Z
Learning: In the holidays library, method names like `_add_holiday_2nd_tue_of_feb()` and `_add_holiday_1st_sun_of_mar()` use calendar constants internally through parent class implementations even when these constants don't appear directly in the file. Removing imports that seem unused based on a simple text search could break functionality.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-09-14T16:05:55.205Z

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_iran.py:28-28
Timestamp: 2025-09-14T16:05:55.205Z
Learning: In tests/countries/test_iran.py, using years=(self.start_year - 1, 2102) in the no-holiday test is intentional because Iran uses the Persian Calendar which has specific supported year range constraints, and 2102 represents the upper limit of the Persian Calendar's supported range, not just an arbitrary far-future date.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-08-08T21:52:45.289Z

Learnt from: KJhellico
PR: vacanza/holidays#2763
File: holidays/groups/mandaean.py:58-69
Timestamp: 2025-08-08T21:52:45.289Z
Learning: HolidayBase in the holidays library has a default end_year = 2100 (defined as DEFAULT_END_YEAR in holidays/constants.py), which is automatically inherited by all country classes unless explicitly overridden.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-09-14T16:03:13.558Z

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_barbados.py:21-23
Timestamp: 2025-09-14T16:03:13.558Z
Learning: In tests/countries/test_barbados.py, using years_non_observed=range(2000, 2024) is intentional because all observed holiday examples fall within 2001-2023, making this range appropriate for limiting testing to years where observed holidays actually exist in the test data.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-06-14T11:05:21.250Z

Learnt from: PPsyrius
PR: vacanza/holidays#2609
File: holidays/countries/nauru.py:48-50
Timestamp: 2025-06-14T11:05:21.250Z
Learning: In the holidays library, newer implementations use `start_year` to indicate the earliest year with complete holiday data coverage, not necessarily the first year a holiday existed. If a holiday system starts partway through a year (like Nauru's Public Holidays Act starting Jan 31, 1968), the start_year should be set to the following year (1969) to ensure users get full annual holiday coverage.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-09-14T04:44:28.854Z

Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_indonesia.py:22-22
Timestamp: 2025-09-14T04:44:28.854Z
Learning: In Indonesia's holidays implementation, observed holidays are only available in years 2004 and 2020 due to presidential decrees, so years_non_observed=(2004, 2020) should be passed as a tuple of discrete years rather than a range.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-09-17T15:16:16.192Z

Learnt from: KJhellico
PR: vacanza/holidays#2944
File: holidays/countries/myanmar.py:183-191
Timestamp: 2025-09-17T15:16:16.192Z
Learning: The special_public_holidays formatting pattern in the holidays codebase follows a consistent convention: single entries per year use flat tuple format like `2024: (MONTH, DAY, name)`, while multiple entries per year use tuple-of-tuples format like `2024: ((MONTH, DAY, name), (MONTH, DAY, name))`. This pattern is used consistently across all countries.

Applied to files:

holidays/calendars/sinhala.py

📚 Learning: 2025-04-08T14:50:15.325Z

Learnt from: KJhellico
PR: vacanza/holidays#2437
File: holidays/calendars/tibetan.py:805-810
Timestamp: 2025-04-08T14:50:15.325Z
Learning: The standard behavior for calendar date methods in the holidays library is to return `(None, True)` when a requested year is not found in the date dictionary, rather than raising an exception or requiring documentation for out-of-range years.

Applied to files:

holidays/calendars/sinhala.py

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Test Python 3.14 on windows-latest

🔇 Additional comments (2)

holidays/calendars/sinhala.py (2)

49-49: LGTM!

END_YEAR correctly updated to reflect 2026 coverage.

75-75: LGTM!

All 12 Poya date dictionaries consistently extended with 2026 entries. Format and structure match existing patterns.

Also applies to: 102-102, 128-128, 155-155, 182-182, 209-209, 236-236, 263-263, 290-290, 317-317, 344-344, 371-371

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-10-30T09:30:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (120f0f8) to head (48fc1e0).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3033   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18030     18027    -3     
  Branches      2333      2331    -2     
=========================================
- Hits         18030     18027    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico

LGTM! 👍

sonarqubecloud · 2025-10-30T17:13:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

Awesome!

LGTM

Update Sri Lanka holidays in 2026

ce6796f

PPsyrius requested review from KJhellico and arkid15r as code owners October 30, 2025 09:10

github-actions bot added l10n snapshot test labels Oct 30, 2025

Fix code coverage

5c3fc16

KJhellico approved these changes Oct 30, 2025

View reviewed changes

Merge branch 'dev' into sri_lanka_2026

48fc1e0

arkid15r reviewed Oct 30, 2025

View reviewed changes

arkid15r enabled auto-merge October 30, 2025 17:17

arkid15r added this pull request to the merge queue Oct 30, 2025

Merged via the queue into vacanza:dev with commit 8a7cbc1 Oct 30, 2025
33 checks passed

PPsyrius deleted the sri_lanka_2026 branch October 31, 2025 02:43

arkid15r mentioned this pull request Nov 3, 2025

v0.84 #3036

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Sri Lanka holidays in 2026#3033

Update Sri Lanka holidays in 2026#3033
arkid15r merged 3 commits intovacanza:devfrom
PPsyrius:sri_lanka_2026

PPsyrius commented Oct 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

KJhellico left a comment

Uh oh!

sonarqubecloud bot commented Oct 30, 2025

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PPsyrius commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 30, 2025

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PPsyrius commented Oct 30, 2025 •

edited

Loading

coderabbitai bot commented Oct 30, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading