Standardize `th` l10n for "{insert} Anniversary of...." by PPsyrius · Pull Request #3027 · vacanza/holidays

PPsyrius · 2025-10-29T15:54:52Z

Proposed change

Standardize th (Thai) l10n for "{insert} Anniversary of...." from "ครบรอบ" to "วันครบรอบ" as the latter is more widely used across this library.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2025-10-29T15:55:22Z

Summary by CodeRabbit

Localization
- Refined Thai translations for holiday names across multiple regions with improved phrasing and consistency for anniversary-related holidays.

Walkthrough

Thai locale translation files across multiple regions (China, Hong Kong, Korea, Macau) receive metadata version updates from 0.81 to 0.84, translator attribution changes, and refined translation strings with consistent prefixes added to enhance grammatical completeness.

Changes

Cohort / File(s)	Change Summary
Thai Locale Translation Updates `holidays/locale/th/LC_MESSAGES/CN.po`, `holidays/locale/th/LC_MESSAGES/HK.po`, `holidays/locale/th/LC_MESSAGES/KR.po`, `holidays/locale/th/LC_MESSAGES/MO.po`	Metadata bumped (Project-Id-Version 0.81 → 0.84); PO-Revision-Date and Last-Translator updated; X-Generator updated to Poedit 3.8. Translation strings refined by adding Thai prefix "วัน" (day) to anniversary/commemoration entries for grammatical consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

All changes follow a consistent, repetitive pattern across four identical file types
No functional logic or structural modifications
Straightforward metadata and translation string updates
Changes are mechanical and verifiable at a glance

Suggested reviewers

arkid15r
KJhellico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "Standardize `th` l10n for "{insert} Anniversary of...."" accurately reflects the main change in the changeset. All four modified files (CN.po, HK.po, KR.po, and MO.po) contain Thai translation updates where anniversary-related strings are being standardized from "ครบรอบ" to "วันครบรอบ". The title is specific and clear enough that a teammate scanning the history would immediately understand the primary change involves Thai localization standardization for anniversary-related terms.
Description Check	✅ Passed	The PR description directly relates to the changeset by explaining the standardization effort for Thai localization strings across multiple holiday locale files. It provides context about the specific change (from "ครบรอบ" to "วันครบรอบ") and rationale (wider usage across the library), confirms the PR type, and indicates the author has followed contributing guidelines and completed local testing. The description is clearly focused on the actual changes being made.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7f0478 and 52b1d34.

📒 Files selected for processing (4)

holidays/locale/th/LC_MESSAGES/CN.po (2 hunks)
holidays/locale/th/LC_MESSAGES/HK.po (2 hunks)
holidays/locale/th/LC_MESSAGES/KR.po (2 hunks)
holidays/locale/th/LC_MESSAGES/MO.po (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-28T02:34:11.657Z

Learnt from: PPsyrius
PR: vacanza/holidays#2860
File: holidays/groups/eastern.py:36-36
Timestamp: 2025-08-28T02:34:11.657Z
Learning: The default estimated_label change from "%s (estimated)" to "%s" in holidays/groups/eastern.py is intentional to remove English-only fallback text from localized holiday names. Countries that need estimated labels should define them properly with localization support rather than relying on the English fallback.

Applied to files:

holidays/locale/th/LC_MESSAGES/CN.po

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Test docs build
GitHub Check: Build distribution

🔇 Additional comments (8)

holidays/locale/th/LC_MESSAGES/HK.po (2)

17-17: Metadata updates look good.

Version bump to 0.84, updated revision date, and translator attribution are all appropriate.

Also applies to: 19-20, 27-27

204-204: Translation standardization is correct.

Adding "วัน" prefix makes the Thai translation grammatically complete and aligns with the library's localization standards.

holidays/locale/th/LC_MESSAGES/KR.po (2)

17-17: Metadata updates are consistent.

Version, translator, and tool updates match the other files in this PR.

Also applies to: 19-20, 27-27

173-173: Good catch on standardization.

This brings line 173 in line with the existing "วัน" prefix pattern already used in lines 157 and 161 of this file.

holidays/locale/th/LC_MESSAGES/MO.po (2)

17-17: Metadata updates are appropriate.

Standard version bump and attribution updates.

Also applies to: 19-20, 27-27

227-227: Translation standardization applied correctly.

The "วัน" prefix addition matches the pattern used in HK.po and CN.po for the same anniversary string.

holidays/locale/th/LC_MESSAGES/CN.po (2)

17-17: Metadata updates match the PR pattern.

Consistent version bump and attribution across all locale files.

Also applies to: 19-20, 27-27

109-109: Translation standardization complete.

This completes the consistent application of the "วัน" prefix across all four Thai locale files for anniversary strings. The standardization improves grammatical completeness and aligns with wider library usage.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2025-10-29T15:55:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-10-29T15:57:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f7f0478) to head (52b1d34).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          306       306           
  Lines        18064     18064           
  Branches      2333      2333           
=========================================
  Hits         18064     18064

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r

👍

KJhellico

LGTM. 😀

Standardize th l10n for "{insert} Anniversary of...."

52b1d34

PPsyrius requested review from KJhellico and arkid15r as code owners October 29, 2025 15:54

github-actions bot added the l10n label Oct 29, 2025

arkid15r enabled auto-merge October 29, 2025 16:08

arkid15r reviewed Oct 29, 2025

View reviewed changes

KJhellico approved these changes Oct 29, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Oct 29, 2025

Merged via the queue into vacanza:dev with commit 7728556 Oct 29, 2025
36 checks passed

PPsyrius deleted the th_standardize_anniv branch October 31, 2025 02:44

arkid15r mentioned this pull request Nov 3, 2025

v0.84 #3036

Merged

coderabbitai bot mentioned this pull request Mar 26, 2026

Standardize existing l10n files #3430

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Standardize `th` l10n for "{insert} Anniversary of...."#3027

Standardize `th` l10n for "{insert} Anniversary of...."#3027
arkid15r merged 1 commit intovacanza:devfrom
PPsyrius:th_standardize_anniv

PPsyrius commented Oct 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Oct 29, 2025

Uh oh!

codecov bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

KJhellico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PPsyrius commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

sonarqubecloud bot commented Oct 29, 2025

Quality Gate passed

Uh oh!

codecov bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PPsyrius commented Oct 29, 2025 •

edited

Loading

coderabbitai bot commented Oct 29, 2025 •

edited

Loading

codecov bot commented Oct 29, 2025 •

edited

Loading