Conversation
Summary by CodeRabbit
WalkthroughBumps Python version references from 3.13 to 3.14 across CI workflows, tox, tests, and docs configs; adds Python 3.14 classifier; updates a pre-commit hook revision; tweaks Read the Docs to use latest Python and adds mkdocs block. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Ruff (0.13.3)tests/common.py�[1;31mruff failed�[0m Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2997 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 305 305
Lines 17996 17996
Branches 2321 2321
=========================================
Hits 17996 17996 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/update-snapshots.yml (1)
21-30: Allow pre-release 3.14 on this runner too.This job will also choke until 3.14 GA because
setup-pythonwon’t serve it yet. Mirror the fix: enable prereleases before pinning to 3.14.- name: Set up Python uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c with: cache: pip cache-dependency-path: | requirements/build.txt requirements/runtime.txt check-latest: true - python-version: '3.14' + allow-prereleases: true + python-version: '3.14'.github/workflows/ci-cd.yml (1)
40-45: Enable prerelease installs wherever we pin 3.14.Every
setup-pythonstep that hard-pins'3.14'(pre-commit, build, test-build, test-docs) needsallow-prereleases: true; otherwise the action errors until the final 3.14 image ships. Please add it across those steps.with: check-latest: true - python-version: '3.14' + allow-prereleases: true + python-version: '3.14'Repeat the same tweak for the build, test-build, and test-docs jobs.
Also applies to: 126-134, 181-190, 216-222
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (8)
.github/workflows/ci-cd.yml(4 hunks).github/workflows/pre-commit-autoupdate.yml(1 hunks).github/workflows/update-snapshots.yml(1 hunks).pre-commit-config.yaml(1 hunks).readthedocs.yaml(1 hunks)pyproject.toml(1 hunks)tests/common.py(1 hunks)tox.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test Python 3.14 on windows-latest
- GitHub Check: Test Python 3.13 on windows-latest
🔇 Additional comments (1)
.readthedocs.yaml (1)
4-11: Double-checkpython: latestcompatibility.Read the Docs’ config schema usually expects an explicit version (for example
"3.12"). If"latest"isn’t accepted, the build will fail when this lands. Please confirm with RTD and pin to a supported value if needed.
3 participants
Proposed change
Switch to Python 3.14
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.