Skip to content

Update BY.po files#2452

Merged
arkid15r merged 1 commit intovacanza:devfrom
arkid15r:update-by-po
Apr 9, 2025
Merged

Update BY.po files#2452
arkid15r merged 1 commit intovacanza:devfrom
arkid15r:update-by-po

Conversation

@arkid15r
Copy link
Copy Markdown
Collaborator

@arkid15r arkid15r commented Apr 9, 2025

Proposed change

Automatically reformat BY.po files.

I know @KJhellico re-formatted them recently. So it could be OS/env related

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2025 •
edited
Loading

Summary by CodeRabbit

  • Chores
    • Enhanced the consistency and clarity of holiday translation entries across multiple languages for Belarus observances, ensuring a standardized presentation without altering the displayed holiday details.

Walkthrough

The pull request modifies comment line formatting in the Belarus holiday localization files. The changes adjust line breaks and spacing in the comments for better readability but do not alter the translation strings or functionality. All adjustments are strictly cosmetic, and no public or exported entities are affected.

Changes

File(s) Change Summary
holidays/locale/.../LC_MESSAGES/BY.po Adjusted comment line formatting across all localization files (Belarusian, English, Russian, Thai) for clarity.

Suggested reviewers

  • KJhellico
  • PPsyrius
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1f4eaf and fe9b113.

📒 Files selected for processing (4)
  • holidays/locale/be/LC_MESSAGES/BY.po (1 hunks)
  • holidays/locale/en_US/LC_MESSAGES/BY.po (1 hunks)
  • holidays/locale/ru/LC_MESSAGES/BY.po (1 hunks)
  • holidays/locale/th/LC_MESSAGES/BY.po (1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (1)
  • GitHub Check: Test build on windows-latest
🔇 Additional comments (4)
holidays/locale/be/LC_MESSAGES/BY.po (1)

50-53: Clear and concise reformatting of holiday comments.
The adjustments to the comment block for "Дзень Дзяржаўнага сцяга, Дзяржаўнага герба і Дзяржаўнага гімна Рэспублікі Беларусь" improve readability by properly grouping the phrases. No translation or functional changes were made.

holidays/locale/en_US/LC_MESSAGES/BY.po (1)

50-57: Enhanced clarity in the holiday comment formatting.
The reformatting splits the comment into logically clear segments, which helps maintain readability and consistency while leaving the translation string identical.

holidays/locale/th/LC_MESSAGES/BY.po (1)

50-55: Improved comment layout for better clarity.
The adjustments to the comment block now separate the description components cleanly, providing better context without affecting the underlying translation.

holidays/locale/ru/LC_MESSAGES/BY.po (1)

50-56: Refined comment structure enhances readability.
The comment lines have been reformatted to properly group the descriptive phrases for the holiday, improving clarity in the Russian localization file while leaving the translation text unchanged.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the l10n label Apr 9, 2025
@arkid15r arkid15r enabled auto-merge April 9, 2025 02:33
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c1f4eaf) to head (fe9b113).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2452   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          210       210           
  Lines        13348     13348           
  Branches      1909      1909           
=========================================
  Hits         13348     13348

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius
PPsyrius approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Apr 9, 2025
Merged via the queue into vacanza:dev with commit 3ec2742 Apr 9, 2025
33 checks passed
@arkid15r arkid15r deleted the update-by-po branch April 9, 2025 02:48
@coderabbitai coderabbitai bot mentioned this pull request Apr 10, 2025
Merged
9 tasks
@KJhellico KJhellico mentioned this pull request Apr 21, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 28, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PPsyrius PPsyrius PPsyrius approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

l10n

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @PPsyrius