Skip to content

Reformat BY.po files#2365

Merged
KJhellico merged 1 commit intovacanza:devfrom
PPsyrius:make_l10n_by
Mar 24, 2025
Merged

Reformat BY.po files#2365
KJhellico merged 1 commit intovacanza:devfrom
PPsyrius:make_l10n_by

Conversation

@PPsyrius
Copy link
Copy Markdown
Collaborator

@PPsyrius PPsyrius commented Mar 24, 2025

Proposed change

Cleaning up leftovers from #2356

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2025 •
edited
Loading

Summary by CodeRabbit

  • Documentation
    • Refined the formatting of holiday description messages in multiple language localizations to enhance clarity and consistency.
    • These cosmetic adjustments improve the internal readability of translation notes without altering the displayed holiday information.
    • End-user functionality remains unchanged, ensuring the same holiday details continue to be shown.

Walkthrough

The changes update localization files for a Belarus holiday by modifying the comment formatting preceding the translation messages. In each file, the phrasing is adjusted so that "Flag of the Republic of" is split into separate lines, now appearing as "Flag of the Republic". These adjustments improve comment clarity without impacting functionality or the translation content.

Changes

Files Summary
holidays/locale/{be,en_US,ru,th}/LC_MESSAGES/BY.po Modified comment formatting for the holiday translation: adjusted line breaks to separate "Flag of the Republic" from the adjacent text for clarity.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a2819b and 1e4a4be.

📒 Files selected for processing (4)
  • holidays/locale/be/LC_MESSAGES/BY.po (1 hunks)
  • holidays/locale/en_US/LC_MESSAGES/BY.po (1 hunks)
  • holidays/locale/ru/LC_MESSAGES/BY.po (1 hunks)
  • holidays/locale/th/LC_MESSAGES/BY.po (1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (1)
  • GitHub Check: Test build on windows-latest
🔇 Additional comments (4)
holidays/locale/ru/LC_MESSAGES/BY.po (1)

50-52: Enhanced Comment Formatting for Clarity.
The updated comment block now splits the descriptive text to remove the redundant "of Belarus" after "Flag of the Republic," thereby improving clarity for translators. Great cleanup!

holidays/locale/th/LC_MESSAGES/BY.po (1)

50-52: Improved Separation in Comment Lines.
The modification cleanly separates "Flag of the Republic" into its own line, which enhances readability without affecting the translation. Nice refactoring!

holidays/locale/en_US/LC_MESSAGES/BY.po (1)

50-52: Refined Comment Layout for Consistency.
The change to split the comment line—removing the extra “of Belarus” from the phrase—improves the visual structure and consistency with other localization files.

holidays/locale/be/LC_MESSAGES/BY.po (1)

50-52: Streamlined Comment Block for Better Readability.
Splitting the comment lines here to isolate "Flag of the Republic" enhances clarity in the po file. This cleanup is in line with the improvements made across other locales.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the l10n label Mar 24, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5a2819b) to head (1e4a4be).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          204       204           
  Lines        12853     12853           
  Branches      1817      1817           
=========================================
  Hits         12853     12853

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had also noticed this (but still didn't understand how it was formed), and I was going to fix it. 🙂

@KJhellico KJhellico changed the title Modify BY.po to match actual make l10n results Reformat BY.po files Mar 24, 2025
@KJhellico KJhellico added this pull request to the merge queue Mar 24, 2025
Merged via the queue into vacanza:dev with commit e5a9ed6 Mar 24, 2025
33 checks passed
@PPsyrius PPsyrius deleted the make_l10n_by branch March 25, 2025 12:04
@coderabbitai coderabbitai bot mentioned this pull request Apr 3, 2025
Merged
9 tasks
@arkid15r arkid15r mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

l10n

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PPsyrius @KJhellico