Merged
Conversation
Contributor
Author
|
Hi @dr-prodigy Maurizio, could you tell me if the code in my PR is ok or I should modify it? Ciao. |
Collaborator
|
Hi @rpanai , |
Contributor
Author
|
@dr-prodigy Could I ask you when is this going to move to the master branch? |
rpanai
added a commit
to rpanai/python-holidays
that referenced
this pull request
Jan 6, 2026
I made this PR vacanza#236 Signed-off-by: Roberto Panai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some fixes and add holidays for Chile. For my changes the coverage report is fine but for line 1000. I couldn't fix the tests failing for India.