Skip to content

Update IN holidays and localization#2259

Merged
arkid15r merged 120 commits intovacanza:devfrom
ankushhKapoor:dev
Mar 14, 2025
Merged

Update IN holidays and localization#2259
arkid15r merged 120 commits intovacanza:devfrom
ankushhKapoor:dev

Conversation

@ankushhKapoor
Copy link
Copy Markdown
Contributor

@ankushhKapoor ankushhKapoor commented Jan 31, 2025

Proposed change

  • Extended the holiday list for multiple regions in India.
  • Added holidays for various subdivisions and states, ensuring better coverage.
  • Updated documentation to include the new subdivisions/states and their respective holidays.

This PR addresses Issues #2182 , #2183 enhancing the holiday dataset by incorporating state-specific holidays and regional variations. The goal is to provide a more comprehensive representation of holidays in India, covering a wider range of locations.

I am a Winter of Code (WoC) 2025 contributor and am excited to contribute to the project with these updates. Let me know if any further modifications are needed!

Resolves #2182 and #2183 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e17adc8) to head (4d05c68).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##               dev     #2259    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          204       204            
  Lines        12609     12809   +200     
  Branches      1809      1810     +1     
==========================================
+ Hits         12609     12809   +200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushhKapoor, good start! Are you planning to add other regional holidays? According to Wiki, there are a lot of them.

@ankushhKapoor
Copy link
Copy Markdown
Contributor Author

@ankushhKapoor, good start! Are you planning to add other regional holidays? According to Wiki, there are a lot of them.

Thanks! Yep, I’m planning to add more regional holidays. The challenge is that each holiday falls on a different date every year, so I'm thinking of the most efficient approach to handle this. I'll add as many holidays as I can and will also include Hindi translations for each one.

@KJhellico
Copy link
Copy Markdown
Collaborator

The challenge is that each holiday falls on a different date every year, so I'm thinking of the most efficient approach to handle this.

You can use the same approach as for Diwali, Holi etc. Later, if we implement support for Indian calendar (actually, calendars), it will be possible to refactor this similarly to other lunar calendars.

@ankushhKapoor
Copy link
Copy Markdown
Contributor Author

ankushhKapoor commented Feb 2, 2025

The challenge is that each holiday falls on a different date every year, so I'm thinking of the most efficient approach to handle this.

You can use the same approach as for Diwali, Holi etc. Later, if we implement support for Indian calendar (actually, calendars), it will be possible to refactor this similarly to other lunar calendars.

Yes, I’m also thinking of doing the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve IN holidays

6 participants