Skip to content

Commit 9bdbf97

Browse files
PPsyriusPPsyrius
committed
Update Hong Kong holidays: standardizes en_US l10n with China's and Macau's implementation
1 parent 3f52858 commit 9bdbf97

File tree

8 files changed

+1117
-1123
lines changed

8 files changed

+1117
-1123
lines changed

‎holidays/countries/hongkong.py‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -86,24 +86,24 @@ def __init__(self, *args, **kwargs):
8686
super().__init__(*args, **kwargs)
8787

8888
def _add_mid_autumn(self) -> date:
89-
# Chinese Mid-Autumn Festival.
89+
# Mid-Autumn Festival.
9090

9191
mid_autumn_date = self._mid_autumn_festival
9292
if self._year >= 1968:
9393
mid_autumn_date = _timedelta(mid_autumn_date, +1)
94-
# The day following the Chinese Mid-Autumn Festival.
94+
# The Day following Mid-Autumn Festival.
9595
name = tr("中秋節翌日")
96-
# The second day following the Chinese Mid-Autumn Festival.
96+
# The Second Day following Mid-Autumn Festival.
9797
second_name = tr("中秋節後第二日")
9898
else:
99-
# Chinese Mid-Autumn Festival.
99+
# Mid-Autumn Festival.
100100
name = tr("中秋節")
101-
# The day following the Chinese Mid-Autumn Festival.
101+
# The Day following Mid-Autumn Festival.
102102
second_name = tr("中秋節翌日")
103103

104104
if self._is_sunday(mid_autumn_date):
105105
if 1983 <= self._year <= 2010:
106-
# Chinese Mid-Autumn Festival.
106+
# Mid-Autumn Festival.
107107
self._add_holiday(tr("中秋節"), _timedelta(mid_autumn_date, -1))
108108
else:
109109
self._add_holiday(second_name, _timedelta(mid_autumn_date, +1))
@@ -112,15 +112,15 @@ def _add_mid_autumn(self) -> date:
112112
return mid_autumn_date
113113

114114
def _add_lunar_new_year(self, day_three_start_year: int):
115-
# Lunar New Year's Day.
115+
# Chinese New Year.
116116
name = tr("農曆年初一")
117-
# The day preceding Lunar New Year's Day.
117+
# Chinese New Year's Eve.
118118
preceding_day_lunar = tr("農曆年初一的前一日")
119-
# The second day of Lunar New Year.
119+
# The second day of Chinese New Year.
120120
second_day_lunar = tr("農曆年初二")
121-
# The third day of Lunar New Year.
121+
# The third day of Chinese New Year.
122122
third_day_lunar = tr("農曆年初三")
123-
# The fourth day of Lunar New Year.
123+
# The fourth day of Chinese New Year.
124124
fourth_day_lunar = tr("農曆年初四")
125125
dt_lunar_new_year = self._chinese_new_year
126126
if self._year >= 1983:
@@ -156,7 +156,7 @@ def _populate_public_holidays(self):
156156
return None
157157

158158
if self._year >= 1977:
159-
# The first day of January.
159+
# New Year's Day.
160160
self._add_observed(self._add_new_years_day(tr("一月一日")))
161161

162162
self._add_lunar_new_year(day_three_start_year=1977)
@@ -173,28 +173,28 @@ def _populate_public_holidays(self):
173173
# Easter Monday.
174174
self._add_easter_monday(tr("復活節星期一"))
175175

176-
# Ching Ming Festival.
176+
# Tomb-Sweeping Day.
177177
self._add_observed(self._add_qingming_festival(tr("清明節")))
178178

179179
if self._year >= 2022:
180-
# The Birthday of the Buddha.
180+
# The Buddha's Birthday.
181181
self._add_observed(self._add_chinese_birthday_of_buddha(tr("佛誕")))
182182

183183
if self._year >= 1999:
184184
# Labor Day.
185185
self._add_observed(self._add_labor_day(tr("勞動節")))
186186

187-
# Tuen Ng Festival.
187+
# Dragon Boat Festival.
188188
self._add_observed(self._add_dragon_boat_festival(tr("端午節")))
189189

190190
if self._year >= 1997:
191-
# Hong Kong Special Administrative Region Establishment Day.
191+
# Hong Kong S.A.R. Establishment Day.
192192
self._add_observed(self._add_holiday_jul_1(tr("香港特別行政區成立紀念日")))
193193

194194
mid_autumn_date = self._add_mid_autumn()
195195

196196
if self._year >= 1977:
197-
# Chung Yeung Festival.
197+
# Double Ninth Festival.
198198
dt_double_ninth = self._add_double_ninth_festival(tr("重陽節"))
199199
self._add_observed(dt_double_ninth)
200200

@@ -211,7 +211,7 @@ def _populate_public_holidays(self):
211211
)
212212

213213
if WINTER_SOLSTICE in self.preferred_discretionary_holidays:
214-
# Chinese Winter Solstice Festival.
214+
# Winter Solstice.
215215
self._add_observed(self._add_holiday(tr("冬節"), self._winter_solstice_date))
216216

217217
if self._year >= 2024:
@@ -226,21 +226,21 @@ def _populate_optional_holidays(self):
226226
# General Holidays.
227227

228228
if self._is_sunday(JAN, 1):
229-
# The day following the first day of January.
229+
# The day following New Year's Day.
230230
self._add_new_years_day_two(tr("一月一日翌日"))
231231
else:
232-
# The first day of January.
232+
# New Year's Day.
233233
self._add_new_years_day(tr("一月一日"))
234234

235235
self._add_lunar_new_year(day_three_start_year=1968)
236236

237237
if self._year >= 1968:
238238
dt_qingming = self._qingming_date
239239
if self._is_sunday(dt_qingming) or dt_qingming == _timedelta(self._easter_sunday, +1):
240-
# The day following Ching Ming Festival.
240+
# The day following Tomb-Sweeping Day.
241241
self._add_holiday(tr("清明節翌日"), _timedelta(dt_qingming, +1))
242242
else:
243-
# Ching Ming Festival.
243+
# Tomb-Sweeping Day.
244244
self._add_qingming_festival(tr("清明節"))
245245

246246
# Good Friday.
@@ -259,10 +259,10 @@ def _populate_optional_holidays(self):
259259
if self._year >= 1999:
260260
dt_birthday_of_buddha = self._chinese_calendar.buddha_birthday_date(self._year)[0]
261261
if self._is_sunday(dt_birthday_of_buddha):
262-
# The day following the Birthday of the Buddha.
262+
# The day following the Buddha's Birthday.
263263
self._add_holiday(tr("佛誕翌日"), _timedelta(dt_birthday_of_buddha, +1))
264264
else:
265-
# The Birthday of the Buddha.
265+
# The Buddha's Birthday.
266266
self._add_chinese_birthday_of_buddha(tr("佛誕"))
267267

268268
if self._year >= 1999:
@@ -276,29 +276,29 @@ def _populate_optional_holidays(self):
276276
if self._year >= 1968:
277277
dt_dragon_boat = self._chinese_calendar.dragon_boat_date(self._year)[0]
278278
if self._is_sunday(dt_dragon_boat):
279-
# The day following Tuen Ng Festival.
279+
# The day following Dragon Boat Festival.
280280
self._add_holiday(tr("端午節翌日"), _timedelta(dt_dragon_boat, +1))
281281
else:
282-
# Tuen Ng Festival.
282+
# Dragon Boat Festival.
283283
self._add_dragon_boat_festival(tr("端午節"))
284284

285285
if self._year >= 1997:
286286
if self._is_sunday(JUL, 1):
287-
# The day following Hong Kong Special Administrative Region Establishment Day.
287+
# The day following Hong Kong S.A.R. Establishment Day.
288288
self._add_holiday_jul_2(tr("香港特別行政區成立紀念日翌日"))
289289
else:
290-
# Hong Kong Special Administrative Region Establishment Day.
290+
# Hong Kong S.A.R. Establishment Day.
291291
self._add_holiday_jul_1(tr("香港特別行政區成立紀念日"))
292292

293293
mid_autumn_date = self._add_mid_autumn()
294294

295295
if self._year >= 1968:
296296
dt_double_ninth = self._chinese_calendar.double_ninth_date(self._year)[0]
297297
if self._is_sunday(dt_double_ninth):
298-
# The day following Chung Yeung Festival.
298+
# The day following Double Ninth Festival.
299299
self._add_holiday(tr("重陽節翌日"), _timedelta(dt_double_ninth, +1))
300300
else:
301-
# Chung Yeung Festival.
301+
# Double Ninth Festival.
302302
self._add_double_ninth_festival(tr("重陽節"))
303303

304304
if self._year >= 1997:
@@ -400,11 +400,11 @@ class HongKongStaticHolidays:
400400
# Queen's Birthday.
401401
queen_birthday = tr("英女皇壽辰")
402402

403-
# The day following Hong Kong Special Administrative Region Establishment Day.
403+
# The day following Hong Kong S.A.R. Establishment Day.
404404
day_following_hksar_establishment_day = tr("香港特別行政區成立紀念日翌日")
405405

406-
# The 70th anniversary day of the victory of
407-
# the Chinese people's war of resistance against Japanese aggression.
406+
# 70th Anniversary of the Victory of the Chinese People's War of Resistance against
407+
# Japanese Aggression and the World Anti-Fascist War.
408408
victory_70th_anniversary = tr("中國人民抗日戰爭勝利70周年紀念日")
409409

410410
# Sino-Japanese War Victory Day.

‎holidays/locale/en_HK/LC_MESSAGES/HK.po‎

Lines changed: 26 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
#
1515
msgid ""
1616
msgstr ""
17-
"Project-Id-Version: Holidays 0.67\n"
17+
"Project-Id-Version: Holidays 0.69\n"
1818
"POT-Creation-Date: 2025-02-04 14:03+0700\n"
19-
"PO-Revision-Date: 2025-02-04 22:55+0700\n"
19+
"PO-Revision-Date: 2025-03-05 09:48+0700\n"
2020
"Last-Translator: PPsyrius <[email protected]>\n"
2121
"Language-Team: Holidays Localization Team\n"
2222
"Language: en_HK\n"
@@ -31,39 +31,39 @@ msgstr ""
3131
msgid "%s（慶祝）"
3232
msgstr "%s (observed)"
3333

34-
#. The day following the Chinese Mid-Autumn Festival.
34+
#. The Day following Mid-Autumn Festival.
3535
msgid "中秋節翌日"
3636
msgstr "The day following the Chinese Mid-Autumn Festival"
3737

38-
#. The second day following the Chinese Mid-Autumn Festival.
38+
#. The Second Day following Mid-Autumn Festival.
3939
msgid "中秋節後第二日"
4040
msgstr "The second day following the Chinese Mid-Autumn Festival"
4141

42-
#. Chinese Mid-Autumn Festival.
42+
#. Mid-Autumn Festival.
4343
msgid "中秋節"
4444
msgstr "Chinese Mid-Autumn Festival"
4545

46-
#. Lunar New Year's Day.
46+
#. Chinese New Year.
4747
msgid "農曆年初一"
4848
msgstr "Lunar New Year's Day"
4949

50-
#. The day preceding Lunar New Year's Day.
50+
#. Chinese New Year's Eve.
5151
msgid "農曆年初一的前一日"
5252
msgstr "The day preceding Lunar New Year's Day"
5353

54-
#. The second day of Lunar New Year.
54+
#. The second day of Chinese New Year.
5555
msgid "農曆年初二"
5656
msgstr "The second day of Lunar New Year"
5757

58-
#. The third day of Lunar New Year.
58+
#. The third day of Chinese New Year.
5959
msgid "農曆年初三"
6060
msgstr "The third day of Lunar New Year"
6161

62-
#. The fourth day of Lunar New Year.
62+
#. The fourth day of Chinese New Year.
6363
msgid "農曆年初四"
6464
msgstr "The fourth day of Lunar New Year"
6565

66-
#. The first day of January.
66+
#. New Year's Day.
6767
msgid "一月一日"
6868
msgstr "The first day of January"
6969

@@ -79,35 +79,35 @@ msgstr "The day following Good Friday"
7979
msgid "復活節星期一"
8080
msgstr "Easter Monday"
8181

82-
#. Ching Ming Festival.
82+
#. Tomb-Sweeping Day.
8383
msgid "清明節"
8484
msgstr "Ching Ming Festival"
8585

86-
#. The Birthday of the Buddha.
86+
#. The Buddha's Birthday.
8787
msgid "佛誕"
8888
msgstr "The Birthday of the Buddha"
8989

9090
#. Labor Day.
9191
msgid "勞動節"
9292
msgstr "Labour Day"
9393

94-
#. Tuen Ng Festival.
94+
#. Dragon Boat Festival.
9595
msgid "端午節"
9696
msgstr "Tuen Ng Festival"
9797

98-
#. Hong Kong Special Administrative Region Establishment Day.
98+
#. Hong Kong S.A.R. Establishment Day.
9999
msgid "香港特別行政區成立紀念日"
100100
msgstr "Hong Kong Special Administrative Region Establishment Day"
101101

102-
#. Chung Yeung Festival.
102+
#. Double Ninth Festival.
103103
msgid "重陽節"
104104
msgstr "Chung Yeung Festival"
105105

106106
#. National Day.
107107
msgid "國慶日"
108108
msgstr "National Day"
109109

110-
#. Chinese Winter Solstice Festival.
110+
#. Winter Solstice.
111111
msgid "冬節"
112112
msgstr "Chinese Winter Solstice Festival"
113113

@@ -119,37 +119,36 @@ msgstr "The first weekday after Christmas Day"
119119
msgid "聖誕節"
120120
msgstr "Christmas Day"
121121

122-
#. The day following the first day of January.
122+
#. The day following New Year's Day.
123123
msgid "一月一日翌日"
124124
msgstr "The day following the first day of January"
125125

126-
#. The day following Ching Ming Festival.
126+
#. The day following Tomb-Sweeping Day.
127127
msgid "清明節翌日"
128128
msgstr "The day following Ching Ming Festival"
129129

130130
#. The day following Easter Monday.
131131
msgid "復活節星期一翌日"
132132
msgstr "The day following Easter Monday"
133133

134-
#. The day following the Birthday of the Buddha.
134+
#. The day following the Buddha's Birthday.
135135
msgid "佛誕翌日"
136136
msgstr "The day following the Birthday of the Buddha"
137137

138138
#. The day following Labor Day.
139139
msgid "勞動節翌日"
140140
msgstr "The day following Labour Day"
141141

142-
#. The day following Tuen Ng Festival.
142+
#. The day following Dragon Boat Festival.
143143
msgid "端午節翌日"
144144
msgstr "The day following Tuen Ng Festival"
145145

146-
#. The day following Hong Kong Special Administrative Region Establishment
147-
#. Day.
146+
#. The day following Hong Kong S.A.R. Establishment Day.
148147
msgid "香港特別行政區成立紀念日翌日"
149148
msgstr ""
150149
"The day following Hong Kong Special Administrative Region Establishment Day"
151150

152-
#. The day following Chung Yeung Festival.
151+
#. The day following Double Ninth Festival.
153152
msgid "重陽節翌日"
154153
msgstr "The day following Chung Yeung Festival"
155154

@@ -189,9 +188,9 @@ msgstr "Wedding of Prince Charles and Diana"
189188
msgid "英女王伊利沙伯二世伉儷訪港的第二天"
190189
msgstr "Second day of Queen Elizabeth II and her husband's visit to Hong Kong"
191190

192-
#. The 70th anniversary day of the victory of the Chinese people's war of
193-
#. resistance against
194-
#. Japanese aggression.
191+
#. 70th Anniversary of the Victory of the Chinese People's War of Resistance
192+
#. against Japanese
193+
#. Aggression and the World Anti-Fascist War.
195194
msgid "中國人民抗日戰爭勝利70周年紀念日"
196195
msgstr ""
197196
"The 70th anniversary day of the victory of the Chinese people's war of "

0 commit comments

Comments
 (0)