Skip to content

feat: add support for Gradle configuration cache#21022

Merged
tepi merged 1 commit into
mainfrom
issues/18612-gradle_configuration_cache
Feb 27, 2025
Merged

feat: add support for Gradle configuration cache#21022
tepi merged 1 commit into
mainfrom
issues/18612-gradle_configuration_cache

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

Fixes #18612

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Test Results

1 169 files  ±0  1 169 suites  ±0   1h 36m 16s ⏱️ - 4m 7s
7 773 tests ±0  7 716 ✅ ±0  57 💤 ±0  0 ❌ ±0 
8 140 runs  +2  8 074 ✅ +2  66 💤 ±0  0 ❌ ±0 

Results for commit c6270e8. ± Comparison against base commit 0cefab5.

♻️ This comment has been updated with latest results.

@mcollovati
mcollovati marked this pull request as ready for review February 21, 2025 07:22
@mshabarov
mshabarov requested a review from tepi February 21, 2025 08:50
@mcollovati
mcollovati force-pushed the issues/18612-gradle_configuration_cache branch from c720a5d to c6270e8 Compare February 21, 2025 09:07
@mcollovati

mcollovati commented Feb 24, 2025

Copy link
Copy Markdown
Collaborator Author

@mshabarov
mshabarov requested review from mshabarov and removed request for mshabarov February 25, 2025 09:31
@tepi

tepi commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

Tested to build and work correctly for all build steps. Caching seems to work logically: normally cache entries are reused but when changing some configuration parameters or adding inputs/outputs, the cache is discarded and recreated.

During testing I ran into this issue, but the workaround solved the problem.

Looks good to me.

@tepi
tepi merged commit b72424a into main Feb 27, 2025
@tepi
tepi deleted the issues/18612-gradle_configuration_cache branch February 27, 2025 07:02
@tepi

tepi commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@mcollovati Please create PRs for Hilla and Platform as well when you have the time

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.alpha1 and is also targeting the upcoming stable 24.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot benefit from Gradle configuration cache due to cache problems

3 participants