Skip to content

fix: cache ClassFinder for reuse in mojo execution #20148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mshabarov merged 1 commit into from
Oct 7, 2024
Merged

fix: cache ClassFinder for reuse in mojo execution #20148

mshabarov merged 1 commit into from
Oct 7, 2024

Conversation

@mcollovati
Copy link
Collaborator

@mcollovati mcollovati commented Oct 4, 2024 •
edited
Loading

Creates ClassFinder once per mojo execution, preventing eccessive and useless scans.

Fixes #19874

@github-actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Test Results

1 116 files   - 24  1 116 suites   - 24   1h 6m 24s ⏱️ - 3m 2s
7 373 tests  - 49  7 325 ✅  - 47  48 💤  - 2  0 ❌ ±0 
7 716 runs   - 68  7 658 ✅  - 66  58 💤  - 2  0 ❌ ±0 

Results for commit a9d4e71. ± Comparison against base commit 179f04a.

This pull request removes 49 tests. 
com.vaadin.flow.navigate.ConnectionIndicatorIT(production) ‑ offline_goingOnline_customisedMessageShown[any_Chrome_]
com.vaadin.flow.navigate.ConnectionIndicatorIT(production) ‑ offline_serverConnectionAttempted_customisedMessageShown[any_Chrome_]
com.vaadin.flow.navigate.ConnectionIndicatorIT(production) ‑ offline_serverConnectionAttempted_javaCustomisedMessagesShown[any_Chrome_]
com.vaadin.flow.navigate.ConnectionIndicatorIT(production) ‑ online_goingOffline_customisedMessageShown[any_Chrome_]
com.vaadin.flow.navigate.NavigateBetweenViewsIT(production) ‑ navigateFromViewWithSpecialCharactersInRoute[any_Chrome_]
com.vaadin.flow.navigate.NavigateBetweenViewsIT(production) ‑ navigateToViewWithSpecialCharactersInRoute[any_Chrome_]
com.vaadin.flow.navigate.NavigateBetweenViewsIT(production) ‑ openFlowView_isConnectedOnAttach[any_Chrome_]
com.vaadin.flow.navigate.NavigateBetweenViewsIT(production) ‑ openFlowView_navigateToTsView_navigationSuccessful[any_Chrome_]
com.vaadin.flow.navigate.NavigateBetweenViewsIT(production) ‑ openTsView_navigateToFlowView_isConnectedOnAttach[any_Chrome_]
com.vaadin.flow.navigate.NavigateBetweenViewsIT(production) ‑ openTsView_navigateToFlow_navigationSuccessful[any_Chrome_]
…

♻️ This comment has been updated with latest results.

@mcollovati mcollovati force-pushed the fix/maven-classfinder-cache branch from 7c2b247 to e0a5984 Compare October 4, 2024 17:59
@mcollovati
fix: cache ClassFinder for reuse in mojo execution
a9d4e71 
Creates ClassFinder once per mojo execution, preventing eccessive and
useless scans.

Fixes #19874
@mcollovati mcollovati force-pushed the fix/maven-classfinder-cache branch from e0a5984 to a9d4e71 Compare October 4, 2024 18:15
@mcollovati mcollovati changed the title fix: cache ClassFinder for reuse in maven execution fix: cache ClassFinder for reuse in mojo execution Oct 4, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcollovati mcollovati marked this pull request as ready for review October 7, 2024 05:38
@mshabarov mshabarov merged commit 5824994 into main Oct 7, 2024
@mshabarov mshabarov deleted the fix/maven-classfinder-cache branch October 7, 2024 08:39
vaadin-bot pushed a commit that referenced this pull request Oct 7, 2024
@mcollovati @vaadin-bot
fix: cache ClassFinder for reuse in mojo execution (#20148)
3dd17de 
Creates ClassFinder once per mojo execution, preventing eccessive and
useless scans.

Fixes #19874
vaadin-bot added a commit that referenced this pull request Oct 7, 2024
@vaadin-bot @mcollovati
fix: cache ClassFinder for reuse in mojo execution (#20148) (#20155)
75328a1 
Creates ClassFinder once per mojo execution, preventing eccessive and
useless scans.

Fixes #19874

Co-authored-by: Marco Collovati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tepi tepi tepi approved these changes

Assignees

No one assigned

Labels

cherry-picked-24.5 target/24.5 +0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PiT 24.5: prepare-frontend and build-frontend seems to scan classes multiple times

5 participants

@mcollovati @tepi @vaadin-bot @mshabarov