Skip to content

Conversation

@Retrospection
Copy link

Performance and stability improvements on all platforms.

Cr-Commit-Position: refs/heads/4.10.24@{#1}
Cr-Branched-From: e53886f-refs/heads/master@{#33422}

Performance and stability improvements on all platforms.

Cr-Commit-Position: refs/heads/4.10.24@{#1}
Cr-Branched-From: e53886f-refs/heads/master@{#33422}
kisg pushed a commit to paul99/v8mips that referenced this pull request Feb 16, 2016
…d:140001 of https://codereview.chromium.org/1681283004/ )

Reason for revert:
[Sheriff] Still fails on android.

Original issue's description:
> reland [tools] add --pretty switch to run_perf.py
>
> This CL improves running our internal benchmarks locally by adding the
> --pretty option to tools/run_perf.py. With the flag enabled we print
> the run-time of each benchmark directly and avoid the json output at
> the end.
>
> NOTRY=true
>
> Committed: https://crrev.com/b543c40d78c3aa8283a7d9fccb6c9e26a9a81f90
> Cr-Commit-Position: refs/heads/master@{#34023}

[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1700953002

Cr-Commit-Position: refs/heads/master@{#34033}
zliang7 pushed a commit to minggangw/v8 that referenced this pull request Mar 21, 2016
Merged 50537ba

Unsampling for the sampling heap profiler

[email protected]
BUG=v8:4790
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1743833002

Cr-Commit-Position: refs/branch-heads/5.0@{v8#8}
Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1}
Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
kisg pushed a commit to paul99/v8mips that referenced this pull request Apr 8, 2016
…review.chromium.org/1869433004/ )

Reason for revert:
One small issue easily fixed here: https://codereview.chromium.org/1867333003/

But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful:
Stderr:
f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect
format specifier", 0)

It's easier to revert for now, I'll dig more into the docs:
https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx
https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx

And then resubmit, making sure I run these bots.

Original issue's description:
> Fix printf formats
>
> The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
>
>  - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
>  - Uses it appropriately.
>  - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
>  - Fixes a bunch of incorrect formats.
>
> R= [email protected], [email protected], [email protected], [email protected]
>
> Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
> Cr-Commit-Position: refs/heads/master@{#35365}

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1867383002

Cr-Commit-Position: refs/heads/master@{#35366}
kisg pushed a commit to paul99/v8mips that referenced this pull request Apr 15, 2016
… GC (patchset v8#8 id:140001 of https://codereview.chromium.org/1877233005/ )

Reason for revert:
[Sheriff] Speculative revert. Suspect for gc stress crashes, like:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5119

Original issue's description:
> Rehash and clear deleted entries in weak collections during GC
>
> Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
>
> BUG=v8:4909
> [email protected]
> LOG=n
>
> Committed: https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d
> Cr-Commit-Position: refs/heads/master@{#35514}

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4909

Review URL: https://codereview.chromium.org/1891863003

Cr-Commit-Position: refs/heads/master@{#35519}
kisg pushed a commit to paul99/v8mips that referenced this pull request Apr 20, 2016
…e AccessorInfo (patchset v8#8 id:140001 of https://codereview.chromium.org/1892533004/ )

Reason for revert:
Blocks roll: https://codereview.chromium.org/1896103002/

Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558

Original issue's description:
> Change calling convention of CallApiGetterStub to accept the AccessorInfo
>
> MIPS port contributed by Balazs Kilvady <[email protected]>
>
> Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f
> Cr-Commit-Position: refs/heads/master@{#35606}

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1906453002

Cr-Commit-Position: refs/heads/master@{#35644}
kisg pushed a commit to paul99/v8mips that referenced this pull request Apr 20, 2016
…e AccessorInfo (patchset #1 id:1 of https://codereview.chromium.org/1906453002/ )

Reason for revert:
Needs other reverts too.

Original issue's description:
> Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset v8#8 id:140001 of https://codereview.chromium.org/1892533004/ )
>
> Reason for revert:
> Blocks roll: https://codereview.chromium.org/1896103002/
>
> Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558
>
> Original issue's description:
> > Change calling convention of CallApiGetterStub to accept the AccessorInfo
> >
> > MIPS port contributed by Balazs Kilvady <[email protected]>
> >
> > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f
> > Cr-Commit-Position: refs/heads/master@{#35606}
>
> [email protected],[email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1903093003

Cr-Commit-Position: refs/heads/master@{#35645}
southerngs pushed a commit to southerngs/v8-git-mirror that referenced this pull request May 3, 2016
Merged 165186f

[heap] Fix Heap::EnsureFillerObjectAtTop for non-contiguous new space

BUG=chromium:581412,chromium:601014,chromium:601329
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1879583002 .

Cr-Commit-Position: refs/branch-heads/5.1@{v8#8}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jun 1, 2016
…ments objects support. (patchset v8#8 id:280001 of https://codereview.chromium.org/1995453002/ )

Reason for revert:
There are crashes on Win32 and Win64 bots.

Original issue's description:
> Extend HasProperty stub with dictionary-mode, string wrapper and double-elements objects support.
>
> This CL also replaces some Branch() usages with GotoIf/GotoUnless.
>
> BUG=v8:2743
> LOG=Y
>
> Committed: https://crrev.com/24066b6df4259b302edfa1db884c479008776a7e
> Cr-Commit-Position: refs/heads/master@{#36657}

[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:2743

Review-Url: https://codereview.chromium.org/2028333002
Cr-Commit-Position: refs/heads/master@{#36659}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jun 13, 2016
…to SyntaxError (patchset v8#8 id:140001 of https://codereview.chromium.org/2048703002/ )

Reason for revert:
This is going to break the LayoutTest inspector-protocol/console/console-let-const-with-api.html as seen in https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/2247 . Please run this test manually, using instructions at https://www.chromium.org/developers/testing/webkit-layout-tests , and fix on the Chrome side if needed before resubmitting this patch.

Original issue's description:
> change most cases of variable redeclaration from TypeError to SyntaxError.
>
> Code like `let a; eval("var a;");` should throw a SyntaxError, not a TypeError
> (this caused a test262 failure.). However, the code `eval("function NaN() {}");`
> should actually throw a TypeError. This patch changes most cases of
> redeclaration errors from TypeError to SyntaxError. See the test
> mjsunit/regress/redeclaration-error-types for a thorough analysis with spec
> references.
>
> The relevant sections of the spec are ES#sec-globaldeclarationinstantiation and
> ES#sec-evaldeclarationinstantiation
>
> BUG=v8:4955
> LOG=y
>
> Committed: https://crrev.com/2b787561763d0f7e8dab698652715a742cf78291
> Cr-Commit-Position: refs/heads/master@{#36940}

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4955

Review-Url: https://codereview.chromium.org/2064793002
Cr-Commit-Position: refs/heads/master@{#36941}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jun 30, 2016
…ToIndex. (patchset v8#8 id:140001 of https://codereview.chromium.org/2090353003/ )

Reason for revert:
Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/

Original issue's description:
> Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
>
> The spec was modified to relax some requirements which implementors had not been
> enforcing. Part of this process involved introducing a new abstract operation
> ToIndex, which had partial overlap with our existing semantics as well as some
> differences (most notably treating undefined as 0). Test262 tests were introduced to
> check for the new semantics, some of which we were failing. This patch amends the
> parts of our implementation corresponding to specification algorithms which use
> ToIndex to follow its semantics precisely.
>
> BUG=v8:4784,v8:5120
>
> Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
> Cr-Commit-Position: refs/heads/master@{#37406}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4784,v8:5120

Review-Url: https://codereview.chromium.org/2113593002
Cr-Commit-Position: refs/heads/master@{#37417}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jul 14, 2016
…hset v8#8 id:140001 of https://codereview.chromium.org/2135273002/ )

Reason for revert:
Breaks the roll, possibly win gn:
https://codereview.chromium.org/2148863002/

Original issue's description:
> [interpreter] Reduce dependencies in bytecodes.{h,cc}
>
> This CL reduces the number of dependencies bytecodes.{h,cc} to facilitate
> generating the bytecode peephole optimizer table during build. Specifically,
> it avoids depending on v8_base.
>
> BUG=v8:4280
> LOG=N
>
> Committed: https://crrev.com/4edebb1cd870ae6c1359ad54f83e618e185883b1
> Cr-Commit-Position: refs/heads/master@{#37715}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4280

Review-Url: https://codereview.chromium.org/2151693003
Cr-Commit-Position: refs/heads/master@{#37743}
kisg pushed a commit to paul99/v8mips that referenced this pull request Aug 3, 2016
v8#8 id:140001 of https://codereview.chromium.org/2187693002/ )

Reason for revert:
Mac64 ASAN failure. https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7810/steps/Check/logs/Threading4

Original issue's description:
> [Reland][Tracing] Embed V8 runtime call stats into tracing.
>
> Currently we have V8 RuntimeCallStats that is independently from tracing when
> running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call
> stats into tracing, by having a global table of runtime call counters each
> isolate, resetting the table each time we enter a top level trace event, and
> dumping the table for each top level trace event. This will make trace file more
> compat, as well as enable runtime call stats in tracing system.
>
> This patch adds ~5% overhead to V8 when the category is enabled, we measure the
> overhead by running a script when category is enabled.
>
> BUG=v8:5089
>
> Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa
> Committed: https://crrev.com/1ca3b73bba4a7253ca8eeef39321d70e7d414331
> Cr-Original-Commit-Position: refs/heads/master@{#38270}
> Cr-Commit-Position: refs/heads/master@{#38314}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5089

Review-Url: https://codereview.chromium.org/2200373003
Cr-Commit-Position: refs/heads/master@{#38315}
kisg pushed a commit to paul99/v8mips that referenced this pull request Aug 8, 2016
v8#8 id:140001 of https://codereview.chromium.org/2187693002/ )

Reason for revert:
Leaks block chromium roll:
https://codereview.chromium.org/2219083003/

Example build:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/205435

You can add the trybot from tryserver.chromium.linux, linux_chromium_asan_rel_ng, on reland.

Original issue's description:
> [Reland][Tracing] Embed V8 runtime call stats into tracing.
>
> Currently we have V8 RuntimeCallStats that is independently from tracing when
> running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call
> stats into tracing, by having a global table of runtime call counters each
> isolate, resetting the table each time we enter a top level trace event, and
> dumping the table for each top level trace event. This will make trace file more
> compat, as well as enable runtime call stats in tracing system.
>
> This patch adds ~5% overhead to V8 when the category is enabled, we measure the
> overhead by running a script when category is enabled.
>
> BUG=v8:5089
>
> Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa
> Committed: https://crrev.com/1ca3b73bba4a7253ca8eeef39321d70e7d414331
> Committed: https://crrev.com/3f936a5b17754783e92d2146eaf66c88a78ee45b
> Cr-Original-Original-Commit-Position: refs/heads/master@{#38270}
> Cr-Original-Commit-Position: refs/heads/master@{#38314}
> Cr-Commit-Position: refs/heads/master@{#38403}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5089
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2221853002
Cr-Commit-Position: refs/heads/master@{#38412}
kisg pushed a commit to paul99/v8mips that referenced this pull request Aug 17, 2016
…ToIndex. (patchset v8#2 id:170001 of https://codereview.chromium.org/2113593002/ )

Reason for revert:
WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests.

Original issue's description:
> Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset v8#8 id:140001 of https://codereview.chromium.org/2090353003/ )
>
> Reason for revert:
> Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/
>
> Original issue's description:
> > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
> >
> > The spec was modified to relax some requirements which implementors had not been
> > enforcing. Part of this process involved introducing a new abstract operation
> > ToIndex, which had partial overlap with our existing semantics as well as some
> > differences (most notably treating undefined as 0). Test262 tests were introduced to
> > check for the new semantics, some of which we were failing. This patch amends the
> > parts of our implementation corresponding to specification algorithms which use
> > ToIndex to follow its semantics precisely.
> >
> > BUG=v8:4784,v8:5120
> >
> > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
> > Cr-Commit-Position: refs/heads/master@{#37406}
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:4784,v8:5120
>
> Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f
> Cr-Commit-Position: refs/heads/master@{#37417}

[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4784,v8:5120

Review-Url: https://codereview.chromium.org/2247073004
Cr-Commit-Position: refs/heads/master@{#38689}
kisg pushed a commit to paul99/v8mips that referenced this pull request Sep 26, 2016
…0001 of https://codereview.chromium.org/2355793003/ )

Reason for revert:
Speculative revert because of stability problems

Original issue's description:
> [stubs] Port SubStringStub to TurboFan
>
> This ports the platform-specific SubStringStub to TurboFan.
>
> It also contains a minor bug-fix for the case when the requested substring
> length equals the subject string length, but the start index is not equal to 0.
> The old stub implementation returned the subject string, while the new
> implementation calls into runtime, which finally results in a thrown exception.
>
> BUG=v8:5415
>
> Committed: https://crrev.com/49be31921536716706a6790fbbf9c346b975af16
> Cr-Commit-Position: refs/heads/master@{#39653}

[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5415, chromium:649967
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2365413002
Cr-Commit-Position: refs/heads/master@{#39737}
targos referenced this pull request in nodejs/v8 Sep 30, 2016
Merged: Fix FastAccessorToSmi CCTest to use ptr type
Revision: abd32fb

Merged: Implement Big-Endian eqv test for DecodeDate and DecodeValueObjects
Revision: 54f5558

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected], [email protected], [email protected], [email protected]
BUG=

Review-Url: https://codereview.chromium.org/2284493002
Cr-Commit-Position: refs/branch-heads/5.4@{#8}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
targos referenced this pull request in nodejs/v8 Nov 5, 2016
Revision: edfe391

BUG=chromium:655004
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Review URL: https://codereview.chromium.org/2415183002 .

Cr-Commit-Position: refs/branch-heads/5.5@{#8}
Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1}
Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
kisg pushed a commit to paul99/v8mips that referenced this pull request Nov 16, 2016
… (patchset v8#8 id:140001 of https://codereview.chromium.org/2498073002/ )

Reason for revert:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared doesn't want to compile. Missing export annotation?

Original issue's description:
> [refactoring] Split CodeAssemblerState out of CodeAssembler
>
> This is in preparation for introducing more specialized
> CodeStubAssembler subclasses. The state object can be handed
> around, while the Assembler instances are temporary-scoped.
>
> BUG=v8:5628

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5628

Review-Url: https://codereview.chromium.org/2504913002
Cr-Commit-Position: refs/heads/master@{#41018}
cameni pushed a commit to Outerra/v8 that referenced this pull request Nov 30, 2016
Cr-Commit-Position: refs/branch-heads/5.6@{v8#8}
Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1}
Cr-Branched-From: 879f659-refs/heads/master@{#41014}
kisg pushed a commit to paul99/v8mips that referenced this pull request Dec 8, 2016
…8#8 id:140001 of https://codereview.chromium.org/2549753002/ )

Reason for revert:
Speculative revert WebGL breakage reported in https://bugs.chromium.org/p/chromium/issues/detail?id=672367

Original issue's description:
> Store OSR'd optimized code on the native context.
>
> Since we OSR code rarely, it makes sense to store it and look for it on the native context rather than the SharedFunctionInfo. This makes the OptimizedCodeMap data structure more space efficient, as it doesn't have to store an ast ID for the OSR entry point.
>
> BUG=
>
> Committed: https://crrev.com/378b6b22fb7925ac5b672335a54599f5739e7758
> Cr-Commit-Position: refs/heads/master@{#41554}

[email protected], [email protected], [email protected]
BUG=

Review-Url: https://codereview.chromium.org/2562623003
Cr-Commit-Position: refs/heads/master@{#41571}
kisg pushed a commit to paul99/v8mips that referenced this pull request Dec 23, 2016
…rappers" (patchset v8#8 id:140001 of https://codereview.chromium.org/2591383004/ )

Reason for revert:
Breaks webkit-unit-tests. Investigating..

Original issue's description:
> Reland "[heap] Ensure progress when incrementally marking wrappers"
>
> 1) Alternate between processing v8 and wrappers
> 2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers
> 3) After that, finalize once v8 marking deque is empty again
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2591383004
> Cr-Commit-Position: refs/heads/master@{#41932}
> Committed: https://chromium.googlesource.com/v8/v8/+/61a55548c50e01d84ed4aefa396324cbb4039b51

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2592393003
Cr-Commit-Position: refs/heads/master@{#41936}
hubot pushed a commit that referenced this pull request Jan 19, 2017
…ecode. (patchset #1 id:1 of https://codereview.chromium.org/2641153002/ )

Reason for revert:
does not build

Original issue's description:
> Merged: Revert of [Ignition/turbo] Add a CallWithSpread bytecode.
>
> Merge of 75b8612
>
> Reason for revert:
> Causes a few bugs caught by clusterfuzz.
>
> Original issue's description:
> > [Ignition/turbo] Add a CallWithSpread bytecode.
> >
> > Also, emit a NewWithSpread bytecode for CallNew AST nodes where possible, rather than desugaring in the parser.
> >
> > BUG=v8:5511
> >
> > Review-Url: https://codereview.chromium.org/2629363002
> > Cr-Commit-Position: refs/heads/master@{#42455}
> > Committed: https://chromium.googlesource.com/v8/v8/+/4bae43471d5685e34d8bd74458889b83e60235a0
>
> [email protected],[email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:5511
>
> Review-Url: https://codereview.chromium.org/2642843002
> Cr-Original-Commit-Position: refs/heads/master@{#42470}
> Review-Url: https://codereview.chromium.org/2641153002
> Cr-Commit-Position: refs/branch-heads/5.7@{#7}
> Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1}
> Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
> Committed: https://chromium.googlesource.com/v8/v8/+/2c1b5efe74c74d2d8a31ace078399ef41c0f0786

[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5511

Review-Url: https://codereview.chromium.org/2647673002
Cr-Commit-Position: refs/branch-heads/5.7@{#8}
Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1}
Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
hubot pushed a commit that referenced this pull request Feb 27, 2017
…ator (patchset #8 id:140001 of https://codereview.chromium.org/2711473002/ )

Reason for revert:
The tree is closed due to an msan violation (use of uninitialized value) in the arm64 simulator soon after this patch landed; this seems related

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/13607/steps/Check/logs/simulator_invalidate_..

Original issue's description:
> [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator
>
> BUG=v8:4614
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2711473002
> Cr-Commit-Position: refs/heads/master@{#43461}
> Committed: https://chromium.googlesource.com/v8/v8/+/a2a2c1b9eeccd86e77f2c7e6eda3e1b09bb5306c

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4614

Review-Url: https://codereview.chromium.org/2720133003
Cr-Commit-Position: refs/heads/master@{#43463}
hubot pushed a commit that referenced this pull request Mar 2, 2017
Cr-Commit-Position: refs/branch-heads/5.8@{#8}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
kisg pushed a commit to paul99/v8mips that referenced this pull request Apr 5, 2017
v8#8 id:160001 of https://codereview.chromium.org/2760233005/ )

Reason for revert:
I think that this CL breaks chromium compilation on windows with clang (). All other CLs in the list looks trivial and don't change test/unittest/BUILD.gn.

[42456/47924] CXX obj/v8/test/unittests/unittests/value-serializer-unittest.obj
[42457/47924] LINK unittests.exe unittests.exe.pdb
FAILED: unittests.exe unittests.exe.pdb
E:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./unittests.exe /PDB:./unittests.exe.pdb @./unittests.exe.rsp
bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::Add(class v8::internal::AllocationObserver * const &,class v8::internal::FreeStoreAllocationPolicy)" (?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@z) referenced in function "public: virtual void __cdecl v8::internal::Space::AddAllocationObserver(class v8::internal::AllocationObserver *)" (?AddAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::Add(class v8::internal::AllocationObserver * const &,class v8::internal::FreeStoreAllocationPolicy)" (?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@z)

bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: bool __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class v8::internal::AllocationObserver * const &)" (?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@z) referenced in function "public: virtual void __cdecl v8::internal::Space::RemoveAllocationObserver(class v8::internal::AllocationObserver *)" (?RemoveAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: bool __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class v8::internal::AllocationObserver * const &)" (?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@z)

./unittests.exe : fatal error LNK1120: 2 unresolved externals

Original issue's description:
> [snapshot] Move builtins generation into mksnapshot
>
> and out of the main library. This saves about 5% of binary size
> (800KB on x64, 373KB on android_arm).
>
> Only the GN build is supported; the GYP build is maintained working
> but does not support the feature.
>
> BUG=v8:6055
> CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
>
> Review-Url: https://codereview.chromium.org/2760233005
> Cr-Commit-Position: refs/heads/master@{#44412}
> Committed: https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a0e966

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6055

Review-Url: https://codereview.chromium.org/2803903002
Cr-Commit-Position: refs/heads/master@{#44422}
hubot pushed a commit that referenced this pull request Apr 13, 2017
Cr-Commit-Position: refs/branch-heads/5.9@{#8}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
kisg pushed a commit to paul99/v8mips that referenced this pull request Apr 21, 2017
…v8#8 id:140001 of https://codereview.chromium.org/2752143003/ )

Reason for revert:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20-%20builder/builds/9118

Original issue's description:
> [regexp] Remove remainder of native RegExpExecStub
>
> If we avoid throwing a stack overflow exception from Irregexp code during
> direct calls, there is no need to construct exit frames before the Irregexp
> call anymore. As that was the last remaining blocker, we can now implement the
> entire stub in CSA.
>
> BUG=v8:5339
>
> Review-Url: https://codereview.chromium.org/2752143003
> Cr-Commit-Position: refs/heads/master@{#44770}
> Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5339

Review-Url: https://codereview.chromium.org/2833083002
Cr-Commit-Position: refs/heads/master@{#44771}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Aug 27, 2023
Merged: [runtime] Recreate enum cache on map update
Revision: 1c623f9

Merged: [runtime] Don't try to create empty enum cache.
Revision: 5516e06

BUG=chromium:1470668,chromium:1472317
[email protected]

Change-Id: I9cd54930946c55df0d960899b4a41310a7455378
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4789108
Reviewed-by: Tobias Tebbi <[email protected]>
Commit-Queue: Samuel Groß <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.7@{v8#8}
Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 3, 2023
Merged: [runtime] Recreate enum cache on map update
Revision: 1c623f9

Merged: [runtime] Don't try to create empty enum cache.
Revision: 5516e06

BUG=chromium:1470668,chromium:1472317
[email protected]

(cherry picked from commit 173806c)

Change-Id: I9cd54930946c55df0d960899b4a41310a7455378
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4789108
Commit-Queue: Samuel Groß <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/11.7@{v8#8}
Cr-Original-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Original-Branched-From: aeb4552-refs/heads/main@{#89415}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4822573
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#82}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 3, 2023
This reverts commit 0c9fe97.

Reason for revert: Broke build

Original change's description:
> [M108-LTS] Merged: Squashed multiple commits.
>
> Merged: [runtime] Recreate enum cache on map update
> Revision: 1c623f9
>
> Merged: [runtime] Don't try to create empty enum cache.
> Revision: 5516e06
>
> BUG=chromium:1470668,chromium:1472317
> [email protected]
>
> (cherry picked from commit 173806c)
>
> Change-Id: I9cd54930946c55df0d960899b4a41310a7455378
> No-Try: true
> No-Presubmit: true
> No-Tree-Checks: true
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4789108
> Commit-Queue: Samuel Groß <[email protected]>
> Cr-Original-Commit-Position: refs/branch-heads/11.7@{v8#8}
> Cr-Original-Branched-From: fe60869-refs/heads/11.7.439@{#1}
> Cr-Original-Branched-From: aeb4552-refs/heads/main@{#89415}
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4822573
> Reviewed-by: Leszek Swirski <[email protected]>
> Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
> Cr-Commit-Position: refs/branch-heads/10.8@{v8#82}
> Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
> Cr-Branched-From: 237de89-refs/heads/main@{#83672}

BUG=chromium:1470668,chromium:1472317

Change-Id: Ib610be37d1231a61aaa1902517bed78a89f77fa9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4833765
Reviewed-by: Leszek Swirski <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Leszek Swirski <[email protected]>
Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#84}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 15, 2023
Fixed: chromium:1480765
(cherry picked from commit cb9bfb5)

Change-Id: Ifc69c612ee5a851ee46d403ef827cc2ff045093a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4866326
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Matthias Liedtke <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.8@{v8#8}
Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1}
Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Nov 19, 2023
…int32 opcode

Revision: ef567ad

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Bug: v8:14447
Change-Id: I7646c0a3663f573cadb355a4f1e06e6910b41458
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5029175
Reviewed-by: Lutz Vahl <[email protected]>
Commit-Queue: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.0@{v8#8}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Dec 10, 2023
Due to the reachability in the decoder influencing the  assignment of
feedback slots, it is required to handle reachability consistently
between liftoff and the optimizing compiler.

This wasn't the case for CatchException, CatchCase and CatchAll.

Bug: chromium:1508213
(cherry picked from commit def7931)

Change-Id: I851d34236e266c8442722313ebf35332d6d2d100
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5099464
Auto-Submit: Matthias Liedtke <[email protected]>
Reviewed-by: Manos Koukoutos <[email protected]>
Commit-Queue: Manos Koukoutos <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#8}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Feb 27, 2024
The entry index in the WasmApiFunctionRef was used to look for the given
WasmApiFunctionRef in the indirect function tables, but it was not
considered that the indirect function tables can have different lengths.

[email protected]

Bug: 325893559
(cherry picked from commit 7330f46)

Change-Id: I160dce22dc468b8dc87dd71c7c24873523e3ca9c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5324391
Commit-Queue: Andreas Haas <[email protected]>
Reviewed-by: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.3@{#8}
Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1}
Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot pushed a commit that referenced this pull request Mar 22, 2024
(cherry picked from commit b852ad7)

Bug: chromium:330575498
Change-Id: I395f0ed6d823b7d1e139da6551486e3627d65724
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5378419
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Auto-Submit: Manos Koukoutos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#92941}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5385871
Cr-Commit-Position: refs/branch-heads/12.4@{#8}
Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1}
Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
probablytom pushed a commit to probablytom/v8 that referenced this pull request Apr 11, 2024
This fixes an issue in crrev.com/5180736 where an atomic memory
access with a statically known index and incorrect alignment
does not trap even though it should.

Bug: chromium:1520780
(cherry picked from commit 499a564)

Change-Id: I9f27c86a17bcffbbf9bf294e10be9e8f3098965f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5237473
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.2@{v8#8}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request Apr 25, 2024
Bug: 336961698
Change-Id: Ieb14876f5ea82dde55308c378b4ae40ec7df8c28
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5487857
Commit-Queue: Alexander Schulze <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.5@{#8}
Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1}
Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot pushed a commit that referenced this pull request May 21, 2024
In this case the ref is not the instance but a WasmApiFunctionRef, so
the cast is invalid. Use the instance field instead.

[email protected]

Bug: 340102752

(cherry picked from commit 52d9e6d)

Change-Id: I7cef578c504d6b4998b92d0a32ef4e49568d57bd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5553796
Auto-Submit: Thibaud Michaud <[email protected]>
Reviewed-by: Deepti Gandluri <[email protected]>
Commit-Queue: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.6@{#8}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Jun 14, 2024
Needs some more time to iron out issues.

Bug: 346835902
Bug: 346386746
(cherry picked from commit 6e8923c)

Change-Id: I7950b628dfe547115adf611bb53196874fbba518
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5633594
Reviewed-by: Olivier Flückiger <[email protected]>
Commit-Queue: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.7@{#8}
Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1}
Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot pushed a commit that referenced this pull request Aug 2, 2024
…ns in ISel

Bug: chromium:353628445, chromium:354626177, chromium:351926098
(cherry picked from commit ce29fae)

Change-Id: I7d9132d5df484ce158cb876a40893be4caf9fda0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5756845
Reviewed-by: Darius Mercadier <[email protected]>
Commit-Queue: Darius Mercadier <[email protected]>
Auto-Submit: Nico Hartmann <[email protected]>
Commit-Queue: Nico Hartmann <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.8@{#8}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Aug 26, 2024
This reverts part of 2b43121,
because there are still some ValueType uses of canonicalized
type indices left. So for now we allow a maximum of 1'000'000
canonicalized types.

Fixed: 360533914
(cherry picked from commit 79f3f12)

Change-Id: I25f7d0e633856c1090753b96c14616d269722e2c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5812964
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Commit-Queue: Matthias Liedtke <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.9@{#8}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
CuiLam pushed a commit to CuiLam/v8 that referenced this pull request Sep 4, 2024
…oto"

This reverts commit 9b5b6ee.

Reason for revert: crbug:1492212

Original change's description:
> [maps] Create map transitions for derived maps with custom proto
>
> Prevents us from creating excessive maps in the case of e.g.,
> Reflect.construct with a newTarget.
>
> Measured impact on top 10k websites is an average of 1% reduction in
> map allocations.
>
> Bug: v8:13978
> Change-Id: I324389f0febfa47a3a179ccdb30029723278ba5e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4750265
> Commit-Queue: Olivier Flückiger <[email protected]>
> Reviewed-by: Camillo Bruni <[email protected]>
> Auto-Submit: Olivier Flückiger <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#89520}

(cherry picked from commit 96adcd5)

Bug: v8:13978
Change-Id: I833f6d167e6afe2fe7a6dd4019c83032644d0069
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4942590
Auto-Submit: Olivier Flückiger <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#90427}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4951922
Owners-Override: Lutz Vahl <[email protected]>
Auto-Submit: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.9@{v8#8}
Cr-Branched-From: 3eb7d73-refs/heads/11.9.169@{#1}
Cr-Branched-From: 1a13bf9-refs/heads/main@{#90218}
hubot pushed a commit that referenced this pull request Sep 20, 2024
Otherwise we'll try to rewrite a FailureExpression

Bug: 366323452
(cherry picked from commit 3b1adc1)

Change-Id: Ie707023b2c2ba2ad0273ef7b22bd2ef2a6d2ea32
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5875692
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.0@{#8}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Oct 24, 2024
need to use a 4 byte bias when dealing with 4 byte values
on the stack.

(cherry picked from commit a108331)

Change-Id: Ibd94275f264849fcc8657a65686a368241206bc9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5954405
Reviewed-by: Matthias Liedtke <[email protected]>
Auto-Submit: Milad Farazmand <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.1@{#8}
Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1}
Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot pushed a commit that referenced this pull request Nov 15, 2024
See discussion in https://crrev.com/c/6011089 for context.

(cherry picked from commit a497308)

Bug: 335082212, 377744184
Fixed: 378584789
Change-Id: I6b1c935d55a208e96695c1ecb28b8d0a8df4907b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6022910
Commit-Queue: Eva Herencsárová <[email protected]>
Auto-Submit: Matthias Liedtke <[email protected]>
Reviewed-by: Eva Herencsárová <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.2@{#8}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Jan 10, 2025
Trap handling makes unsound assumptions; disable it altogether for now.
This needs to be fixed, or removed entirely if we don't find a fix.

Plus two minor drive-by changes.

[email protected]

(cherry picked from commit 7b598f3)

Bug: 388290793
Change-Id: Ia08f290b123ec26d187a2ccc238f5e1ae1e33005
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6163458
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.3@{#8}
Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1}
Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot pushed a commit that referenced this pull request Feb 7, 2025
Bug: 386857213
(cherry picked from commit 0242cac)

Change-Id: I0aee184b2ea8caab67eb11c5a249e910ac340418
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6243715
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Deepti Gandluri <[email protected]>
Commit-Queue: Deepti Gandluri <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.4@{#8}
Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1}
Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot pushed a commit that referenced this pull request Mar 11, 2025
The unified schedule landed in https://crrev.com/c/6281665.

The CL added a switch for the schedule but didn't adjust the initial
scheduled bytes computation as well as the bailouts properly:
- Fix GetScheduledBytes() which now ignores CppHeap bytes when the
  mode is off.
- Fix the actual step to ignore CppHeap marked bytes when the mode is
  off.

Bug: 391118563, 399711138
Fixed: 400943823
(cherry picked from commit 226b159)

Change-Id: I28a5aa62f2a71114b4d023fd169102c80b0b710d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6343293
Reviewed-by: Dominik Inführ <[email protected]>
Auto-Submit: Michael Lippautz <[email protected]>
Commit-Queue: Michael Lippautz <[email protected]>
Commit-Queue: Dominik Inführ <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.5@{#8}
Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1}
Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
hubot pushed a commit that referenced this pull request Apr 10, 2025
…able

... instead of hitting UNREACHABLE.

Bug: 401059828
Bug: 408795741
Fixed: 409008488
(cherry picked from commit 2c219a1)

Change-Id: If208c6300c0b9f57208ce8f965f2b8dc46bf482d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6441173
Commit-Queue: Toon Verwaest <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Auto-Submit: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.6@{#8}
Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1}
Cr-Branched-From: f6be482-refs/heads/main@{#99571}
hubot pushed a commit that referenced this pull request May 6, 2025
Bug: 414516598
(cherry picked from commit a6f67c2)

Change-Id: Ic3038fcd29180e3add9793e5b3c90a683c6c55df
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6512953
Auto-Submit: Michael Achenbach <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.7@{#8}
Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1}
Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot pushed a commit that referenced this pull request May 29, 2025
Bug: 420636529
(cherry picked from commit 7bc0a67)

Change-Id: I8a020e9343d30e846542b63f56f7f6268995f878
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6599189
Auto-Submit: Shu-yu Guo <[email protected]>
Reviewed-by: Deepti Gandluri <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.8@{#8}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Jul 2, 2025
Since fast api calls can now also call back to JS there can be
multiple active fast c calls at the same time. This means just
checking Isolate::InFastCCall() is not enough anymore because this
only returns the state of the last CEntry frame.

This CL therefore disables code space compaction when a stack is
present to allow for multiple/nested fast C calls. Alternatively
we could also just e.g. pin code objects referenced from the stack but
this would require a bit more work.

Bug: 424905890
(cherry picked from commit d4dbd1d)

Change-Id: Id504b09ec4d9b1238755e94cca339031cb1cadaa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6701707
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Auto-Submit: Dominik Inführ <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.9@{#8}
Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1}
Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot pushed a commit that referenced this pull request Sep 12, 2025
When copying from one TypedArray to another, read off the elements kind
only once, and calculate type and element size from that one read. Also,
only ever use the length that was passed in, to avoid multiple reads of
the length -- calculate the byte length locally from the given length,
rather than by re-reading the length.

Additionally, clean up handling of the destination type -- this should
already be handled by the templating of the helper class being used, so
we can define the destination type and size as constexpr (and just
DCHECK that it matches the input).

Finaly drive-by, remove the element type parameter from the helper
classes, and infer it from the ElementsKind, so that it's known to
always be consistent.

Fixed: 436140742
(cherry picked from commit 0197c35)

Change-Id: I9ae4fa26b1c74f11bbd0de75ff8500363646cb13
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6943136
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Michael Lippautz <[email protected]>
Auto-Submit: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.0@{#8}
Cr-Branched-From: 4ec2f43-refs/heads/14.0.365@{#1}
Cr-Branched-From: a88b570-refs/heads/main@{#101731}
hubot pushed a commit that referenced this pull request Sep 16, 2025
… are 0

Because Arm64 doesn't have a flag-setting 32-bit multiplication,
which means that instead with use a 64-bit multiplication, and compare
result.X() and result.W() to check if an overflow happened. But this
leads to the upper 32-bit not being zeroed.

Fixed: 445380761
(cherry picked from commit ec6c184)

Change-Id: I73f602fc82b59f35b4684cffb07923d7c5a9a947
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6955269
Reviewed-by: Darius Mercadier <[email protected]>
Commit-Queue: Darius Mercadier <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.1@{#8}
Cr-Branched-From: 1f4839b-refs/heads/14.1.146@{#1}
Cr-Branched-From: cd6944c-refs/heads/main@{#102149}
hubot pushed a commit that referenced this pull request Oct 8, 2025
Original change's description:
> [GC] Force last resort GC when ineffective GCs are detected
> 
> Following up on https://chromium-review.googlesource.com/c/v8/v8/+/6298054
> Experiment results show a regression in "ineffective GC" OOMs.
> go/v8-bytecode-flushing-vs-crashes-android-aug25
> 
> This CL adds a flag to force GCs to be "last resort" during
> allocation retry loops, and thus flush code cache when there's at least 1 detected ineffective GC (near heap limit).
> 
> Change-Id: I65b7d8ad314c2978492742b673468cb8a9c6fbb7
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6966829
> Reviewed-by: Dominik Inführ <[email protected]>
> Commit-Queue: Etienne Pierre-Doray <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#102879}

(cherry picked from commit 2e60a86)

Bug: 450245787
Change-Id: I65b7d8ad314c2978492742b673468cb8a9c6fbb7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7023049
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.2@{#8}
Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1}
Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot pushed a commit that referenced this pull request Nov 4, 2025
…des_global

Original change's description:
> [heap] Guard "global" ineffective GC with ineffective_gc_includes_global
> 
> In IsIneffectiveMarkCompact, I'd previously include global size behind
> external_memory_accounted_in_global_limit flag.
> This was because the external memory was commonly over the limit.
> This was done to prevent looping GCs (and eventually hit ineffective GC
> OOM)
> 
> Since then, I fixed the culprit in https://chromium-review.googlesource.com/c/chromium/src/+/6950799
> 
> It's not clear anymore that this is needed,
> or even beneficial so I'd like to keep a separate flag so I can isolate
> the effect.
> 
> Bug: chromium:361124432
> Change-Id: Icf4ec6bcf215aff66fef6b0cabe9fcdfa5e58441
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7081571
> Reviewed-by: Michael Lippautz <[email protected]>
> Commit-Queue: Etienne Pierre-Doray <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#103361}

(cherry picked from commit 394a954)

Bug: 457684685,chromium:361124432
Change-Id: Icf4ec6bcf215aff66fef6b0cabe9fcdfa5e58441
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7118700
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.3@{#8}
Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1}
Cr-Branched-From: 01af089-refs/heads/main@{#103352}
hubot pushed a commit that referenced this pull request Dec 4, 2025
Fixed: 464965404

(cherry picked from commit cb111a4)

Change-Id: I2f80e9e3f79ac1af831111c31d26b3b54c04bb5f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7224110
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Auto-Submit: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.4@{#8}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant