Version 8.5.133 #42

zyadomer999 · 2020-06-08T21:06:57Z

Hello
I want to let you know that I have recently developed a function similar to Document.execCommand() with the latest javascript. As you might know, the mentioned function is obsolete and is subject to stop functioning on browsers, however, there is no alternative to it. Now I want to know if it is possible to implement the function I made into javascript source so that everyone can use it and do not waste their time on making it again.

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0d2b4571f655493bda2d915f374f59e092c85037 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235652 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/8.5.133@{#1} Cr-Branched-From: 3f064b5-refs/heads/master@{#68224}

googlebot · 2020-06-08T21:07:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jakobkummerow · 2020-06-08T21:10:18Z

V8 is not the right place for Document.execCommand or any similar functions.

The actual changes in this PR look like spam.

zyadomer999 · 2020-06-08T21:13:23Z

But I think everyone needs this function, I want to implement it into javascript as built in functions, can you help me please?

Resolve "ERROR: mfhc1 generated" Closes #42 See merge request swlab/swe/v8!60

Create CONTRIBUTING file

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ic52db5f33273158d14e81ab4d57384145c9764a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899249 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.8@{v8#42} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ifa48de3046f50ddb2b6d2426d68ad1f234fdcfdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906230 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#42} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}

Revision: 6516b1c BUG=chromium:1051017 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I0d4ea7d49f8ffc81c9b7d109df6ceccc9e159c6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056855 Reviewed-by: Georg Neis <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/branch-heads/8.0@{v8#42} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}

This is a reland of f23f644 Fix the issue by wrap v8_executable("gen-regexp-special-case") inside if (current_toolchain == v8_generator_toolchain) { and change deps of action("run_gen-regexp-special-case") to ":gen-regexp-special-case($v8_generator_toolchain)", Original change's description: > Speed up CharacterRange::AddCaseEquivalents > > By using the lexCss("color:") to measure the performance > The change make the lexCss("color:") > x21 - x40 times faster than trunk. > x2.3 - x4.6 times faster than m74. > > Design Doc: http://shorturl.at/adfO5 > > Measured by out/x64.release/d8 reg977003.js > see reg977003.js attached to chromium:977003 > > Also see another cl of benchmark in > https://chromium-review.googlesource.com/c/v8/v8/+/1679651/ > > > Bug: chromium:977003 > Change-Id: Ie8518493d2c33df1594be1b4576bda715087b421 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674851 > Commit-Queue: Frank Tang <[email protected]> > Reviewed-by: Yang Guo <[email protected]> > Cr-Commit-Position: refs/heads/master@{#62471} [email protected] (cherry picked from commit 433403d) Bug: chromium:977003 Change-Id: Ib11000703a43632292e89579e609ecc0b8ae913d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683706 Reviewed-by: Frank Tang <[email protected]> Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#62486} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1693830 Cr-Commit-Position: refs/branch-heads/7.6@{v8#42} Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1} Cr-Branched-From: 201c509-refs/heads/master@{#61902}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I8303d964c541bfa5b0bbbc392f64e4ed39f2ce9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080332 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.1@{v8#42} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}

…ool. Revision: d469c73 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:10826 Change-Id: Ifcc532ee4195b188f4d5302d9ecdc4f23c28c563 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2374307 Reviewed-by: Georg Neis <[email protected]> Reviewed-by: Michael Hablich <[email protected]> Commit-Queue: Michael Hablich <[email protected]> Cr-Commit-Position: refs/branch-heads/8.5@{v8#42} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}

…t closures (cherry picked from commit 26df3fd) NOTRY=true Bug: chromium:1105318 Change-Id: I7b1c57b7ff7beaaa53c19a270d5a8c36b11baf17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301082 Reviewed-by: Sathya Gunasekaran <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#68903} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307178 Cr-Commit-Position: refs/branch-heads/8.4@{v8#42} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I667e1037de1f44e27322b99784bc80863db30aa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871395 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.1@{v8#42} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iaafe4e144c1699b9dba2365fbab942775e53ef32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038322 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.2@{v8#42} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I9b6ee1c91ed67d78a1cf12aa84051cfdf9eadfd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719824 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.9@{v8#42} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}

Bug: v8:12276 Change-Id: Id64e274151011edeaf092cba5bc5487118b3339a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205891 Reviewed-by: Michael Achenbach <[email protected]> Owners-Override: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/branch-heads/9.4@{v8#42} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}

Consider in-construction keys as live during the final GC pause. (cherry picked from commit 32a09a6) Bug: chromium:1259587 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ib1c490dcbc1d7e5a5b38947109fe0e8f7fe52002 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234198 Reviewed-by: Dominik Inführ <[email protected]> Commit-Queue: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/branch-heads/9.5@{v8#42} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}

Preparing for tail call is usually done by emitting the gap moves and then moving the stack pointer to its new position. An optimization consists in moving the stack pointer first and transforming some of the moves into pushes. In the attached case it looks like this (arm): 138 add sp, sp, v8#40 13c str r6, [sp, #-4]! 140 str r6, [sp, #-4]! 144 str r6, [sp, #-4]! 148 str r6, [sp, #-4]! 14c str r6, [sp, #-4]! ... 160 vldr d1, [sp - 4*3] The last line is a gap reload, but because the stack pointer was already moved, the slot is now below the stack pointer. This is invalid and triggers this DCHECK: Fatal error in ../../v8/src/codegen/arm/assembler-arm.cc, line 402 Debug check failed: 0 <= offset (0 vs. -12). A comment already explains that we skip the optimization if the gap contains stack moves to prevent this, but the code only checks for non-FP slots. This is fixed by replacing "source.IsStackSlot()" with "source.IsAnyStackSlot()": 108 vldr d1, [sp + 4*2] ... 118 str r0, [sp, #+36] 11c str r0, [sp, #+32] 120 str r0, [sp, #+28] 124 str r0, [sp, #+24] 128 str r0, [sp, #+20] ... 134 add sp, sp, v8#20 TBR=[email protected] (cherry picked from commit 7506e06) Change-Id: I66ed6187755af956e245207e940c83ea0697a5e6 Bug: chromium:1137608 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505976 Reviewed-by: Thibaud Michaud <[email protected]> Commit-Queue: Thibaud Michaud <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{v8#42} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}

To make sure that Wasm memories don't exceed JSArrayBuffer size. This change shouldn't affect real-world modules, because finding enough contiguous address space to allocate that much memory is virtually impossible anyway. (cherry picked from commit 6d7ed2e) Fixed: chromium:1242339 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I6dfae2fbf7a5c4c038c2d32bfeb1c1420b5559b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338698 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Thibaud Michaud <[email protected]> Cr-Commit-Position: refs/branch-heads/9.6@{v8#42} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Icb55f4e85b9d4e507cf47051c1f4e130e581826a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2840685 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.0@{v8#42} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}

Previously, StoreOwnIC incorrectly reuses the [[Set]] semantics when initializing public literal class fields and object literals in certain cases (e.g. when there's no feedback). This was less of an issue for object literals, but with public class fields it's possible to define property attributes while the instance is still being initialized, or to encounter existing static "name" or "length" properties that should be readonly. This patch fixes it by 1) Emitting code that calls into the slow stub when handling StoreOwnIC with existing read-only properties. 2) Adding extra steps in StoreIC::Store to handle such stores properly with [[DefineOwnProperty]] semantics. Bug: v8:12421, v8:9888 (cherry picked from commit 80bbbb1) Change-Id: I6547320a1caba58c66ee1043cd3183a2de7cefef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402435 Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Lutz Vahl <[email protected]> Cr-Commit-Position: refs/branch-heads/9.7@{v8#42} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I967477cb400b3b5f39551c7c3bfec96da738fa38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528469 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.7@{v8#42} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}

Change-Id: Ic3279d60d91f4530554c4da2f2d94ffd876e54a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4081594 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#42} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}

Change-Id: Ie512c4f00062c05bb2a81db545ed343167fe29f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4490644 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.2@{v8#42} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}

Change-Id: I6cd921d684fb8c8800c9cd54c3bd6b77c1713096 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3954984 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.6@{v8#42} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}

This simplifies some call sites as they do not need to worry about stores to external pointer fields (especially lazily initialized ones) triggering GCs. This also keeps the sandbox and non-sandbox mode more consistent, as these stores will never trigger GC in non-sandbox builds. Since there must be millions of objects that own the external pointer table entries, the chances are quite high that GCs will anyway be scheduled. If not, we should instead see if we can introduce an API to only schedule incremental marking but not perform GC finalization. Bug: v8:13535 Cr-Commit-Position: refs/heads/main@{#84508} (cherry picked from commit 852aa18) Change-Id: I6e7b927ec722b7c9aff2fc6e620b70c94b29db41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086221 Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Samuel Groß <[email protected]> Cr-Commit-Position: refs/branch-heads/10.8@{v8#42} Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} Cr-Branched-From: 237de89-refs/heads/main@{#83672}

Change-Id: I5bf9489d7e866fe749a3d8b9f66e17543f385413 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855452 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.4@{v8#42} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}

(cherry picked from commit 6411212) Bug: chromium:1380063 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I6cffab1478388c9db560ecd5169d958db97c26d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4008363 Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Maya Lekova <[email protected]> Cr-Commit-Position: refs/branch-heads/10.7@{v8#42} Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1} Cr-Branched-From: 9521696-refs/heads/main@{#83201}

Change-Id: Ie324e1635e01895a4e6ccdc95cbbd3703c36ce82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605049 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.4@{v8#42} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}

Change-Id: I4b8d7bf3ad7b5a455595ca0398ffbd94b71e2719 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4726743 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#42} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}

Change-Id: I68bb08b3042d44eaa1218a7903206dea73a29abb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4902688 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.7@{v8#42} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}

Change-Id: I0e7ff2e9813c9675446206b0b254904b1c7f298b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5184758 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#42} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}

and: [wasm] Introduce new heap type 'imported string' (cherry picked from commit cfe1ccc) (cherry picked from commit 841c7c1) Fixed: b/326091470, b/324747822 Change-Id: Ia7ad389697b6a75d0af6d0130942b572e0243d73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5339904 Reviewed-by: Darius Mercadier <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/branch-heads/12.2@{#42} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}

… map had one If any previous map in the transition tree had an enum cache, then we recreate one when updating the map. (cherry picked from commit 807cf7d) Bug: b/330760873 Change-Id: I9c434486716055f9fab6dfe73d78e99b3a45b490 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5388435 Commit-Queue: Igor Sheludko <[email protected]> Auto-Submit: Darius Mercadier <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#92979} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5410318 Reviewed-by: Darius Mercadier <[email protected]> Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]> Cr-Commit-Position: refs/branch-heads/12.0@{#42} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}

Wasm-to-js wrappers are sometimes compiled as on-heap Code objects, for example when tiering-up from a WasmFuncRef call origin. The frames of these functions are mapped to a subclass of TypedFrame, however TypedFrame::Iterate() only supports iterating the generic wasm-to-js wrapper. Add support for iterating the tagged parameters of optimized wasm-to-js wrappers in TypedFrame::Iterate. For this we also add two 16-bit fields in the Code object to encode the incoming tagged parameter region, which we would normally find in the WasmCode data. [email protected] Fixed: 346597059 (cherry picked from commit 901377b) Change-Id: I1e3345eee73105f05408fc9c26f069e79c7efe3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5658371 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Thibaud Michaud <[email protected]> Cr-Commit-Position: refs/branch-heads/12.6@{#42} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}

Bug: chromium:351865302 (cherry picked from commit f784b0b) Change-Id: Idf6bf9276d5510376594f31ee563e4a0bee617f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5806588 Reviewed-by: Matthias Liedtke <[email protected]> Commit-Queue: Nico Hartmann <[email protected]> Auto-Submit: Nico Hartmann <[email protected]> Commit-Queue: Matthias Liedtke <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#42} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}

Change-Id: I7d3f0ff2b07f5556c5854cf5c7a045964a121067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5883354 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#42} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}

Version incremented at https://cr-buildbucket.appspot.com/build/8728857298770794705 Change-Id: Ifc5bacbad629d911ccaddf6c6167928e627a4e27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6087761 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.0@{#42} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}

…le-block loops Fixed: 383356864 (cherry picked from commit f231d83) Change-Id: I6a4a406d89d09b5ade3d5a5252a5b8921b8919a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097630 Auto-Submit: Jakob Kummerow <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Eva Herencsárová <[email protected]> Commit-Queue: Eva Herencsárová <[email protected]> Cr-Commit-Position: refs/branch-heads/13.2@{#42} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}

In Liftoff's PrepareTailCall, we kept the UseScratchRegisterScope open for longer than necessary. Close the scope earlier to ensure that we don't run out of scratch registers in the last "sub" instruction if it needs one. [email protected] Fixed: 384565015 (cherry picked from commit 7c9e628) Change-Id: Ieda0f130a56b5923781409fe6b56b44a82efd206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6148648 Commit-Queue: Thibaud Michaud <[email protected]> Reviewed-by: Daniel Lehmann <[email protected]> Cr-Commit-Position: refs/branch-heads/13.1@{#42} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}

This is a reland of commit 1827ed8 Before the change, one of the nodes had more than 2^16 inputs so optimization bailed out. After the change, the function has fewer parameters and gets optimized, and the register allocator struggles with that many parameters and times out. Just mark the test as slow for now. Original change's description: > Lower the maximum JS parameter count > > To allow extra implicit arguments on the call node without overflowing > the uint16_t input count, in particular in the wasm-to-js wrapper where > we don't have a bailout mechanism. > > [email protected] > > Fixed: 394350433 > Change-Id: I61d2e2387539cafd6a0909c3ee035c93d0217be3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6239302 > Reviewed-by: Toon Verwaest <[email protected]> > Commit-Queue: Thibaud Michaud <[email protected]> > Cr-Commit-Position: refs/heads/main@{#98556} (cherry picked from commit 84a0e23) Change-Id: I0a36d0f6e647cc0cf584c69a534f3ce82738134c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6269033 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Thibaud Michaud <[email protected]> Cr-Commit-Position: refs/branch-heads/13.3@{#42} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}

Version incremented at https://cr-buildbucket.appspot.com/build/8720524453977548977 Change-Id: I1b483b35dcf02ce4b6e5d7f5d7d81f447bff5621 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6351173 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.4@{#42} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}

Version incremented at https://cr-buildbucket.appspot.com/build/8710976477698791377 Change-Id: Ia52ede763d28977d3c6424793bebfe770a631c9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6680453 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#42} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}

Version incremented at https://cr-buildbucket.appspot.com/build/8698206268780158593 Change-Id: I1ea2cce7ebc43213b1cd282f5b47701b0d305e57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7157872 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#42} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}

jakobkummerow closed this Jun 8, 2020

ghost referenced this pull request in riscv-collab/v8 Jul 15, 2020

Merge branch '42-error-mfhc1-generated' into 'riscv-porting-dev'

b764677

Resolve "ERROR: mfhc1 generated" Closes #42 See merge request swlab/swe/v8!60

ghost pushed a commit to palmer-dabbelt/v8 that referenced this pull request Jul 22, 2020

Merge pull request v8#42 from v8-riscv/contributing

82d3490

Create CONTRIBUTING file

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Version 8.5.133 #42

Version 8.5.133 #42

Uh oh!

zyadomer999 commented Jun 8, 2020

Uh oh!

googlebot commented Jun 8, 2020

Uh oh!

jakobkummerow commented Jun 8, 2020

Uh oh!

zyadomer999 commented Jun 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Version 8.5.133 #42

Version 8.5.133 #42

Uh oh!

Conversation

zyadomer999 commented Jun 8, 2020

Uh oh!

googlebot commented Jun 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

jakobkummerow commented Jun 8, 2020

Uh oh!

zyadomer999 commented Jun 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants