Skip to content

Define basestring in Python 3 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cclauss wants to merge 1 commit into from
Closed

Define basestring in Python 3 #38

cclauss wants to merge 1 commit into from

Conversation

@cclauss
Copy link

@cclauss cclauss commented Feb 18, 2020 •
edited
Loading

The Python builtin basestring has been removed from all currently supported versions of Python so define basestring in Python 3 so that line 60 does not raise a NameError at runtime. @bmsdave @targos Please submit upstream.

@cclauss
Define basestring in Python 3
3c89da9 
The Python builtin `basestring` has been removed from all [currently supported version of Python](https://devguide.python.org/#status-of-python-branches) so define `basestring` in Python3 so that line 60 does not raise a NameError at runtime.  @bmsdave @targos Please submit upstream.
@bmsdave
Copy link
Contributor

bmsdave commented Feb 22, 2020

submit: https://chromium-review.googlesource.com/c/v8/v8/+/2069317

@bmsdave
Copy link
Contributor

bmsdave commented Feb 24, 2020

changes is merged.

pull bot pushed a commit to p-g-krish/v8 that referenced this pull request Feb 24, 2020
@bmsdave
Define basestring in Python 3
93230d3 
The Python builtin `basestring` has been removed from all [currently supported version of Python](https://devguide.python.org/#status-of-python-branches) so define `basestring` in Python3 so that line 60 does not raise a NameError at runtime.

Related task: v8#38

Bug: v8:10256
Change-Id: I087c561fff5a19aab1fec71e1ea0435cbfeca5d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069317
Reviewed-by: Tamer Tas <[email protected]>
Commit-Queue: Tamer Tas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#66403}
@cclauss cclauss closed this Feb 24, 2020
@cclauss cclauss deleted the patch-1 branch February 24, 2020 13:28
@cclauss
Copy link
Author

cclauss commented Feb 24, 2020

Thanks!!

@cclauss
Copy link
Author

cclauss commented Mar 21, 2020 •
edited
Loading

@bmsdave @mmarchini @targos Two more undefined names in upstream

flake8 testing of https://github.com/v8/v8 on Python 3.8

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./test/debugging/wasm/gdb-server/gdb_rsp.py:35:14: F821 undefined name 'xrange'
    for i in xrange(int(timeout_in_seconds / poll_time_in_seconds)):
             ^
./test/debugging/wasm/gdb-server/gdb_rsp.py:67:8: F821 undefined name 'sys'
    if sys.platform == 'win32':
       ^
2     F821 undefined name 'xrange'
2

@mmarchini
Copy link
Contributor

mmarchini commented Mar 21, 2020 •
edited
Loading

@cclauss the best place to report this is https://bugs.chromium.org/, but fwiw these undefined names shouldn't affect Node.js builds.

@cclauss
Copy link
Author

cclauss commented Mar 21, 2020

These are tests. If they are run on Python then they probably fail. I know from experience that reporting them upstream is insufficient. They actually have to be fixed upstream and then reviewed and landed. @bmsdave and @targos have assisted me in this way several times.

@mmarchini
Copy link
Contributor

mmarchini commented Mar 22, 2020

I see. Any idea why those tests don't fail upstream (the undefined sys should fail if that's an issue)? V8 infrastructure has way more coverage than ours.

If you have a patch I can submit it for you.

On a side note: maybe we want to collaborate with V8 to have flake8 as part of their linting tools? Linters runs before every push on their official repo, as well as on every CI run.

billti pushed a commit to billti/v8 that referenced this pull request Apr 6, 2020
Version 8.1.307.18
ffc8305 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Id74aeaf0be1b7d8dcfaae5e6263bb9bdea38e7e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080162
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.1@{v8#38}
Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1}
Cr-Branched-From: f22c213-refs/heads/master@{#66031}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Sep 2, 2020
Version 8.5.210.19
dc26f2d 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ideea1eb2abab7c6ce826a11480dc15e8f7410cc1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336935
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#38}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.8.279.19
6584de6 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I5f456616cc34c52ba8ce5b5b20cad8981e9ba610
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870546
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.8@{v8#38}
Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1}
Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.4.288.18
0dd78c7 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic82ca7924d8c603afe891e5477ab6f2fd1e61839
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550703
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.4@{v8#38}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.9.317.19
d7968ad 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic3eb625812ec8fcb8314f948a1606cae0e72590c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899256
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.9@{v8#38}
Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@ulan
Merged: [heap] Fix data race in Sweeper::MakeIterable
a24b6e6 
Revision: 31d36ad

BUG=chromium:1040700
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Ic794051a85489fe7d48f2f8c4f3f8e6b6efba1fb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056850
Reviewed-by: Maya Lekova <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.0@{v8#38}
Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2}
Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@jkunkee
Merged: Squashed multiple commits.
00d216f 
Merged: snapshot: add source line stubs for ARM64 Windows
Revision: 58cefed

Merged: Move ARM64 Assembler::nop definition from header to source file
Revision: 7803fa6

BUG=chromium:893460,v8:8870
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Idc2623b2f12220e42ddb9388a36d4f02ff2a1409
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506201
Reviewed-by: Jakob Gruber <[email protected]>
Commit-Queue: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.3@{v8#38}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@jiayaolinn
Merged: PPC/s390: [regexp] Allow JSRegExpResult allocations in large …
a7662b3 
…object space

Revision: 1250611

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected], [email protected], [email protected], [email protected]

Bug: chromium:976627
Change-Id: I4682aa4090de41c2b750464a66b4c7faaad4c7b7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1688558
Reviewed-by: Milad Farazmand <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.6@{v8#38}
Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1}
Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@isheludko
Merged: Squashed multiple commits.
ac14ed9 
Merged: [turbofan] Always pass correct receiver to CallFunctionTemplate.
Revision: 0e5ed53

Merged: [turbofan] Fixup wrong code comments.
Revision: e73776c

[email protected]

BUG=chromium:961199,v8:8820
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Ic98556763f83518ca848acc9be2f019d1c56c1d3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622965
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.5@{v8#38}
Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1}
Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@syg
Merged: [weakrefs] Make unregister_token undefined on popped WeakCells
cbd72a3 
The unregister_token slot is iterated as a custom weak pointer slot,
which means the heap verifier treats it as a strong slot. Currently,
popped WeakCells (that is, WeakCells for which the owning
FinalizationRegistry's finalizer has already been invoked) neither
clears out the unregister_token slot nor marks it, which trips the heap
verifier.

(cherry picked from commit 93c0be4)

[email protected]
NOTRY=true

Bug: chromium:1102161
Change-Id: I176b8422218653da97023f9eda33997729f4e9c3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309153
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.4@{v8#38}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Merged: [sparkplug][debugger] Fix deopt of inlined function in debugger
324768b 
We could end up in a baseline entry trampoline without having
baseline code, because of an unhandled interaction in the debugger
(discarding baseline code) and the deoptimizer.

Bug: chromium:1199681

(cherry picked from commit c560e1f)

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Tbr: [email protected]
Change-Id: Ia33bb4d64903dd989728465b3d83a88b84597a8f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871447
Reviewed-by: Patrick Thier <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#38}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Revert "Merged: [sparkplug][debugger] Fix deopt of inlined function i…
6eb039a 
…n debugger"

This reverts commit 324768b.

Reason for revert: Breaks build (https://ci.chromium.org/ui/p/v8/builders/ci.br.beta/V8%20Linux64%20-%20builder/244/overview)

Original change's description:
> Merged: [sparkplug][debugger] Fix deopt of inlined function in debugger
>
> We could end up in a baseline entry trampoline without having
> baseline code, because of an unhandled interaction in the debugger
> (discarding baseline code) and the deoptimizer.
>
> Bug: chromium:1199681
>
> (cherry picked from commit c560e1f)
>
> No-Try: true
> No-Presubmit: true
> No-Tree-Checks: true
> Tbr: [email protected]
> Change-Id: Ia33bb4d64903dd989728465b3d83a88b84597a8f
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871447
> Reviewed-by: Patrick Thier <[email protected]>
> Commit-Queue: Patrick Thier <[email protected]>
> Cr-Commit-Position: refs/branch-heads/9.1@{v8#38}
> Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
> Cr-Branched-From: f565e72-refs/heads/master@{#73847}

Bug: chromium:1199681
Change-Id: Id8d73ffa1b57dd89bdb00b50a0421e1093326c2b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871452
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#41}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Reland "Merged: [sparkplug][debugger] Fix deopt of inlined function i…
5e472f5 
…n debugger"

This is a reland of 324768b

Rename Interpreter Entry Trampolines to names used in 9.1.

Original change's description:
> Merged: [sparkplug][debugger] Fix deopt of inlined function in debugger
>
> We could end up in a baseline entry trampoline without having
> baseline code, because of an unhandled interaction in the debugger
> (discarding baseline code) and the deoptimizer.
>
> Bug: chromium:1199681
>
> (cherry picked from commit c560e1f)
>
> No-Try: true
> No-Presubmit: true
> No-Tree-Checks: true
> Tbr: [email protected]
> Change-Id: Ia33bb4d64903dd989728465b3d83a88b84597a8f
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871447
> Reviewed-by: Patrick Thier <[email protected]>
> Commit-Queue: Patrick Thier <[email protected]>
> Cr-Commit-Position: refs/branch-heads/9.1@{v8#38}
> Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
> Cr-Branched-From: f565e72-refs/heads/master@{#73847}

Bug: chromium:1199681

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I273c10b05941acd9831b16527929033987d3e0bf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871453
Commit-Queue: Patrick Thier <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#45}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
BenPope pushed a commit to BenPope/v8 that referenced this pull request Dec 10, 2021
@mi-ac
Merged: Remove --isolated from mb.py
cf6b308 
Revision: 55a26dc

BUG=chromium:1271841
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I98147d6b8b225596ca0a4a7089cef3ce1cf3f6b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312479
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#38}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.2.230.19
e97ba3c 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie403dc76f38ad8c84f416c31679c9ec4bc12f618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3026723
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#38}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.9.255.18
86a9141 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I1ccde926913294b63362d6b6829dab0e14865e8e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2688061
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#38}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@ajklein
Version 9.4.146.18
e18ed17 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic9482600649615c6e98aa3961c53b1c869baf507
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194876
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#38}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@jaro-sevcik
Merge: [inspector] Use ephemeron table for exception metadata
29be688 
EphemeronHashTable does not trigger interrupts when accessed
(as opposed to calling the WeakMapGet builtin), so it avoids
the use-after-free problem when reading exception metadata
triggers session disconnect while holding a reference
to the session.

(cherry picked from commit 7994004)

Bug: chromium:1241860
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I29264b04b8daf682e7c33a97faedf50e323d57c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218987
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#38}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@gahaas
Merged: [wasm][liftoff][ia32] Fix register allocation of CompareExchange
f44fcbf 
The register that holds the {new_value} for the AtomicCompareExchange8U
has to be a byte register on ia32. There was code to guarantee that, but
after that code there was code that frees the {eax} register, and that
code moved the {new_value} to a different register again. With this CL
we first free {eax}, and then find a byte register for the {new_value}.

R=​[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

(cherry picked from commit 70a389a)

Bug: chromium:1140549
Change-Id: I1679f3f9ab26c5416ea251c7925366ff43336d85
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2491031
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#70721}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504512
Cr-Commit-Position: refs/branch-heads/8.6@{v8#38}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.3.345.19
0add9c1 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I73cb9defb40b4dcc93187db0e4a0bb06710a86a2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152519
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.3@{v8#38}
Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1}
Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.0.257.19
2a79cd5 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I35777b48e2387a9d992cc2127cad54c53483671f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2830227
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#38}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@syg
Merged: [compiler] Fix typing JSLoadNamed of private brands
ee6a74e 
Private method loads are compiled to a named load of a private brand,
which always loads a BlockContext. This BlockContext holds the private
methods common to all instances of a class. TurboFan currently considers
JSLoadNamed to be of Type::NonInternal(). Private methods break this
assumption, since BlockContext is of Type::OtherInternal().

This CL changes the typing of JSLoadNamed of private brands to be
Type::OtherInternal().

Bug: v8:12500, chromium:1287475

(cherry picked from commit d19a707)

Change-Id: I91f39747bf9422bd419d299f44152f567d8be8db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3399225
Reviewed-by: Maya Lekova <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{v8#38}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.7.220.19
6dc8dbf 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I4745769ae925d729354985c8d35a8c73a9e12a2a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523211
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.7@{v8#38}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 11.0.226.19
a51a1bb 
Change-Id: I6ba9da9e10a771ed4e3d7c8ec61503e7eba03730
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4295211
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.0@{v8#38}
Cr-Branched-From: 06097c6-refs/heads/11.0.226@{#1}
Cr-Branched-From: 6bf3344-refs/heads/main@{#84857}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.2.154.20
9661c82 
Change-Id: I3a054e54a491a66ab32cc7e7d83625d9c69a8f7b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4030617
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.2@{v8#38}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 11.2.214.17
671cc5f 
Change-Id: Ib36e8e8187bf05a5744032b4adb6fe617570de0d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4464481
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.2@{v8#38}
Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.6.194.19
dba3508 
Change-Id: I6d430f17353d1af24fa66806ae28289508615c44
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3941872
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#38}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Merged: [buildtools] skip fetching ninja and reclient on ppc/s390 pla…
d3d5232 
…tforms

Revision: a593add

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Bug:v8:13454

Change-Id: I8cf5ece7e35eb0a4e1dbee5a147d330f72d15aaf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4004960
Commit-Queue: Milad Farazmand <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.7@{v8#38}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 3, 2023
Version 11.4.183.19
56e5481 
Change-Id: I4373577c1fd9eed94d8d3c8781da9e342e432209
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4583274
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#38}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 25, 2023
Version 11.5.150.19
34340db 
Change-Id: I7d31641337af974d12a72dc2c2a748e5f80da4c1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4711105
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#38}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 15, 2023
@syg
Merged: [interpreter] Fix TDZ elision in do-while tests
cf1d4d3 
(cherry picked from commit 1626e22)

Change-Id: Ifb7461b6cfd62a10936470a760cb505cc5e1c60f
Fixed: chromium:1477588
Bug: v8:13723
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4862981
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.6@{v8#38}
Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3}
Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Oct 1, 2023
@zjiaz
Merged: [loong64][mips64] Fix comparison with 32-bit data for switches
acab53a 
The input register of comparison may contain dirty data in it's
upper 32 bits, which will result in a wrong comparison result.

Bug: v8:14344

(cherry picked from commit dbcc3ef)

Change-Id: I34888b80fb1bef9a7fce6c1d10fc2883ef984a3f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4899966
Reviewed-by: Lutz Vahl <[email protected]>
Commit-Queue: Lutz Vahl <[email protected]>
Auto-Submit: Zhao Jiazhong <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.7@{v8#38}
Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 7, 2024
Version 12.1.285.19
4015051 
Change-Id: I15c60ca6e50d830d7f1b8f7e919a7e4f6f44c752
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5171438
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#38}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Feb 27, 2024
@gahaas
Merged: [wasm] Add bounds check in tier-up of wasm-to-js wrapper
5578c6d 
The entry index in the WasmApiFunctionRef was used to look for the given
WasmApiFunctionRef in the indirect function tables, but it was not
considered that the indirect function tables can have different lengths.

[email protected]

Bug: 325893559

(cherry picked from commit 7330f46)

Change-Id: I52355890e21490c75566216985680c64e0b0db75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5323850
Commit-Queue: Andreas Haas <[email protected]>
Reviewed-by: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.2@{#38}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request Mar 13, 2024
@zakharvoit
[M120-LTS][turboshaft] Fix wrong constant folding of strings map loads
3c44945 
is_stable should only be used on non-primitive maps. Strings can
change maps despite their maps being "stable".

(cherry picked from commit afc1884)

Bug: chromium:1518396
Change-Id: I3bcb33223f6d08df30d97da6eca2b06efb052960
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5217051
Auto-Submit: Darius Mercadier <[email protected]>
Commit-Queue: Darius Mercadier <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#91942}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5320119
Reviewed-by: Darius Mercadier <[email protected]>
Commit-Queue: Zakhar Voit <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.0@{#38}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request May 22, 2024
@syg
Merged: [parser] Using FunctionParsingScope for parsing class static …
6e5e105 
…blocks

Class static blocks contain statements, don't inherit the
ExpressionScope stack.

(cherry picked from commit 3e037e1)

Bug: 341663589
Change-Id: Ice9a710293b028e5d9fd30d5d85c4842f970b152
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5558360
Reviewed-by: Adam Klein <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Commit-Queue: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.4@{#38}
Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1}
Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
hubot pushed a commit that referenced this pull request Jun 21, 2024
@jakobkummerow
Merged: [turboshaft][arm64] Disable ConditionalCompare optimization
45738be 
It has bugs.

Bug: 347961785
(cherry picked from commit cff1b40)

Change-Id: I0b6ac11a10de38ff287b1fed07679d4987ad5d81
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5644893
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Matthias Liedtke <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.6@{#38}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Aug 21, 2024
@dtig
Revert "Merged: [runtime] Empty scope info + not compiled = no outer"
0885e7e 
This reverts commit 67169ad.

Reason for revert: Crashes on 128 branch

Original change's description:
> Merged: [runtime] Empty scope info + not compiled = no outer
>
> Bug: 354758515
>
> (cherry picked from commit 636350e)
>
> Change-Id: I33900b6aadd92da18a24a16b1a3c69fa02860fa5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5784823
> Reviewed-by: Shu-yu Guo <[email protected]>
> Commit-Queue: Deepti Gandluri <[email protected]>
> Cr-Commit-Position: refs/branch-heads/12.8@{#26}
> Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
> Cr-Branched-From: 451b63e-refs/heads/main@{#95151}

Bug: 354758515
Change-Id: I27043daa070e7af09b3efa6fcae53a5847210f05
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797857
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Deepti Gandluri <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.8@{#38}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Aug 26, 2024
@sethbrenith
[M127][compiler] Clear stale data for ZeroExtendsWord32ToWord64
bd5ec8a 
The first call to ZeroExtendsWord32ToWord64 produces a correct result,
but leaves some incorrect values in phi_states_. To avoid incorrect
behavior, we should clear those values when starting anew.

I think that the performance impact of this change on compilation time
should be small, because calls to ZeroExtendsWord32ToWord64 are
infrequent. Here is a histogram showing, per function compiled in
Octane, how often this new code is run:

0: 74.7%
1: 13.1%
2: 6.3%
3: 2.5%
4 or 5: 1.7%
6 to 9: 0.9%
11 to 33: 0.8%

(cherry picked from commit 780d560)

Bug: 356196918
Change-Id: I00a9e74652025bf8a32cb083a6e01c0273e44043
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5766478
Commit-Queue: Seth Brenith <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#95528}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5809258
Commit-Queue: Thibaud Michaud <[email protected]>
Reviewed-by: Seth Brenith <[email protected]>
Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <[email protected]>
Reviewed-by: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.7@{#38}
Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1}
Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot pushed a commit that referenced this pull request Sep 20, 2024
Version 12.9.202.19
e112a55 
Change-Id: Ib480e9ef1353f31388fa47ea2b0a76f44e916485
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5876448
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.9@{#38}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Nov 14, 2024
Version 13.0.245.19
94570c6 
Version incremented at https://cr-buildbucket.appspot.com/build/8731297188889731153

Change-Id: If38c95abbafcd7defb05c02ea1c1277538934063
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6021341
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.0@{#38}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Dec 11, 2024
@DadaIsCrazy
Merged: [maglev] Avoid retagging loop phi backedges too early
be40691 
When we decide that a loop phi should remain tagged, we call
EnsurePhiInputsTagged to ensures that it only has tagged inputs, which
calls EnsurePhiTagged, which might cause retagging of any untagged
phi it has as input.

In order to avoid retagging multiple times the same Phi, we have a
SnaphotTable (`phi_taggings_`), which records existing tagging in the
predecessors, and in which EnsurePhiTagged looks to avoid creating
new retagging nodes. For loop phis, the backedge predecessor won't
have an entry yet in this SnapshotTable (since we only visit loops
once, this has to be the first time we visit the header and thus
we can't have already visited the backedge block), and we should
thus not call EnsurePhiTagged on the backedge.

Note that the backedge input will anyways be properly tagged when
FixLoopPhisBackedge is later called from the JumpLoop backedge.

Fixed: chromium:382190919
(cherry picked from commit e4ecfc9)

Change-Id: I9742967003cf108b0805601a4f9bc6d9934e734f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6084685
Auto-Submit: Olivier Flückiger <[email protected]>
Commit-Queue: Olivier Flückiger <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.2@{#38}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Dec 16, 2024
@Liedtke
Merged: [turboshaft][wasm] WasmGCTypeAnalyzer: Fix phi input for sing…
576543f 
…le-block loops

Fixed: 383356864
(cherry picked from commit f231d83)

Change-Id: Id9b88581b62c22fdeff2fbb69d9331e17d076244
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097631
Auto-Submit: Jakob Kummerow <[email protected]>
Reviewed-by: Eva Herencsárová <[email protected]>
Commit-Queue: Eva Herencsárová <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.1@{#38}
Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1}
Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot pushed a commit that referenced this pull request Feb 6, 2025
@jakobkummerow
Merged: [wasm] Replace {dead_code_} set with {is_dying_} bit
19ad509 
This saves some memory, and fixes a bug.

Fixed: 391907159
(cherry picked from commit 33ca4f5)

Change-Id: I3324f33bbf7b6a191b508e854ef92c9e9a5efba5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6239495
Reviewed-by: Matthias Liedtke <[email protected]>
Commit-Queue: Matthias Liedtke <[email protected]>
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.3@{#38}
Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1}
Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot pushed a commit that referenced this pull request Mar 7, 2025
Version 13.4.114.19
a57459a 
Version incremented at https://cr-buildbucket.appspot.com/build/8721058033842047953

Change-Id: I1df5eb6efab576301b29fa19a5c3e0e89b6aa56c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6333581
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.4@{#38}
Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1}
Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot pushed a commit that referenced this pull request Jun 17, 2025
Version 13.8.258.19
0ea9b08 
Version incremented at https://cr-buildbucket.appspot.com/build/8711776185347996721

Change-Id: I6e570d9ec2d2c1c78a43a95bb16003bc66f04b37
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6652390
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.8@{#38}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Aug 18, 2025
@rmahdav
Merged: [explicit-resource-management] Fix parsing in c-style for
4011bde 
Based on spec text, we should have only one await when exiting
c-style for loop with `await using` declaration and not one
await per iteration.

Bug: 436181695
Change-Id: Ib9686b8ef14edbd0d528468cff7ccd69bf5c3dcb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6853483
Auto-Submit: Olivier Flückiger <[email protected]>
Reviewed-by: Deepti Gandluri <[email protected]>
Commit-Queue: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.9@{#38}
Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1}
Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot pushed a commit that referenced this pull request Nov 11, 2025
Version 14.2.231.19
ace3d51 
Version incremented at https://cr-buildbucket.appspot.com/build/8698509770256509713

Change-Id: Id69816c76ed8de2c6e95b533998667cbe50f9048
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7139286
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.2@{#38}
Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1}
Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot pushed a commit that referenced this pull request Jan 15, 2026
@mi-ac
Merged: Change siso deps location for v8.
466a784 
(cherry picked from commit 0b40dad)

Bug: 476027530
Change-Id: I16f1c1d702ca7d4fbbbacb29b687052658c7b8a2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7409927
Reviewed-by: Clemens Backes <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Marc Jin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#104546}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7485549
Auto-Submit: Michael Achenbach <[email protected]>
Reviewed-by: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.4@{#38}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @bmsdave @mmarchini