Skip to content

Fix build error on Solaris: conflicting madvise() declaration #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
batrla wants to merge 1 commit into from
Closed

Fix build error on Solaris: conflicting madvise() declaration #37

batrla wants to merge 1 commit into from

Conversation

@batrla
Copy link

@batrla batrla commented Feb 7, 2020

Build on Solaris fails with following error:

./deps/v8/src/base/platform/platform-posix.cc:73:16: error: conflicting declara
tion of C function 'int madvise(caddr_t, std::size_t, int)'
 extern "C" int madvise(caddr_t, size_t, int);
                ^~~~~~~
In file included from ../deps/v8/src/base/platform/platform-posix.cc:20:0:
/usr/include/sys/mman.h:232:12: note: previous declaration 'int madvise(void*, s
td::size_t, int)'
 extern int madvise(void *, size_t, int);
            ^~~~~~~

There's no reason to re-declare madvise(3C) on any recent Solaris version, because the declaration is provided in sys/mman.h header depending on set of macros defined during compile time. Anyway the compiler / header chooses the right declaration from standard header file compatible with v8 as the build on Solaris works fine out-of-the-box when the private declaration in v8 is simply removed.

Snippet of man page of madvise(3C) follows, both header files already included by platform-posix.cc:

Standard C Library Functions                                       madvise(3C)

NAME
       madvise - provide advice to VM system

SYNOPSIS
       #include <sys/types.h>
       #include <sys/mman.h>

       int madvise(void *addr, size_t len, int advice);

https://docs.oracle.com/cd/E88353_01/html/E37843/madvise-3c.html

@googlebot
Copy link

googlebot commented Feb 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jakobkummerow
Copy link
Contributor

jakobkummerow commented Feb 7, 2020

Thanks for your contribution! This repository is a read-only mirror, so we can't accept any PRs here. Please see https://v8.dev/docs/contribute for how to get your patch into V8.

billti pushed a commit to billti/v8 that referenced this pull request Apr 6, 2020
Merged: [runtime] Avoid UAF in CollectKeys
a390f01 
Revision: f6e3c9c

BUG=chromium:1049013
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I0d36b56b7490793cbaefd6c5076db30d651d7f4d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078543
Reviewed-by: Georg Neis <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.1@{v8#37}
Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1}
Cr-Branched-From: f22c213-refs/heads/master@{#66031}
ghost referenced this pull request in riscv-collab/v8 Jul 15, 2020
@obycode
Handle Ror with 0
8a64fb7 
This fixes the errors with the `machops` tests related to `Ror`.
Fixes #37
ghost referenced this pull request in riscv-collab/v8 Jul 15, 2020
Merge branch '37-ror' into 'riscv-porting-dev'
2599422 
Handle `Ror` with 0

Closes #37

See merge request swlab/swe/v8!43
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Sep 2, 2020
@ngzhian
Merged: [wasm-simd][liftoff] Fix i64x2.shr_s overwriting scratch
d9c0021 
x64's implementation of i64x2.shr_s was overwriting the scratch
register. kScratchRegister is used to hold the extracted lane of the
SIMD register, but in certain cases [0], is also used to back up the
value of rcx. When this happens, the supposed backed-up rcx was
overwritten (definitely) by each extract lane, so we end up restoring
an incorrect value of rcx, leading to an eventual crash in certain
benchmarks, when this extracted lane was used as a memory operand (see
linked bugs).

[0] when register holding the shift value is not rcx, which sarq_cl
relies on

Bug: v8:10752
Bug: chromium:1111522
Cr-Commit-Position: refs/heads/master@{#69208}
(cherry picked from commit d5c58d9)
Tbr: [email protected]

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I52a56c64b759b4d600b2c395331f8ee1dc541b03
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335611
Reviewed-by: Zhi An Ng <[email protected]>
Commit-Queue: Zhi An Ng <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#37}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Merged: Avoid output timeout when using progress indicator ci [7.8]
656c662 
Revision: b3270b8

BUG=v8:9146
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I9c536e683cd93b4fc1a5320eee643d2de5bfdf83
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864932
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.8@{v8#37}
Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1}
Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@jaro-sevcik
Merged: [turbofan] Make sure nodes are killed on replacement
babb052 
Revision: 1ec7ffe

BUG=chromium:945644
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Icd4967f015e704ce56cc20539faf62c0e53abba2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549170
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.4@{v8#37}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@sigurdschneider
Merged: [ordered-hash-table] Add missing argument to ::Delete
22437e9 
Revision: be0e2c2

BUG=v8:9905
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I67df459746dc6506a9e92fd414b03ee453ee0ea5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1898661
Commit-Queue: Sigurd Schneider <[email protected]>
Reviewed-by: Sigurd Schneider <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.9@{v8#37}
Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
@mi-ac
Fix copyright check for 2020
f785c2a 
Change-Id: Iee495c3ed82e4d56e3ecafa6d4654e855f950c8f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051956
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.0@{v8#37}
Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2}
Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.3.492.20
3f95661 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I42d7ee0eb9213c878041bec12a9f605d3974bbc4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503557
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{v8#37}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.6.303.18
7b59df5 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Id5716735a254cbb3935314da243a16ec1c26e549
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683624
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.6@{v8#37}
Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1}
Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 7.5.288.19
184f696 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I5a53150cc8734fbac580a7baa2ec6fbcc339440f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622188
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.5@{v8#37}
Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1}
Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Version 8.4.371.19
819e184 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I0a8c0028645306cc6ddb8d301b0e8f6693060966
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2283236
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{v8#37}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Version 9.1.269.19
5b3ace9 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic4a5e781430093f0af9e80de5d44005d5a7f1eda
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2860327
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#37}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
BenPope pushed a commit to BenPope/v8 that referenced this pull request Dec 10, 2021
Version 9.6.180.19
da80f37 
Change-Id: I93dcfba18559b8137ae9f3b3b3ec89f0f7152439
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310425
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#37}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@GeorgNeis
Merged: [compiler] Fix a bug in CodeGenerator::AddTranslationForOperand
66d208a 
(cherry picked from commit 374354b)

Bug: chromium:1228407
Change-Id: I64b7b990fd334d4db1e40a2ba0ee52f0b8baf38a
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3027262
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#37}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@syg
Merged: [top-level-await] Implement spec fix for cycle root detection
6a1f77e 
There is a bug in the top-level await spec draft such that async
strongly connected components are not always evaluated before their
depending modules.

See tc39/proposal-top-level-await#161 for full
discussion and spec fix.

(cherry picked from commit 9689b17)

Bug: v8:11376
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667772
Reviewed-by: Adam Klein <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#72508}
Change-Id: I99b91f3e7cfa7bd76d39388bcffab4dd73bcce25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2688060
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#37}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@ajklein
Merged: [heap] Improve ephemeron processing
5c4acf2 
Revision: 1054ee7

Bug: chromium:1252918
Change-Id: I0764cb78d4a0d4b5859c0edf383c2827321db398
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195062
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#37}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.5.172.19
755eaf8 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I7912d218a4394868d1b95db2df2eddebae44eecb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208068
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#37}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.6.395.19
8e9cfb5 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I0d065a23652a421e25eae2bbee761562f82bb7dc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2503612
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#37}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@isheludko
M86-LTS: [const-tracking] Ensure map is updated before generalizing c…
69a043b 
…onstness

Revision: db2acd7

BUG=chromium:1195331
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=​[email protected]

(cherry picked from commit 5a0dd78)

Change-Id: I7ce1b36b8860a49838d208bc7857021e03f83916
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831474
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/9.0@{v8#37}
Cr-Original-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Original-Branched-From: 349bcc6-refs/heads/master@{#73001}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850705
Reviewed-by: Igor Sheludko <[email protected]>
Reviewed-by: Victor-Gabriel Savu <[email protected]>
Commit-Queue: Artem Sumaneev <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#82}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Revert "M86-LTS: [const-tracking] Ensure map is updated before genera…
4b4ad58 
…lizing constness"

This reverts commit 69a043b.

Reason for revert: causes compilation errors. kRelaxedLoad is missing.

Original change's description:
> M86-LTS: [const-tracking] Ensure map is updated before generalizing constness
>
> Revision: db2acd7
>
> BUG=chromium:1195331
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​​[email protected]
>
> (cherry picked from commit 5a0dd78)
>
> Change-Id: I7ce1b36b8860a49838d208bc7857021e03f83916
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831474
> Reviewed-by: Leszek Swirski <[email protected]>
> Cr-Original-Commit-Position: refs/branch-heads/9.0@{v8#37}
> Cr-Original-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
> Cr-Original-Branched-From: 349bcc6-refs/heads/master@{#73001}
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850705
> Reviewed-by: Igor Sheludko <[email protected]>
> Reviewed-by: Victor-Gabriel Savu <[email protected]>
> Commit-Queue: Artem Sumaneev <[email protected]>
> Cr-Commit-Position: refs/branch-heads/8.6@{v8#82}
> Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
> Cr-Branched-From: a626bc0-refs/heads/master@{#69472}

Bug: chromium:1195331
Change-Id: Id7170c30d67329b784e9a283c0171fed010970dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853588
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Artem Sumaneev <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#84}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Reland "M86-LTS: [const-tracking] Ensure map is updated before genera…
4270eea 
…lizing constness"

This reverts commit 4b4ad58.

M86 merge conflicts and resolution:
* src/objects/map-updater.cc
  Map::instance_descriptor with kRelaxedLoad dispatcher was introduced after
  8.6 branch: https://crrev.com/c/2424130. Before the patch
  Map::instance_descriptor without distpacher was used. Do the same
  here.
* test/mjsunit/regress/regress-crbug-1195331.js
  HasOwnConstDataProperty did not exist in 8.6. Add it from
  https://crrev.com/c/2566757.

Original change's description:
> Revert "M86-LTS: [const-tracking] Ensure map is updated before generalizing constness"
>
> This reverts commit 69a043b.
>
> Reason for revert: causes compilation errors. kRelaxedLoad is missing.
>
> Original change's description:
> > M86-LTS: [const-tracking] Ensure map is updated before generalizing constness
> >
> > Revision: db2acd7
> >
> > BUG=chromium:1195331
> > NOTRY=true
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > R=​​[email protected]
> >
> > (cherry picked from commit 5a0dd78)
> >
> > Change-Id: I7ce1b36b8860a49838d208bc7857021e03f83916
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831474
> > Reviewed-by: Leszek Swirski <[email protected]>
> > Cr-Original-Commit-Position: refs/branch-heads/9.0@{v8#37}
> > Cr-Original-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
> > Cr-Original-Branched-From: 349bcc6-refs/heads/master@{#73001}
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850705
> > Reviewed-by: Igor Sheludko <[email protected]>
> > Reviewed-by: Victor-Gabriel Savu <[email protected]>
> > Commit-Queue: Artem Sumaneev <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/8.6@{v8#82}
> > Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
> > Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
>
> Bug: chromium:1195331
> Change-Id: Id7170c30d67329b784e9a283c0171fed010970dc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853588
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Artem Sumaneev <[email protected]>
> Cr-Commit-Position: refs/branch-heads/8.6@{v8#84}
> Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
> Cr-Branched-From: a626bc0-refs/heads/master@{#69472}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1195331
Change-Id: Ie103a7795893860c4c4834eefe9dc327c5c46d19
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2853590
Reviewed-by: Victor-Gabriel Savu <[email protected]>
Commit-Queue: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#93}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Merged: PPC: pass a scratch reg when using register_location
59171ad 
Revision: 9861ce1

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Bug: v8:13139
Change-Id: Ica385c81f62b69132b4b1fe2569cfdbb135aa7ad
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3806440
Reviewed-by: Junliang Yan <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.4@{v8#37}
Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1}
Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@GeorgNeis
Merged: [compiler] Fix a bug in global property access reduction
034c200 
Bug: chromium:1247763
(cherry picked from commit 6391d7a)

Change-Id: Ifa775224ed30a2d680c6e3653063483c733de831
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151960
Commit-Queue: Nico Hartmann <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Reviewed-by: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.3@{v8#37}
Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1}
Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@isheludko
Merged: [const-tracking] Ensure map is updated before generalizing co…
5a0dd78 
…nstness

Revision: db2acd7

BUG=chromium:1195331
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I7ce1b36b8860a49838d208bc7857021e03f83916
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831474
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#37}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.7.106.18
96e2674 
Change-Id: I257ba27852d65370568af5f1b41e6e0acbb858d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338320
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{v8#37}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@gahaas
Merged: [wasm] Run sync compilation with kUserBlocking priority
56fedda 
With the recent switch from the tasks API to the jobs API for thread
management within WebAssembly compilation we got the problem that
TurboFan compilation of a previous compilation can block the Liftoff
compilation of a new compilation. With synchronous compilation, this can
cause significant delays for the user. With this CL we increase the
priority of synchronous compilation so that at least synchronous
compilation can only be blocked by other synchronous compilation. This
fixes issues that we saw on autocad.

Why is it okay to increase the priority of synchronous compilation?
* On the main thread, synchronous compilation is only allowed for small
  modules which should not take long to compile. Also, the compilation
  blocks the main thread and should finish as fast as possible.
* On worker threads, delaying other background work is not such a big
  issue.

Downsides:
* This does not only increase the priority of the initial compilation,
  but also for the TurboFan optimization. Similar to above, for small
  modules on the main thread this should not be a big deal because
  compilation is fast. Big modules can only be compiled on worker
  threads.

Note that this is supposed to be a fix for the problems we see at the
moment with autocad on stable and beta. Eventually compilation job
management should be done by the wasm engine for all WebAssembly
compilation, so that not each WebAssemly module has to do its own
compilation job management.

R=​[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

(cherry picked from commit a7e8c32)

Bug: chromium:1142686, v8:11088
Change-Id: Iee4948b2fcad944f587918e9452e6888258857f9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512911
Commit-Queue: Andreas Haas <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#70923}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521913
Cr-Commit-Position: refs/branch-heads/8.7@{v8#37}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
@richardlau richardlau mentioned this pull request Dec 9, 2022
Closed
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@tebbi
Merged: [compiler] check if maps become deprecated during optimization
62545e8 
Bug: chromium:1417585

(cherry picked from commit f82d802)

Change-Id: I34015aa717ac96bd00e7c7284a4d1fb4416a3a60
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4295297
Commit-Queue: Tobias Tebbi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.0@{v8#37}
Cr-Branched-From: 06097c6-refs/heads/11.0.226@{#1}
Cr-Branched-From: 6bf3344-refs/heads/main@{#84857}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@MayaLekova @tebbi
[M102-LTS][compiler] Fix mutable heap number object reference leak
871c6e4 
(cherry picked from commit 6411212)

Bug: chromium:1380063
Change-Id: Ide7622be38f575327693599bb4719f361105a0bd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3998653
Auto-Submit: Maya Lekova <[email protected]>
Commit-Queue: Darius Mercadier <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#84039}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4012778
Reviewed-by: Darius Mercadier <[email protected]>
Reviewed-by: Michael Ershov <[email protected]>
Owners-Override: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.2@{v8#37}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@LiuYu396
Reland "Merged: [loong64][mips64] Add definitions for unimplemented S…
175b343 
…IMD functions"

This is a reland of commit fb287c8

Original change's description:
> Merged: [loong64][mips64] Add definitions for unimplemented SIMD functions
>
> (cherry picked from commit eae7006)
>
> Bug: v8:13923
> Change-Id: I7fdb9d7fa405a817c525c1d8660a665a8bb2201d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4431610
> Reviewed-by: Zhao Jiazhong <[email protected]>
> Commit-Queue: Liu Yu <[email protected]>
> Cr-Commit-Position: refs/branch-heads/11.2@{v8#33}
> Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
> Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}

Bug: v8:13923
Change-Id: I7f63ccf05fa9eccbca6a12d04128ec26b4ee4357
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4462880
Commit-Queue: Liu Yu <[email protected]>
Reviewed-by: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.2@{v8#37}
Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@FrankYFTang @isheludko
Merged: Revert "[intl] Return "UTC" instead of "Etc/UTC" or "Etc/GMT"…
6684ed4 
… as DefaultTimeZone"

Bug: chromium:1356838, v8:13112
(cherry picked from commit 41419aa)

Change-Id: Idabc74acd96c0f9cdbae5b5878717f60677cc1a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3943084
Reviewed-by: Igor Sheludko <[email protected]>
Reviewed-by: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#37}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.7.193.19
bda5eca 
Change-Id: I389a0205db8dbce2b4945a473886422178b62a04
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3998736
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.7@{v8#37}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 3, 2023
@isheludko
Merged: [ic] Fix store handler selection for arguments objects
0035a4a 
Drive-by: fix printing of handlers in --trace-feedback-updates mode.

Bug: chromium:1450481
(cherry picked from commit e144f3b)

Change-Id: I0d2c90d92aa006ab37a653822f3a514343a5bac4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4583221
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#37}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 25, 2023
@verwaest
Merged: [maglev] Fix default constructor instantiation
d15afca 
The new.target may not be in the correct state for fast instantiation.

(cherry picked from commit ed93bef)

Bug: v8:7700, chromium:1465326
Change-Id: I09f92576c0b5573e902ae3b2210a7b5fdbd1e415
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4694007
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4711048
Commit-Queue: Toon Verwaest <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#37}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 15, 2023
Version 11.6.189.21
3c29619 
Change-Id: Iafb249221ced01564398312541f5f0da9913830a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4860471
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.6@{v8#37}
Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3}
Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 24, 2023
Version 11.7.439.19
eb0a047 
Change-Id: Ibe6657ce9ea8aa7f04e491f880a986374ac0b954
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4886230
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.7@{v8#37}
Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 7, 2024
Merged: [maglev] Disable hoisting of OSR value phi untagging
0fdce0d 
Bug: chromium:1513626
(cherry picked from commit e8f2feb)

Change-Id: I2d0476a07380672b35552ca68cdc8007c61689da
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5173485
Commit-Queue: Olivier Flückiger <[email protected]>
Reviewed-by: Patrick Thier <[email protected]>
Auto-Submit: Olivier Flückiger <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#37}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 28, 2024
Version 12.0.267.19
71b6b5a 
Change-Id: Ia2923ce35f3b64033bb985f4da0ff54dd671903c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5232108
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.0@{v8#37}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request Feb 22, 2024
Version 12.2.281.19
d5c5157 
Change-Id: I6b919c291ef76bc49a5c15d59f8806085f8422d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5317210
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.2@{#37}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request May 21, 2024
Version 12.4.254.19
24dba30 
Change-Id: Ie1bf8e9e547ca415bc0881f6d3e8b8b836d9da99
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5553156
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.4@{#37}
Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1}
Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
hubot pushed a commit that referenced this pull request Jun 18, 2024
Version 12.6.228.20
9f0e990 
Change-Id: I177fa4fbe7c0300d856e6a12d1c394f2537f5e13
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5635886
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.6@{#37}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Aug 21, 2024
Version 12.8.374.19
17e0da7 
Change-Id: If73ffa5b3718a9edbacae09054ca4b000eb9de8b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5800814
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.8@{#37}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Aug 22, 2024
Version 12.7.224.19
3aebb5d 
Change-Id: I85cc4ad3eb9be942f5c903d0c1aed84e27c9b932
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5804653
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.7@{#37}
Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1}
Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot pushed a commit that referenced this pull request Sep 20, 2024
@thibaudmichaud
Merged: [wasm] Check strict type equality for Tag imports
4f98c26 
[email protected]

Fixed: 365802567
(cherry picked from commit f612d9a)

Change-Id: I783383a3fa1b0ad03076878c418b1e0a1b0493bf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5872853
Commit-Queue: Jakob Kummerow <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Auto-Submit: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.9@{#37}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Nov 14, 2024
@thibaudmichaud
Merged: [wasm][jspi] Fix stack-switching in unwinder
3a3aa00 
Handle stack switching for a missing frame type, WASM_TO_JS_FUNCTION.

[email protected]

Fixed: 377384894
(cherry picked from commit ef6ed15)

Change-Id: Ib5e038ba26827002390fdff3b50ddea6e25a527f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6020069
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.0@{#37}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Dec 11, 2024
Version 13.2.152.19
3f71eff 
Version incremented at https://cr-buildbucket.appspot.com/build/8728891462100941025

Change-Id: Ibd56335883febb3b4e07ba109d5f1252b2173caa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6085130
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.2@{#37}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Dec 16, 2024
Version 13.1.201.19
7f72bbe 
Version incremented at https://cr-buildbucket.appspot.com/build/8728370718217603537

Change-Id: Ia14c1df6930d5d4a52eaee037734645a4b592745
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6096712
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.1@{#37}
Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1}
Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot pushed a commit that referenced this pull request Feb 3, 2025
Version 13.3.415.19
fe05126 
Version incremented at https://cr-buildbucket.appspot.com/build/8723963930991757169

Change-Id: Ie337b284d2dabb3948d5864437a4d91e3e62ded8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6224493
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.3@{#37}
Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1}
Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot pushed a commit that referenced this pull request Mar 7, 2025
Merged: Revert "[string] Remove String::IsOneByteRepresentationUndern…
c6d88e6 
…eath"

This reverts commit e3f33e9.

Reason for revert: https://crbug.com/398999390

This only reverts the fist part of the CL (Removing IsOneByteRepresentation).
Using static roots to determine one-byte representation from the map word alone is kept.

Original change's description:
> [string] Remove String::IsOneByteRepresentationUnderneath
>
> All string maps are split into one- and two-byte versions, and enforce
> that their underlying string must have the same byte width (e.g. we
> can't change byteness when externalizing). This means that the old
> IsOneByteRepresentationUnderneath loop is no longer needed, as we
> already know the byteness from the top.
>
> Remove this function, replacing with calls to IsOneByteRepresentation.
> Additionally, we have some static roots hacks to determine one-byte
> representation from the map word alone (without needing to dereference
> the instance type), so use that too where possible.
>
> Change-Id: I662daa3cb217d04cbfd717da53ae1238a0bcddd0
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6011010
> Commit-Queue: Leszek Swirski <[email protected]>
> Reviewed-by: Patrick Thier <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#97099}

DISABLE_SPELLCHECKER

Fixed: 398999390
(cherry picked from commit 8db16e6)

Change-Id: I2c84f730aa0527b24a3c74090aa92d689cdbe701
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6330265
Commit-Queue: Leszek Swirski <[email protected]>
Auto-Submit: Patrick Thier <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.4@{#37}
Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1}
Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot pushed a commit that referenced this pull request Jun 17, 2025
@FrankYFTang
[M138] Merged: [intl] Change fatal to exception due to lack of resources
be17957 
Other Intl object address the same issue in
https://issues.chromium.org/issues/42200234

Fixed: 412149700
(cherry picked from commit 1d82eec)

Change-Id: I99dd025c67739fe4c0904cafc894d86da67ceb0a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653381
Owners-Override: Srinivas Sista <[email protected]>
Reviewed-by: Francis McCabe <[email protected]>
Commit-Queue: Frank Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.8@{#37}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Jun 26, 2025
Version 13.7.152.19
cfefa07 
Version incremented at https://cr-buildbucket.appspot.com/build/8710972326413960529

Change-Id: I5b7454b334d0533d8f2b3faeff5e5db77928a97a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6681028
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.7@{#37}
Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1}
Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot pushed a commit that referenced this pull request Aug 4, 2025
Version 13.9.205.19
505ec91 
Version incremented at https://cr-buildbucket.appspot.com/build/8707476982232690513

Change-Id: Ib1e62d247ae8a55f690f3056312ffd1836116487
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6817897
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.9@{#37}
Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1}
Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot pushed a commit that referenced this pull request Nov 11, 2025
@isheludko
Merged: [ic] Cleanup AccessorAssembler::CallGetterIfAccessor()
78d7b6b 
This CL
 - reorders parameters to make |expected_receiver_mode| a mandatory
   one and properly computed,
 - makes sure we don't pass PropertyCell as a holder when JSReceiver is
   expected.

Bug: 450328966
(cherry picked from commit 62af07e)

Change-Id: I5329bb5cf9afe153a1eeb4b83504095a5ad96be8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124838
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.2@{#37}
Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1}
Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot pushed a commit that referenced this pull request Jan 15, 2026
Version 14.4.258.19
56a3d28 
Version incremented at https://cr-buildbucket.appspot.com/build/8692652485699430609

Change-Id: I62b50dae695b0a1c4a38ef0a69dd457b1ad7c1f6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7475459
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.4@{#37}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@batrla @googlebot @jakobkummerow @vitabatrla-lab