Travis CI: Use flake8 to find Python syntax errors #29

cclauss · 2018-12-23T21:50:14Z

Bug report: https://bugs.chromium.org/p/v8/issues/detail?id=8594

Just 1.4% of the v8 codebase is Python but that code contains:

Python 2: 4 syntax errors and 26 undefined names.
Python 3: 76 syntax errors and 42 undefined names.

UPDATE:

Python 2: 0 syntax errors and 0 undefined names.
Python 3: 1 syntax errors and 1 undefined names.

Output: https://travis-ci.com/cclauss/v8

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

F821: undefined name name
F822: undefined name name in __all__
F823: local variable name referenced before assignment
E901: SyntaxError or IndentationError
E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

Just 1.4% of the v8 codebase is Python but that code contains 118 Python 3 syntax errors and undefined names.

ibrahimgorashi98 · 2018-12-28T11:58:11Z

Thanks pro i'm so happy

Revision: c198a9b BUG=chromium:906847 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I6a43d80a7a2f2cf65cff62f631055c258e61dd19 Reviewed-on: https://chromium-review.googlesource.com/c/1385168 Reviewed-by: Alexei Filippov <[email protected]> Cr-Commit-Position: refs/branch-heads/7.2@{v8#29} Cr-Branched-From: 6acd03c-refs/heads/7.2.502@{#1} Cr-Branched-From: b03041d-refs/heads/master@{#57910}

bmsdave · 2019-02-07T14:55:26Z

we moved the changes to https://chromium-review.googlesource.com/c/v8/v8/+/1454477/9
This pull request can be closed
@cclauss

cclauss · 2019-02-12T22:46:29Z

I will close when that bugfix lands.

bmsdave · 2019-02-19T10:01:31Z

Done.

See:
https://chromium-review.googlesource.com/c/v8/v8/+/1470121
https://chromium-review.googlesource.com/c/v8/v8/+/1470101
https://chromium-review.googlesource.com/c/v8/v8/+/1470122
https://chromium-review.googlesource.com/c/v8/v8/+/1470123

cclauss · 2019-02-19T10:41:24Z

Very impressive work!! Congratulations and thank you.

Three syntax errors remaining on Python 3 and one remaining on Python 2.

flake8 testing of https://github.com/v8/v8 on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./third_party/binutils/detect_v8_host_arch.py:37:14: E999 SyntaxError: invalid syntax
  print DoMain([])
             ^
./third_party/binutils/download.py:46:66: E999 SyntaxError: invalid syntax
    print "WARNING: No binutils found for your architecture (%s)!" % arch
                                                                 ^
./third_party/inspector_protocol/roll.py:126:32: E999 SyntaxError: invalid syntax
  print 'Rolling %s into %s ...' % (src_dir, dest_dir)
                               ^
3     E999 SyntaxError: invalid syntax
3

flake8 testing of https://github.com/v8/v8 on Python 2.7.15

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./tools/locs.py:214:21: E999 SyntaxError: invalid syntax
  report_groups = {**default_report_groups, **dict(ARGS['group'])}
                    ^
1     E999 SyntaxError: invalid syntax
1

In all four cases, these are syntax errors that will halt the runtime so they should be fixed.

cclauss · 2019-03-29T14:45:07Z

Travis was turned off for this repo but here are the current results. We are getting tantalizingly close...

The issues are that execfile() and file() were removed in Python 3 and FileNotFoundError does not exist in Python 2.

Current v8/v8 issues on Python 3: flake8 testing of https://github.com/v8/v8 on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./third_party/binutils/download.py:30:8: F821 undefined name 'file'
  with file(filename, 'r') as f:
       ^
./third_party/binutils/download.py:36:8: F821 undefined name 'file'
  with file(filename, 'w') as f:
       ^
./test/preparser/testcfg.py:69:5: F821 undefined name 'execfile'
    execfile(pathname, {"Test": Test, "Template": Template})
    ^
./tools/testrunner/outproc/mkgrokdump.py:23:8: F632 use ==/!= to compare str, bytes, and int literals
    if diffstring is not "":
       ^
1     F632 use ==/!= to compare str, bytes, and int literals
3     F821 undefined name 'execfile'
4

Current v8/v8 issues on Python 2: flake8 testing of https://github.com/v8/v8 on Python 2.7.15

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./tools/locs.py:324:10: F821 undefined name 'FileNotFoundError'
  except FileNotFoundError:
         ^
./tools/testrunner/outproc/mkgrokdump.py:23:8: F632 use ==/!= to compare str, bytes, and int literals
    if diffstring is not "":
       ^
1     F632 use ==/!= to compare str, bytes, and int literals
1     F821 undefined name 'FileNotFoundError'
2

bmsdave · 2019-04-01T12:17:09Z

@cclauss sorry for delay. I will do these tasks this week.

cclauss · 2019-04-19T06:50:50Z

@bmsdave @refack Can we close this issue or not yet?

Revision: 539017b BUG=chromium:944435 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I3be5222ab8ecb9d7807f308eb8c3faf660954c7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547653 Reviewed-by: Sigurd Schneider <[email protected]> Cr-Commit-Position: refs/branch-heads/7.4@{v8#29} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}

hayd · 2019-07-02T08:00:25Z

Six months to go!

Is CI being run on python 3? Is there a good way to split up the future porting work (post syntax)? Presumably lots fail even with this patch?

cclauss · 2019-07-03T14:52:46Z

flake8 testing of https://github.com/v8/v8 on Python 3.7.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./test/preparser/testcfg.py:69:5: F821 undefined name 'execfile'
    execfile(pathname, {"Test": Test, "Template": Template})
    ^
./tools/wasm-compilation-hints/wasm-objdump-compilation-hints.py:37:54: E999 SyntaxError: invalid syntax
          print "Custom section compilationHints with", num_hints, "hints:"
                                                     ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'execfile'
2

hayd · 2019-07-03T15:16:13Z

SyntaxError is just the start of the porting story, is there buy-in to run python 3 on CI? (Or is this already happening?)

cclauss · 2019-07-03T15:24:46Z

There is a lot of traffic on the upstream repo about Python 3 experimentation but I do find it frustrating that basic linting is not yet done to avoid backsliding like we see in these two issues.

cclauss · 2019-08-19T10:11:51Z

Added #33 and #34 here if someone would be willing to push those changes upstream.

cclauss · 2019-10-02T13:25:19Z

We are backsliding:

91 days until Python 2 end of life. https://www.python.org/doc/sunset-python-2

flake8 testing of https://github.com/v8/v8 on Python 3.7.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./test/preparser/testcfg.py:69:5: F821 undefined name 'execfile'
    execfile(pathname, {"Test": Test, "Template": Template})
    ^
./tools/regexp-sequences.py:27:12: F821 undefined name 'xrange'
  for i in xrange(seqlen):
           ^
./tools/regexp-sequences.py:35:18: F821 undefined name 'xrange'
        for i in xrange(seqlen):
                 ^
./tools/regexp-sequences.py:42:18: F821 undefined name 'xrange'
        for i in xrange(seqlen):
                 ^
./tools/regexp-sequences.py:60:12: F821 undefined name 'xrange'
  for i in xrange(max_seq):
           ^
./tools/wasm-compilation-hints/wasm-objdump-compilation-hints.py:37:54: E999 SyntaxError: invalid syntax
          print "Custom section compilationHints with", num_hints, "hints:"
                                                     ^
1     E999 SyntaxError: invalid syntax
5     F821 undefined name 'execfile'
6

bmsdave · 2019-10-18T13:49:19Z

It looks like all the requirements are done:
https://travis-ci.com/bmsdave/v8/builds/132539826

This reverts commit 6fc2187. Reason for revert: to trigger another roll Original change's description: > Whitespace to trigger CI > > Bug: chromium:1426767 > Change-Id: I7d94b3b8be0ebc0901a294c3c55c27b38c2f1c5d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4556944 > Commit-Queue: Michael Achenbach <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/branch-heads/11.4@{v8#25} > Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} > Cr-Branched-From: 5483d8e-refs/heads/main@{#87241} Bug: chromium:1426767 Change-Id: I2ad4b16834364540980091d97114b49fdb250dc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4558608 Reviewed-by: Michael Achenbach <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Liviu Rau <[email protected]> Cr-Commit-Position: refs/branch-heads/11.4@{v8#29} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}

… the heap is tearing down. Revision: ab0565a BUG=chromium:818585 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I38508c1d74d8d83ffe2493054a9c5e32cebdaf86 Reviewed-on: https://chromium-review.googlesource.com/977683 Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/branch-heads/6.6@{v8#29} Cr-Branched-From: d500271-refs/heads/6.6.346@{#1} Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}

[email protected] Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I70977c97001d5c2d1c70ce73b15fe1aa2fcfb3d5 Reviewed-on: https://chromium-review.googlesource.com/847976 Reviewed-by: v8 autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6.4@{v8#29} Cr-Branched-From: 0407506-refs/heads/6.4.388@{#1} Cr-Branched-From: a5fc4e0-refs/heads/master@{#49724}

Change-Id: Id7edc8fc6627dff78f64122ff2b2e4967d0fb4fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3950156 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.7@{v8#29} Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1} Cr-Branched-From: 9521696-refs/heads/main@{#83201}

… tracking Here are the steps that lead to the bug: - main thread: map `a` was being slack-tracked - background: a compilation job serializes `a` into a MapRef `aRef` - main thread: slack tracking finished for this map. - main thread: a store to an object of map `a` created a transition from map `a` to map `b`, and the property stored was stored as the 1st item of the out-of-object properties. - background: compilation reached JSNativeContextSpecialization, which tried to optimize a JSSetNamedProperty (specifically, the same operation that lead to the map transition on the main thread). There was no feedback for this operation since it hadn't been executed before (otherwise, the map transition would have had happened before, and the MapRef would not have been out of date). JSNativeCtxtSpec inferred maps of the receiver from previous CheckMaps, and realized that the store was transitioning (from `a` to `b`). It looked at the MapRef `aRef` to see how much unused properties the object had. `aRef` still had the cached slack-tracking data, and thus thought that it still had unused properties, whereas in reality, `a` didn't have any left, and a new property backing store should have been allocated. - main thread: when executing the store generated, we tried to write to the 1st item of the out-of-object properties of an object with map `a`, which was the EmptyFixedArray root, which caused a segfault, since this is in read-only space. The fix is to add a compilation dependency for map slack-tracking when deciding to extend (or not) the property backing store of an object. At the end of compilation, if the construction_counter of the Map is 0 and the one of the MapRef is non-0, then slack tracking finished during compilation, and we discard the optimized code. While fixing this, I also found out that UnusedPropertyFields and construction_counter were sometimes incoherent in the background, because CSA was updating construction_counter without taking the map_updater_access mutex (which means that when construction_counter was 0 in the background, it wasn't always safe to look at UnusedPropertyFields, since it could contain the old value). Similarly, MapRef::IsInobjectSlackTrackingInProgress was looking at the Map rather than the cached value for construction_counter, which means that it could also be out of sync with UnusedPropertyFields. Bug: chromium:1444366 (cherry picked from commit 7effdbf) Change-Id: I6005ccf87b3bffdcf5a21c49afe4a5abc0c05789 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4667386 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Darius Mercadier <[email protected]> Cr-Commit-Position: refs/branch-heads/11.5@{v8#29} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}

Change-Id: Ie28bb228834c414639279fd3dc222a1c0fbff592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4753893 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.6@{v8#29} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}

Change-Id: I98f200abd0af6adb92cda4f3097243a0219fca3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4840447 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.7@{v8#29} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}

Change-Id: I0b34a70d5e7a8f089b3723cd086e427985464a6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4921991 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.8@{v8#29} Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1} Cr-Branched-From: b82a911-refs/heads/main@{#89779}

…ne() type (cherry picked from commit 949bbdf) Bug: chromium:1507106 Change-Id: I7c4025365f5bd90a64a10721eaf004ec9158ee2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5126075 Commit-Queue: Andreas Haas <[email protected]> Reviewed-by: Andreas Haas <[email protected]> Auto-Submit: Eva Herencsárová <[email protected]> Commit-Queue: Eva Herencsárová <[email protected]> Cr-Commit-Position: refs/branch-heads/12.1@{v8#29} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}

Change-Id: I766cb6fb50231b76fdd69e5649501dc26d4524e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5180875 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.0@{v8#29} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}

Change-Id: I0f97b8ebf07a0fb277d125b6e6ecc3b80304ab6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5285334 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.2@{#29} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}

Change-Id: I5d96843bc6bec893aecfead24de02bfcf39f910d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5403014 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.3@{#29} Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1} Cr-Branched-From: 21869f7-refs/heads/main@{#92385}

Change-Id: Iffe368c37f4466dffc09d93c299505a9dfc658e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5490496 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.4@{#29} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}

Change-Id: I43bcc91253ff3ba9bf697ec5534ac20bf4c53333 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5617911 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.6@{#29} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}

Change-Id: I5aa6b12d346ca9c686b80f7b39d02a45baa2c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5626132 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.5@{#29} Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1} Cr-Branched-From: 497d857-refs/heads/main@{#93350}

Change-Id: I8fae6dac339ab9513199a79bf7b1d6772a2cf2c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5708229 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.7@{#29} Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1} Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}

Change-Id: I5c8b004badf83b75bf5d580ac9b403cf1436c6cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5783329 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#29} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}

…ted transition Fixed: 355745234 (cherry picked from commit d49151b) Change-Id: I266e455b1a95b05814f3f522fa9689a71e303374 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5837113 Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Igor Sheludko <[email protected]> Cr-Commit-Position: refs/branch-heads/12.9@{#29} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}

Drive-by: add some CHECKs in not _clearly_ safe uses of AsJSObject to turn possible vulnerablities into crashes. Fixed: 367818758 (cherry picked from commit 81155a8) Change-Id: Ib584877812a061056519231920eef915dc87cd58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5907897 Reviewed-by: Nico Hartmann <[email protected]> Commit-Queue: Victor Gomes <[email protected]> Commit-Queue: Nico Hartmann <[email protected]> Auto-Submit: Victor Gomes <[email protected]> Cr-Commit-Position: refs/branch-heads/13.0@{#29} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}

Version incremented at https://cr-buildbucket.appspot.com/build/8730012976317083969 Change-Id: I69ea31b32b6a78594d33c8fccebb70ca8d52629b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6054695 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.1@{#29} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}

Version incremented at https://cr-buildbucket.appspot.com/build/8729521866061446657 Change-Id: I406db361793d86a7c4f359e956f41b2c38557dd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6068047 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.2@{#29} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}

Version incremented at https://cr-buildbucket.appspot.com/build/8725056753059806209 Change-Id: Ic24e47a001ac98ee2f9595d91a8e349a93ad5d40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6189196 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.3@{#29} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}

Fixed: 398065918 (cherry picked from commit eb9b259) Change-Id: I20f3979984c1df11509f1630cf4c4c4460d6a83a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6304712 Reviewed-by: Victor Gomes <[email protected]> Auto-Submit: Olivier Flückiger <[email protected]> Commit-Queue: Olivier Flückiger <[email protected]> Commit-Queue: Victor Gomes <[email protected]> Cr-Commit-Position: refs/branch-heads/13.4@{#29} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}

Version incremented at https://cr-buildbucket.appspot.com/build/8713425238679385265 Change-Id: I1a2d4575281646f2cb07c9ed3c2db7eedaaf7ac1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6604348 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.6@{#29} Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1} Cr-Branched-From: f6be482-refs/heads/main@{#99571}

Version incremented at https://cr-buildbucket.appspot.com/build/8712458304609471569 Change-Id: Ia69e0569012429a1bf0cbb91b9f78da5b4856f0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6632152 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.7@{#29} Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1} Cr-Branched-From: fa9b753-refs/heads/main@{#99927}

Reintroduce an SBXCHECK to ensure that we always suspend/return to the immediate parent stack. Returning should already be safe because the StackMemory chain lives outside of the sandbox, but suspending is still unsafe because it uses the in-sandbox WasmSuspenderObject chain which can be corrupted. This is a short-term fix. A more robust solution will be to move the WasmSuspenderObjects outside of the sandbox, like we did with the WasmContinuationObjects (https://crrev.com/c/6426203). [email protected] (cherry picked from commit 25e22b6) Change-Id: I4888a2ee6b14f93d40bc05ee58c2b9a95b95866e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6638773 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Thibaud Michaud <[email protected]> Cr-Commit-Position: refs/branch-heads/13.8@{#29} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}

Version incremented at https://cr-buildbucket.appspot.com/build/8708559961472278833 Change-Id: I581f290ef0114bf797ceb8848aed5ce22fd44682 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6778573 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.9@{#29} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}

…MacroAssembler Port commit 6a8fa0d Besides, port a missed commit 0523061 - [masm] Add quick check for RO values to write barrier (cherry picked from commit cae7aad) Bug: 453522647 Change-Id: Ie528544f39c46fbaf32ddbfade35cb82af14774f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7064952 Reviewed-by: Lutz Vahl <[email protected]> Auto-Submit: Zhao Jiazhong <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Lutz Vahl <[email protected]> Cr-Commit-Position: refs/branch-heads/14.2@{#29} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}

Version incremented at https://cr-buildbucket.appspot.com/build/8697958260937235905 Change-Id: Ia2f5dd746421a40f745a126c2c624ee7615c67f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7157625 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.3@{#29} Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1} Cr-Branched-From: 01af089-refs/heads/main@{#103352}

Version incremented at https://cr-buildbucket.appspot.com/build/8695159191812903585 Change-Id: Ic61ec9e845d569e16d3f56499420042b9ab2a63c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7272649 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.4@{#29} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}

Travis CI: Use flake8 to find Python syntax errors

c007036

Just 1.4% of the v8 codebase is Python but that code contains 118 Python 3 syntax errors and undefined names.

cclauss mentioned this pull request Dec 23, 2018

Dependency v8 is not Python 3 compatible nodejs/node#24512

Closed

cclauss added 2 commits March 19, 2019 07:39

Force a retest

58828aa

Force a retest

23d0bea

Force a retest

fa2b520

Merge remote-tracking branch 'upstream/master' into patch-1

c334b38

cclauss force-pushed the patch-1 branch from 923f45b to c334b38 Compare August 19, 2019 10:22

cclauss added 2 commits August 19, 2019 12:26

flake8 . --select=E9,F63,F7,F82

3388658

Xenial is now the Travis CI default Linux distro

cfa34f3

Update .travis.yml

5f63cd5

AgentJ08 mentioned this pull request Oct 3, 2019

Updated functions for python3 #35

Closed

cclauss closed this Oct 18, 2019

cclauss deleted the patch-1 branch October 18, 2019 14:57

Travis CI: Use flake8 to find Python syntax errors #29

Travis CI: Use flake8 to find Python syntax errors #29

Uh oh!

Conversation

cclauss commented Dec 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibrahimgorashi98 commented Dec 28, 2018

Uh oh!

bmsdave commented Feb 7, 2019

Uh oh!

cclauss commented Feb 12, 2019

Uh oh!

bmsdave commented Feb 19, 2019

Uh oh!

cclauss commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Mar 29, 2019

Uh oh!

bmsdave commented Apr 1, 2019

Uh oh!

cclauss commented Apr 19, 2019

Uh oh!

hayd commented Jul 2, 2019

Uh oh!

cclauss commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hayd commented Jul 3, 2019

Uh oh!

cclauss commented Jul 3, 2019

Uh oh!

cclauss commented Aug 19, 2019

Uh oh!

cclauss commented Oct 2, 2019

Uh oh!

bmsdave commented Oct 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cclauss commented Dec 23, 2018 •

edited

Loading

cclauss commented Feb 19, 2019 •

edited

Loading

cclauss commented Jul 3, 2019 •

edited

Loading