mirrored from https://chromium.googlesource.com/v8/v8.git
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Correct Comment. #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Correct Comment. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR. V8 is not accepting PRs on GitHub. Please use the Chromium Codereview tool. More information can be found at https://github.com/v8/v8/wiki/Contributing. Besides, I think in general patches that only correct comments are discouraged. |
hubot
pushed a commit
that referenced
this pull request
Feb 1, 2018
[email protected] Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I56b0cc38fd719c193b7af2c44cb6cb3206e43ba5 Reviewed-on: https://chromium-review.googlesource.com/897044 Reviewed-by: v8 autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6.5@{#22} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
hubot
pushed a commit
that referenced
this pull request
Mar 14, 2018
[email protected] Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib532493d117839789053375019e82b9b9eea4927 Reviewed-on: https://chromium-review.googlesource.com/962324 Reviewed-by: v8 autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6.6@{#22} Cr-Branched-From: d500271-refs/heads/6.6.346@{#1} Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
hubot
pushed a commit
that referenced
this pull request
Apr 18, 2018
R=[email protected] Change-Id: I6cfd5812675ef7700a1af2bf00ed4cceca0919d5 No-Try: true No-Presubmit: true No-Treechecks: true Bug: chromium:831989, chromium:824681 Originally-reviewed-on: https://chromium-review.googlesource.com/1009603 Reviewed-on: https://chromium-review.googlesource.com/1016280 Reviewed-by: Andreas Haas <[email protected]> Commit-Queue: Clemens Hammacher <[email protected]> Cr-Commit-Position: refs/branch-heads/6.7@{#22} Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2} Cr-Branched-From: e921be5-refs/heads/master@{#52547}
hubot
pushed a commit
that referenced
this pull request
Jun 8, 2018
[email protected] Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I44f31fc6c9ccb9398b6c5cf15c1156c7fffef1a0 Reviewed-on: https://chromium-review.googlesource.com/1093055 Reviewed-by: v8 autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6.8@{#22} Cr-Branched-From: 44d7d7d-refs/heads/6.8.275@{#1} Cr-Branched-From: 5754f66-refs/heads/master@{#53286}
hubot
pushed a commit
that referenced
this pull request
Aug 1, 2018
[email protected] Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic3ed2c966f18df8d047235e94c9ea25ebe6a506e Reviewed-on: https://chromium-review.googlesource.com/1159110 Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6.9@{#22} Cr-Branched-From: d7b61ab-refs/heads/6.9.427@{#1} Cr-Branched-From: b7e108d-refs/heads/master@{#54504}
peterwmwong
pushed a commit
to peterwmwong/v8
that referenced
this pull request
Dec 9, 2018
This reverts commit caed2cc. Reason for revert: Breaks layout tests, e.g. https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/14924/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: STDERR: STDERR: # STDERR: # Fatal error in ../../v8/src/base/platform/elapsed-timer.h, line 24 STDERR: # Debug check failed: !IsStarted(). STDERR: # STDERR: # STDERR: # STDERR: #FailureMessage Object: 0x7ffc46707640#0 0x565409263b6f base::debug::StackTrace::StackTrace() STDERR: #1 0x56540a8a32fb gin::(anonymous namespace)::PrintStackTrace() STDERR: #2 0x56540a8980d8 V8_Fatal() STDERR: #3 0x56540a897e35 v8::base::(anonymous namespace)::DefaultDcheckHandler() STDERR: v8#4 0x565407971f02 v8::base::ElapsedTimer::Start() STDERR: v8#5 0x565407d08edf v8::internal::TimedHistogram::Start() STDERR: v8#6 0x565407e500d5 v8::internal::IncrementalMarking::AdvanceIncrementalMarkingOnAllocation() STDERR: v8#7 0x565407e4f977 v8::internal::IncrementalMarking::Observer::Step() STDERR: v8#8 0x565407e48092 v8::internal::AllocationObserver::AllocationStep() STDERR: v8#9 0x565407eb0751 v8::internal::SpaceWithLinearArea::InlineAllocationStep() STDERR: v8#10 0x565407eb3e44 v8::internal::NewSpace::EnsureAllocation() STDERR: v8#11 0x565407e258ff v8::internal::NewSpace::AllocateRaw() STDERR: v8#12 0x565407e06b2d v8::internal::Heap::AllocateRaw() STDERR: v8#13 0x565407e432ef v8::internal::Heap::AllocateRawWithLightRetry() STDERR: v8#14 0x565407e433cf v8::internal::Heap::AllocateRawWithRetryOrFail() STDERR: v8#15 0x565407e04d48 v8::internal::Factory::NewFixedArrayWithFiller() STDERR: v8#16 0x565407fd6339 v8::internal::HashTable<>::New() STDERR: v8#17 0x565407fd7be8 v8::internal::HashTable<>::EnsureCapacity() STDERR: v8#18 0x565407fc7e95 v8::internal::Dictionary<>::Add() STDERR: v8#19 0x565407fcf453 v8::internal::BaseNameDictionary<>::Add() STDERR: v8#20 0x565407f89ee4 v8::internal::LookupIterator::ApplyTransitionToDataProperty() STDERR: v8#21 0x5654080036e2 v8::internal::Object::AddDataProperty() STDERR: v8#22 0x56540793061f v8::internal::(anonymous namespace)::DefineDataProperty() STDERR: v8#23 0x56540792da59 v8::internal::(anonymous namespace)::InstantiateObject() STDERR: v8#24 0x56540792b75a v8::internal::(anonymous namespace)::InstantiateFunction() STDERR: v8#25 0x56540792b4db v8::internal::ApiNatives::InstantiateFunction() STDERR: v8#26 0x5654079594bf v8::FunctionTemplate::GetFunction() STDERR: v8#27 0x56540a7af74e blink::V8ObjectConstructor::CreateInterfaceObject() STDERR: v8#28 0x56540a7afe01 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#29 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#30 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#31 0x56540a7afcb4 blink::V8PerContextData::CreateWrapperFromCacheSlowCase() STDERR: v8#32 0x56540a7aef73 blink::V8DOMWrapper::CreateWrapper() STDERR: v8#33 0x56540a7abf6b blink::ScriptWrappable::Wrap() STDERR: v8#34 0x56540a677199 blink::V8Document::documentElementAttributeGetterCallback() STDERR: v8#35 0x565407a0aec3 v8::internal::FunctionCallbackArguments::Call() STDERR: v8#36 0x565407a097be v8::internal::(anonymous namespace)::HandleApiCallHelper<>() STDERR: v8#37 0x565407a0877b v8::internal::Builtins::InvokeApiFunction() STDERR: v8#38 0x565407fe785a v8::internal::Object::GetPropertyWithAccessor() STDERR: v8#39 0x565407fe697e v8::internal::Object::GetProperty() STDERR: v8#40 0x565407ec8c71 v8::internal::LoadIC::Load() STDERR: v8#41 0x565407ed6401 v8::internal::__RT_impl_Runtime_LoadIC_Miss() STDERR: v8#42 0x5654087593f2 <unknown> STDERR: [16162:16185:1122/143518.356897:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ... Original change's description: > [heap] Improve embedder tracing during incremental marking > > Add a path into embedder tracing on allocation. This is safe as as Blink > is not allowed to call into V8 during object construction. > > Bug: chromium:843903 > Change-Id: I5af053c3169f5a33778ebce5d7c5c43e4efb1aa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1348749 > Commit-Queue: Michael Lippautz <[email protected]> > Reviewed-by: Ulan Degenbaev <[email protected]> > Cr-Commit-Position: refs/heads/master@{#57757} [email protected],[email protected] Change-Id: Ide2c0b284b52bee17573adcc89f14be4e40dab91 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843903 Reviewed-on: https://chromium-review.googlesource.com/c/1349189 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#57759}
junhuaw
pushed a commit
to junhuaw/v8
that referenced
this pull request
Feb 6, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iebdb2a08fce458a00e0db3682e50a177232d7e51 Reviewed-on: https://chromium-review.googlesource.com/c/1373909 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.2@{v8#22} Cr-Branched-From: 6acd03c-refs/heads/7.2.502@{#1} Cr-Branched-From: b03041d-refs/heads/master@{#57910}
Teemperor
pushed a commit
to Teemperor/v8
that referenced
this pull request
May 25, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Id78d219020dc7fe3eeef54a760c5c70ed55aa0b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532981 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.4@{v8#22} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
billti
pushed a commit
to billti/v8
that referenced
this pull request
Apr 6, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If63637b31694252eafbd836ca9da88965b482a07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060750 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.1@{v8#22} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}
palmer-dabbelt
pushed a commit
to palmer-dabbelt/v8
that referenced
this pull request
Jul 19, 2020
Add RISC-V support for gm.py-based builds
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Sep 2, 2020
…t closures (cherry picked from commit 26df3fd) Bug: chromium:1105318 Change-Id: I7b1c57b7ff7beaaa53c19a270d5a8c36b11baf17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301082 Reviewed-by: Sathya Gunasekaran <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#68903} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304717 Reviewed-by: Adam Klein <[email protected]> Cr-Commit-Position: refs/branch-heads/8.5@{v8#22} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ie20765ff61419da2bc05ea49b9a7fcaa6cfdf4ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1831188 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.8@{v8#22} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0514b941fc43ae41e59db029f1de8b7092c25ec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789602 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.7@{v8#22} Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1} Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I4d3b02b2135746756409df505d166a5d978d0225 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874836 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#22} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Merged: [turbofan] fix type widening bug in RedundancyElimination Revision: 3f7e99a Merged: [turbofan] fix type widening bug in RedundancyElimination, completely Revision: 69b195c BUG=chromium:1031909 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I938a5ad9c1b9f7bd345311f44d815f5e49dc08df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002388 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/branch-heads/8.0@{v8#22} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Revision: 97d130f NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected], [email protected], [email protected] Bug: v8:8828 Change-Id: I78aac8ea0fbd75dc4b826d5204cbef9724500234 Reviewed-on: https://chromium-review.googlesource.com/c/1470610 Reviewed-by: Michael Hablich <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/branch-heads/7.3@{v8#22} Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2} Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
PrepareElementsForSort must return a number less than or equal the array length. No-Try: true No-Presubmit: true No-Treechecks: true Bug: chromium:897512, v8:7382 Change-Id: If5f9c4d052e623ab9f3300b8534603abbee859fa Reviewed-on: https://chromium-review.googlesource.com/c/1297958 Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Camillo Bruni <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#56982} Reviewed-on: https://chromium-review.googlesource.com/c/1304318 Reviewed-by: Peter Marshall <[email protected]> Cr-Commit-Position: refs/branch-heads/7.1@{v8#22} Cr-Branched-From: f70aaa8-refs/heads/7.1.302@{#1} Cr-Branched-From: 1dbcc78-refs/heads/master@{#56462}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Registering shared wasm memory with the memory tracker was implemented to track which instances need to be upated across threads on grow. As the growing of memory when it is shared is behind a flag, the registering should also be gated by the flag so as to not create global handles that keep the memory alive. (cherry picked from commit ac30897) Bug: v8:9075 Tbr: [email protected] Change-Id: I379a19413befa281cd384c9167fbc22ba52f4c2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646882 Reviewed-by: Bill Budge <[email protected]> Commit-Queue: Deepti Gandluri <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#62043} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1673135 Reviewed-by: Adam Klein <[email protected]> Cr-Commit-Position: refs/branch-heads/7.6@{v8#22} Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1} Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Revision: 87b3416 BUG=chromium:958716 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I98dcd3eedaf36dde8fb6a427e682af8cdd49f71d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596741 Reviewed-by: Sigurd Schneider <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/branch-heads/7.5@{v8#22} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
This reverts commit 2966ed0. Reason for revert: broke presubmit check. Original change's description: > Merged: [torque] check FixedArray length > > (cherry picked from commit 85bc1b0) > > Bug: chromium:1086890 > TBR: [email protected] > No-Try: true > No-Presubmit: true > No-Tree-Checks: true > Change-Id: If08ae887bf47630f4db8fb2de9a2e241a43a716e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238571 > Commit-Queue: Tobias Tebbi <[email protected]> > Reviewed-by: Tobias Tebbi <[email protected]> > Cr-Commit-Position: refs/branch-heads/8.3@{v8#20} > Cr-Branched-From: 1668abd-refs/heads/8.3.110@{#1} > Cr-Branched-From: 04a7a68-refs/heads/master@{#66926} [email protected],[email protected] Change-Id: I6f0406c22e8ad877c93d672fe6ded8b1561f0e75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1086890 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239575 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/branch-heads/8.3@{v8#22} Cr-Branched-From: 1668abd-refs/heads/8.3.110@{#1} Cr-Branched-From: 04a7a68-refs/heads/master@{#66926}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
The lowering for anytrue was assuming that the input nodes are all integers. The regression test added in https://crrev.com/c/2194471 calls anytrue with float operands, this was causing the lowering to generate cmpl instructions with a float register and an immediate, which is wrong. The fix is to use GetReplacementsWithType on the input nodes, but only if the input were floats, since we use Word32Equal. Drive-by clean up of comments in the aforementioned regression test. (cherry picked from commit d16003d) [email protected] Bug: v8:10535,v8:10593 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I0a7699fe35e5cf7edb2984034b50f94a1ed494b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235924 Commit-Queue: Zhi An Ng <[email protected]> Reviewed-by: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/branch-heads/8.4@{v8#22} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Oct 28, 2020
With WebAssembly streaming compilation it is possible that FinishStream indirectly calls AbortStream. This had the effect that while FinishStream fulfilled the promise, AbortStream disposed the promise by removing the compile job from the wasm engine and thereby deallocated AsyncCompileJob and all the state that belongs to it. Without that state, FinishStream could not finish fulfilling the promise correctly. With this CL the streaming decoder remembers that the stream has already been finished. When the stream has been finished, all calls to Abort get ignored. The regression test for this issue requires the Chrome embedding, see https://crrev.com/c/2368359 R=[email protected] NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true (cherry picked from commit 32dd547) Bug: chromium:1117258 Change-Id: Ifc28a1ee38c228b051c4d7d85b305fe2a721fa1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367858 Commit-Queue: Andreas Haas <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#69549} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2465830 Cr-Commit-Position: refs/branch-heads/8.6@{v8#22} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Feb 6, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I6b3ef37f32c4309e33330b55c535ba8ee064f63a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2611523 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.8@{v8#22} Cr-Branched-From: 2dbcdc1-refs/heads/8.8.278@{#1} Cr-Branched-From: 366d30c-refs/heads/master@{#71094}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Apr 29, 2021
Merged: [mips64][wasm-simd] Retrieve the value of SupportsWasmSimd128() in builtin Revision: d7be571 Merged: [mips][wasm] Avoid duplicating parameter lists Revision: 1974111 Merged: [mips64] Fix TestFastJSWasmCall_MultipleArgs failure Revision: 33ece42 Merged: [mips] Skip all Simd tests on MIPS like PPC Revision: dc0a1b4 BUG= v8:11535 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: Ic7e0bece640bdfd6b78aa8a515c62a72b1d8034f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2738785 Reviewed-by: Deepti Gandluri <[email protected]> Reviewed-by: Zhao Jiazhong <[email protected]> Commit-Queue: Zhao Jiazhong <[email protected]> Cr-Commit-Position: refs/branch-heads/9.0@{v8#22} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jul 25, 2021
Revision: d4aafa4 [email protected] BUG=chromium:1198696 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: Ie78f892af33e0ac1a12736cd9c67934308415b9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2833912 Reviewed-by: Georg Neis <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/branch-heads/9.1@{v8#22} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
BenPope
pushed a commit
to BenPope/v8
that referenced
this pull request
Dec 10, 2021
Bug: chromium:1254189 (cherry picked from commit bdf31d5) Change-Id: I1d4426fee8392c7a680ad67af4bf2745d04b2e52 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268905 Commit-Queue: Nico Hartmann <[email protected]> Reviewed-by: Maya Lekova <[email protected]> Cr-Commit-Position: refs/branch-heads/9.6@{v8#22} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Revision: eadaef5 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:14008 Change-Id: I4f70ebaaf7633d32de9ffa671b9cf34256b53a48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4543311 Reviewed-by: Junliang Yan <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/branch-heads/11.3@{v8#22} Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1} Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
…"used" Revision: 970d907 BUG=681529 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review-Url: https://codereview.chromium.org/2653853003 Cr-Commit-Position: refs/branch-heads/5.7@{v8#22} Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 24, 2023
Bug: chromium:1452137 (cherry picked from commit e548943) Change-Id: I4be8b53f5668839515efefa566476d8e9c6182dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4637186 Auto-Submit: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/branch-heads/11.5@{v8#22} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit b947905) Bug: v8:7748, chromium:1466183 Change-Id: I6d7de33e0cec37747045269f441e65f7a482dd4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4701553 Auto-Submit: Manos Koukoutos <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#89060} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4714606 Commit-Queue: Manos Koukoutos <[email protected]> Cr-Commit-Position: refs/branch-heads/11.6@{v8#22} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Sep 3, 2023
The clone ic blindly copies the properties backing store, thus source and target map better have the same sized backing store. Bug: chromium:1476373 (cherry picked from commit d0dc4fc) Change-Id: I134f9ff42b637541674a2fad03208cb723244e85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4828324 Reviewed-by: Leszek Swirski <[email protected]> Auto-Submit: Olivier Flückiger <[email protected]> Commit-Queue: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/branch-heads/11.7@{v8#22} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Oct 1, 2023
The Assembler's {b} method is missing logic we need here, thus use the
MacroAssembler's {B} method instead.
Bug: chromium:1485829
(cherry picked from commit bd75ac3)
Change-Id: I69e131e45d28d64418bde227ace15b64684f6ae7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4902687
Commit-Queue: Matthias Liedtke <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Auto-Submit: Jakob Kummerow <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.8@{v8#22}
Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1}
Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Dec 17, 2023
When called on strings, SameValue can flatten ConsString, which allocates memory. Bug: v8:12783, chromium:1489500 (cherry picked from commit e5e3ce3) Change-Id: I4fc6f7fd4f421d5fc478fc6bccea7673b426791b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5110981 Reviewed-by: Matthias Liedtke <[email protected]> Auto-Submit: Darius Mercadier <[email protected]> Commit-Queue: Matthias Liedtke <[email protected]> Cr-Commit-Position: refs/branch-heads/12.1@{v8#22} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Dec 17, 2023
…ne() type (cherry picked from commit 949bbdf) Bug: chromium:1507106 Change-Id: Ic4ea57fe004cb417459231f4f9dc49a08d4fa94f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5126172 Reviewed-by: Andreas Haas <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Commit-Queue: Eva Herencsárová <[email protected]> Auto-Submit: Eva Herencsárová <[email protected]> Cr-Commit-Position: refs/branch-heads/12.0@{v8#22} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot
pushed a commit
that referenced
this pull request
Feb 1, 2024
…in register When constants should be used as Smi as FrameState input, we used to convert Int32Constant to tagged by using a BitcastWordToTagged, but a recent CL (https://crrev.com/c/5083021) made that more precise, generating a BitcastWordToTaggedSigned instead. When the Instruction Selector visits a BitcastWordToTagged, it emits a Nop with a DefineSameAsFirst (which seems to be some kind of GapMove). However, when it visits BitcastWordToTaggedSmi, it doesn't emit anything and just does a renaming. For a reason that's not clear to me, the register allocator does not want to spill registers holding constants that come from renamings, but is happy to spill registers holding constants coming from GapMoves. This lead to the register allocator running out of registers when allocating registers for FrameState inputs, because it was using one register per integer constant input and didn't want to spill any of them. This CL fixes the issue by adding a special case when generating frame states in the Instruction Selector: BitcastWordToTaggedSigned with Word32 constant inputs now lead to using a Constant rather than using the BitcastWordToTaggedSigned itself. Bug: v8:12783, chromium:1520697 (cherry picked from commit a5e2207) Change-Id: I5da8a10bc9ffd95511f2237488178fe8066ba65a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5250114 Commit-Queue: Nico Hartmann <[email protected]> Auto-Submit: Darius Mercadier <[email protected]> Reviewed-by: Nico Hartmann <[email protected]> Cr-Commit-Position: refs/branch-heads/12.2@{#22} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Crash occurred because JSPI initialization was not completed if OT only. Moved all of init code to bootstrap phase; guarded both by OT & non-heap serialization (during snapshot) tests. Bug: chromium:330543313 (cherry picked from commit 1e59b8f) Change-Id: Ib132f54d4fbef4075e3897dc11b3b5943b0496a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5388197 Reviewed-by: Adam Klein <[email protected]> Commit-Queue: Francis McCabe <[email protected]> Cr-Commit-Position: refs/branch-heads/12.3@{#22} Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1} Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Merged: [wasm] Correctly lookup WebAssembly object in InstallConditionalFeatures Revision: c63e4c4 Merged: [wasm] Don't load WebAssembly object in CanInstallTypeReflection Revision: 38e23f3 BUG=331358160 [email protected] Change-Id: I8ba7b04d6151dafdc298715aa499b7408cd4cef3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5447009 Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Commit-Position: refs/branch-heads/12.4@{#22} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
hubot
pushed a commit
that referenced
this pull request
May 22, 2024
In this case the ref is not the instance but a WasmApiFunctionRef, so the cast is invalid. Use the instance field instead. [email protected] Bug: 340102752 (cherry picked from commit 52d9e6d) Change-Id: I8639cf154645c46ee0be66b31a5dd63c165e1f53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5553793 Commit-Queue: Thibaud Michaud <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/branch-heads/12.5@{#22} Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1} Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Don't need to clear the upper halves of i32 values for sandbox reason on LoongArch64, MIPS64 and riscv64 platform, because we'll explicitly zero-extend their lower halves before using them for memory accesses. (cherry picked from commit 3c66d7e) Bug: 345271847 Change-Id: I39c6c59426685b8b28da9c4c686a77fe353c4437 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5599657 Auto-Submit: Zhao Jiazhong <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/branch-heads/12.6@{#22} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Jul 5, 2024
When creating a WasmFuncRef, we assumed that the callee was a regular JS function and used the generic wasm-to-js wrapper if the signature matched. However some import call kinds are not supported by the generic wrapper such as constructors. Recompute the import call kind and use the optimized wasm-to-js wrapper if needed. [email protected] Fixed: 348963663 (cherry picked from commit a055b94) Change-Id: I780314c8f9b8ee1789b657c24cbb96900a6f7aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5676702 Reviewed-by: Andreas Haas <[email protected]> Commit-Queue: Thibaud Michaud <[email protected]> Cr-Commit-Position: refs/branch-heads/12.7@{#22} Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1} Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot
pushed a commit
that referenced
this pull request
Aug 14, 2024
…Transition Fixed: chromium:354748997, chromium:355307958 (cherry picked from commit dbad3d1) Change-Id: I0b3580f062aa798dc2f8a81e588c0c8c86532e05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5784822 Reviewed-by: Shu-yu Guo <[email protected]> Auto-Submit: Deepti Gandluri <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#22} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Similar pattern to https://crrev.com/c/5826664 . (cherry picked from commit c42a07f) Fixed: 361862737 Change-Id: I59c3cea5d572423aa06583a1448bf7486213a233 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5829361 Reviewed-by: Jakob Kummerow <[email protected]> Auto-Submit: Matthias Liedtke <[email protected]> Commit-Queue: Matthias Liedtke <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#95899} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5835721 Reviewed-by: Manos Koukoutos <[email protected]> Commit-Queue: Eva Herencsárová <[email protected]> Cr-Commit-Position: refs/branch-heads/12.9@{#22} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Change-Id: I68343782de27dc13118b5412b2b3f6b4867a9de9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5889851 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.0@{#22} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Nov 26, 2024
`GetMemOp` returns an `Operand` which can contain `kScratchRegister`. We should hence not clobber that register until after the last use of the `Operand`. This CL changes the scratch register to `kScratchRegister2` which has much fewer uses, and in particular none which collides with `GetMemOp`. [email protected] Bug: 378779897 (cherry picked from commit 57a017e) Change-Id: Iafbfa2af7bed09b99fd427292f8f7cea8e6c63dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6050017 Reviewed-by: Matthias Liedtke <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/branch-heads/13.1@{#22} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Those relative types were leaking from the type canonicalizer, which leads to type confusion in callers. This CL fully removes the concept of relative type indexes (and thus removes the `CanonicalRelativeField` bit from the bitfield in `ValueTypeBase`). During canonicalization we pass the start and end of the recursion group into hashing and equality checking, and use this to compute relative indexes within the recursion group on demand. The stored version will always have absolute indexes though. [email protected] Bug: 379009132 (cherry picked from commit 20d9a7f) Change-Id: I9bee6b37b9da36684f8c5b2866725eac79c896ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6049645 Commit-Queue: Clemens Backes <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/branch-heads/13.2@{#22} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Jan 20, 2025
This reverts commit 59c055b. Reason for revert: scope reuse machinery is still causing issues in the wild. Bug: 390160291 Original change's description: > [scopes] Remove always-on reuse_scope_info flag > > It's stable now. > > Change-Id: Ib5b35e78744cccd289baaa54205799e6281feaf3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6089131 > Commit-Queue: Patrick Thier <[email protected]> > Auto-Submit: Toon Verwaest <[email protected]> > Commit-Queue: Toon Verwaest <[email protected]> > Reviewed-by: Patrick Thier <[email protected]> > Cr-Commit-Position: refs/heads/main@{#97686} Bug: 390609213 (cherry picked from commit ac8996c) Change-Id: I9ee56dcc85b3299da62ba6c723c65fac62484159 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6182063 Commit-Queue: Igor Sheludko <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/branch-heads/13.3@{#22} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Feb 21, 2025
…odule This CL adds one suspend point in any scope that has at least one `await using` in it. Bug: 396661138 Fixed: 397716171 (cherry picked from commit b80573f) Change-Id: I3872d835b98869da70ef5d3d41c468b1b9899b85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6292399 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]> Cr-Commit-Position: refs/branch-heads/13.4@{#22} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot
pushed a commit
that referenced
this pull request
May 29, 2025
Bug: 420636529 (cherry picked from commit 7bc0a67) Change-Id: I4c905332ac397328100d696662e243946fa38a25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6599190 Reviewed-by: Deepti Gandluri <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Auto-Submit: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/branch-heads/13.6@{#22} Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1} Cr-Branched-From: f6be482-refs/heads/main@{#99571}
hubot
pushed a commit
that referenced
this pull request
May 29, 2025
... when a known type range contains only positive values. Bug: 420637585 (cherry picked from commit 45eb42c) Change-Id: I6d367f3474d71d9b8f81d9b1e42d587d8076c85f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6604642 Commit-Queue: Shu-yu Guo <[email protected]> Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]> Auto-Submit: Shu-yu Guo <[email protected]> Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Cr-Commit-Position: refs/branch-heads/13.7@{#22} Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1} Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot
pushed a commit
that referenced
this pull request
Jun 6, 2025
For indexed types, the non-index bits also need to be equal. Bug: 422313191 (cherry picked from commit a970eed) Change-Id: Ideb10405312ebf647a277b1b6bbaa09327638527 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6624362 Reviewed-by: Thibaud Michaud <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/branch-heads/13.8@{#22} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Jul 18, 2025
After checking that the trusted_function_data_offset is actually a code object we must use the correct tag to reload it. This prevents its type to change between the double fetches. Bug: 429703123 (cherry picked from commit ebf22f9) Change-Id: I1193fa180b659dc888d7aa484f386faca815dacc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6769984 Commit-Queue: Olivier Flückiger <[email protected]> Commit-Queue: Samuel Groß <[email protected]> Auto-Submit: Olivier Flückiger <[email protected]> Reviewed-by: Samuel Groß <[email protected]> Cr-Commit-Position: refs/branch-heads/13.9@{#22} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot
pushed a commit
that referenced
this pull request
Sep 22, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8703007152131399217 Change-Id: Ie4a7ab75ca1868d489da2f92d5c57d6f9c79922e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973242 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.1@{#22} Cr-Branched-From: 1f4839b-refs/heads/14.1.146@{#1} Cr-Branched-From: cd6944c-refs/heads/main@{#102149}
hubot
pushed a commit
that referenced
this pull request
Oct 21, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8700414570493537825 Change-Id: I2adf36c25e8073f3d9b70cdb42c2feebbc750286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7064513 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#22} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot
pushed a commit
that referenced
this pull request
Nov 12, 2025
Bug: 457866804 Change-Id: I6c7a9330a5af5a9958ef4c0fc8b3e3e32d168921 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7137458 Reviewed-by: Jakob Linke <[email protected]> Auto-Submit: Jakob Linke <[email protected]> Reviewed-by: Victor Gomes <[email protected]> Commit-Queue: Jakob Linke <[email protected]> Cr-Commit-Position: refs/branch-heads/14.3@{#22} Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1} Cr-Branched-From: 01af089-refs/heads/main@{#103352}
hubot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Flip a condition: We want to delete all jobs which *do* match the context. Plus a simplification in `DeleteCompileJobsOnIsolate` which does not change semantics. [email protected] (cherry picked from commit 3d3e6a1) Bug: 466758185 Fixed: 468996868 Change-Id: Iaa296bb1c152190fe5adccab758774b87c299596 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7260276 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/branch-heads/14.4@{#22} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.