Skip to content

Conversation

@shecenon
Copy link

Performance and stability improvements on all platforms.

Cr-Commit-Position: refs/heads/4.4.17@{#1}
Cr-Branched-From: 2b16f54-refs/heads/master@{#27802}

Performance and stability improvements on all platforms.

Cr-Commit-Position: refs/heads/4.4.17@{#1}
Cr-Branched-From: 2b16f54-refs/heads/master@{#27802}
@shecenon shecenon closed this Jul 28, 2017
hubot pushed a commit that referenced this pull request Sep 12, 2017
The Typer put the wrong type on String#index and String#lastIndexOf
builtins, with an off by one on the upper bound.

Bug: chromium:762874
Change-Id: Ia4c29bc2e8e1c85b6a7ae0b99f8aaabf839a5932
Reviewed-on: https://chromium-review.googlesource.com/660000
Reviewed-by: Jaroslav Sevcik <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#47942}(cherry picked from commit b8f144e)
Reviewed-on: https://chromium-review.googlesource.com/663338
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.2@{#15}
Cr-Branched-From: efa2ac4-refs/heads/6.2.414@{#1}
Cr-Branched-From: a861ebb-refs/heads/master@{#47693}
hubot pushed a commit that referenced this pull request Oct 17, 2017
[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I11f567e375bacb9c2774b2ecd9efb5792426021c
Reviewed-on: https://chromium-review.googlesource.com/721943
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#15}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
dothebart pushed a commit to arangodb-helper/v8 that referenced this pull request Oct 27, 2017
Cr-Commit-Position: refs/branch-heads/5.7@{v8#15}
Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1}
Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
hubot pushed a commit that referenced this pull request Dec 15, 2017
[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ibd213f0501e2df992095f701ad96d08b5f9a611e
Reviewed-on: https://chromium-review.googlesource.com/828715
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.4@{#15}
Cr-Branched-From: 0407506-refs/heads/6.4.388@{#1}
Cr-Branched-From: a5fc4e0-refs/heads/master@{#49724}
hubot pushed a commit that referenced this pull request Jan 31, 2018
… it exists

Revision: 3121ffe

BUG=chromium:805346
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I45db1efbb28877a8b93d92e96d19d8681e2a563c
Reviewed-on: https://chromium-review.googlesource.com/894525
Reviewed-by: Clemens Hammacher <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.5@{#15}
Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1}
Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
hubot pushed a commit that referenced this pull request Mar 12, 2018
…operties

Revision: 0d26307

BUG=chromium:817499
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I6e3222443d66c8adad154896bde9f22569a8455e
Reviewed-on: https://chromium-review.googlesource.com/958469
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.6@{#15}
Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
hubot pushed a commit that referenced this pull request Apr 16, 2018
[email protected]

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I974ff0190812a9472908b7a4cea8c6df566a2570
Reviewed-on: https://chromium-review.googlesource.com/1013610
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.7@{#15}
Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5-refs/heads/master@{#52547}
dumganhar pushed a commit to dumganhar/v8_fork that referenced this pull request Jun 5, 2018
Revision: c68df41

BUG=chromium:716265,v8:6322
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=mythria

Change-Id: I25535df4ea5cddefed44aae8e55625bd6dcaaf1c
Reviewed-on: https://chromium-review.googlesource.com/521083
Reviewed-by: Mythri Alle <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.0@{v8#15}
Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{#1}
Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}
hubot pushed a commit that referenced this pull request Jun 6, 2018
This is a combined merge of two CLs:

[builtins] Convert double to integer in Date.prototype.setDate
https://crrev.com/c/1080110

[date] Fix double-to-int conversion in MakeDay
https://crrev.com/c/1087063

No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: v8:7475,chromium:846723
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I3aa725e7ce1822345502284aec919695c4ca084d
Reviewed-on: https://chromium-review.googlesource.com/1080110
Commit-Queue: Jakob Gruber <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#53516}(cherry picked from commit 10cfe81)
Reviewed-on: https://chromium-review.googlesource.com/1088790
Cr-Commit-Position: refs/branch-heads/6.8@{#15}
Cr-Branched-From: 44d7d7d-refs/heads/6.8.275@{#1}
Cr-Branched-From: 5754f66-refs/heads/master@{#53286}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jul 4, 2018
This reverts commit 52a10e5.

Reason for revert: https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/12434/layout-test-results/results.html

Crash e.g. in http/tests/devtools/oopif/oopif-performance-cpu-profiles.js

crash log for devtools (pid <unknown>):
STDOUT: <empty>
STDERR: 
STDERR: 
STDERR: #
STDERR: # Fatal error in ../../v8/src/compilation-dependencies.cc, line 281
STDERR: # Debug check failed: descriptor == owner->LastAdded() (10 vs. 22).
STDERR: #
STDERR: #
STDERR: #
STDERR: #FailureMessage Object: 0x7fff86878630#0 0x0000031c642c base::debug::StackTrace::StackTrace()
STDERR: #1 0x0000046a56bb gin::(anonymous namespace)::PrintStackTrace()
STDERR: v8#2 0x00000469c528 V8_Fatal()
STDERR: v8#3 0x00000469c285 v8::base::(anonymous namespace)::DefaultDcheckHandler()
STDERR: v8#4 0x000001cc5253 v8::internal::CompilationDependencies::DependOnFieldType()
STDERR: v8#5 0x000001cdcc46 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfo()
STDERR: v8#6 0x000001cde661 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfos()
STDERR: v8#7 0x000001dd982b v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccess()
STDERR: v8#8 0x000001ddb715 v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccessFromNexus()
STDERR: v8#9 0x000001dd656d v8::internal::compiler::JSNativeContextSpecialization::ReduceJSLoadNamed()
STDERR: v8#10 0x000001d53872 v8::internal::compiler::GraphReducer::Reduce()
STDERR: v8#11 0x000001d534a5 v8::internal::compiler::GraphReducer::ReduceTop()
STDERR: v8#12 0x000001d52e58 v8::internal::compiler::GraphReducer::ReduceNode()
STDERR: v8#13 0x000001e4c201 v8::internal::compiler::InliningPhase::Run()
STDERR: v8#14 0x000001e44f79 v8::internal::compiler::PipelineImpl::Run<>()
STDERR: v8#15 0x000001e41058 v8::internal::compiler::PipelineImpl::CreateGraph()
STDERR: v8#16 0x000001e40c75 v8::internal::compiler::PipelineCompilationJob::PrepareJobImpl()
STDERR: v8#17 0x000001ccd437 v8::internal::OptimizedCompilationJob::PrepareJob()
STDERR: v8#18 0x000001cd071e v8::internal::(anonymous namespace)::GetOptimizedCode()
STDERR: v8#19 0x000001cd0c6f v8::internal::Compiler::CompileOptimized()
STDERR: v8#20 0x00000231fb62 v8::internal::__RT_impl_Runtime_CompileOptimized_Concurrent()
STDERR: v8#21 0x00000288e535 <unknown>

Original change's description:
> [turbofan] Rewrite CompilationDependencies
> 
> Instead of installing code dependencies during graph reduction,
> install them after code generation.
> 
> Bug: v8:7902, v8:7790
> Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a
> Reviewed-on: https://chromium-review.googlesource.com/1119913
> Commit-Queue: Georg Neis <[email protected]>
> Reviewed-by: Jaroslav Sevcik <[email protected]>
> Reviewed-by: Michael Starzinger <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#54170}

[email protected],[email protected],[email protected]

Change-Id: Ic58c2bfadbd34bb6ba7dc0d2b74871cc90b0a74f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7902, v8:7790
Reviewed-on: https://chromium-review.googlesource.com/1125680
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#54192}
hubot pushed a commit that referenced this pull request Jul 30, 2018
Revision: d27aaa7

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I905cdadea788aea2ea29555fd07f2f5730f48697
Reviewed-on: https://chromium-review.googlesource.com/1155099
Reviewed-by: Muntasir Mallick <[email protected]>
Commit-Queue: Junliang Yan <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.9@{#15}
Cr-Branched-From: d7b61ab-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d-refs/heads/master@{#54504}
peterwmwong pushed a commit to peterwmwong/v8 that referenced this pull request Dec 9, 2018
This reverts commit caed2cc.

Reason for revert: Breaks layout tests, e.g.

https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/14924/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: 
STDERR: 
STDERR: #
STDERR: # Fatal error in ../../v8/src/base/platform/elapsed-timer.h, line 24
STDERR: # Debug check failed: !IsStarted().
STDERR: #
STDERR: #
STDERR: #
STDERR: #FailureMessage Object: 0x7ffc46707640#0 0x565409263b6f base::debug::StackTrace::StackTrace()
STDERR: #1 0x56540a8a32fb gin::(anonymous namespace)::PrintStackTrace()
STDERR: #2 0x56540a8980d8 V8_Fatal()
STDERR: #3 0x56540a897e35 v8::base::(anonymous namespace)::DefaultDcheckHandler()
STDERR: v8#4 0x565407971f02 v8::base::ElapsedTimer::Start()
STDERR: v8#5 0x565407d08edf v8::internal::TimedHistogram::Start()
STDERR: v8#6 0x565407e500d5 v8::internal::IncrementalMarking::AdvanceIncrementalMarkingOnAllocation()
STDERR: v8#7 0x565407e4f977 v8::internal::IncrementalMarking::Observer::Step()
STDERR: v8#8 0x565407e48092 v8::internal::AllocationObserver::AllocationStep()
STDERR: v8#9 0x565407eb0751 v8::internal::SpaceWithLinearArea::InlineAllocationStep()
STDERR: v8#10 0x565407eb3e44 v8::internal::NewSpace::EnsureAllocation()
STDERR: v8#11 0x565407e258ff v8::internal::NewSpace::AllocateRaw()
STDERR: v8#12 0x565407e06b2d v8::internal::Heap::AllocateRaw()
STDERR: v8#13 0x565407e432ef v8::internal::Heap::AllocateRawWithLightRetry()
STDERR: v8#14 0x565407e433cf v8::internal::Heap::AllocateRawWithRetryOrFail()
STDERR: v8#15 0x565407e04d48 v8::internal::Factory::NewFixedArrayWithFiller()
STDERR: v8#16 0x565407fd6339 v8::internal::HashTable<>::New()
STDERR: v8#17 0x565407fd7be8 v8::internal::HashTable<>::EnsureCapacity()
STDERR: v8#18 0x565407fc7e95 v8::internal::Dictionary<>::Add()
STDERR: v8#19 0x565407fcf453 v8::internal::BaseNameDictionary<>::Add()
STDERR: v8#20 0x565407f89ee4 v8::internal::LookupIterator::ApplyTransitionToDataProperty()
STDERR: v8#21 0x5654080036e2 v8::internal::Object::AddDataProperty()
STDERR: v8#22 0x56540793061f v8::internal::(anonymous namespace)::DefineDataProperty()
STDERR: v8#23 0x56540792da59 v8::internal::(anonymous namespace)::InstantiateObject()
STDERR: v8#24 0x56540792b75a v8::internal::(anonymous namespace)::InstantiateFunction()
STDERR: v8#25 0x56540792b4db v8::internal::ApiNatives::InstantiateFunction()
STDERR: v8#26 0x5654079594bf v8::FunctionTemplate::GetFunction()
STDERR: v8#27 0x56540a7af74e blink::V8ObjectConstructor::CreateInterfaceObject()
STDERR: v8#28 0x56540a7afe01 blink::V8PerContextData::ConstructorForTypeSlowCase()
STDERR: v8#29 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase()
STDERR: v8#30 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase()
STDERR: v8#31 0x56540a7afcb4 blink::V8PerContextData::CreateWrapperFromCacheSlowCase()
STDERR: v8#32 0x56540a7aef73 blink::V8DOMWrapper::CreateWrapper()
STDERR: v8#33 0x56540a7abf6b blink::ScriptWrappable::Wrap()
STDERR: v8#34 0x56540a677199 blink::V8Document::documentElementAttributeGetterCallback()
STDERR: v8#35 0x565407a0aec3 v8::internal::FunctionCallbackArguments::Call()
STDERR: v8#36 0x565407a097be v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
STDERR: v8#37 0x565407a0877b v8::internal::Builtins::InvokeApiFunction()
STDERR: v8#38 0x565407fe785a v8::internal::Object::GetPropertyWithAccessor()
STDERR: v8#39 0x565407fe697e v8::internal::Object::GetProperty()
STDERR: v8#40 0x565407ec8c71 v8::internal::LoadIC::Load()
STDERR: v8#41 0x565407ed6401 v8::internal::__RT_impl_Runtime_LoadIC_Miss()
STDERR: v8#42 0x5654087593f2 <unknown>
STDERR: [16162:16185:1122/143518.356897:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ...


Original change's description:
> [heap] Improve embedder tracing during incremental marking
> 
> Add a path into embedder tracing on allocation. This is safe as as Blink
> is not allowed to call into V8 during object construction.
> 
> Bug: chromium:843903
> Change-Id: I5af053c3169f5a33778ebce5d7c5c43e4efb1aa4
> Reviewed-on: https://chromium-review.googlesource.com/c/1348749
> Commit-Queue: Michael Lippautz <[email protected]>
> Reviewed-by: Ulan Degenbaev <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#57757}

[email protected],[email protected]

Change-Id: Ide2c0b284b52bee17573adcc89f14be4e40dab91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:843903
Reviewed-on: https://chromium-review.googlesource.com/c/1349189
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#57759}
junhuaw pushed a commit to junhuaw/v8 that referenced this pull request Feb 6, 2019
If we create a second foreground task, only the second one will be
registered with the AsyncCompileJob, so the first one will not be
cancelled, which can lead to use-after-free of the AsyncCompileJob.
In a debug build, a DCHECK will fail when creating the second
foreground task.

R=​[email protected]

Bug: chromium:907937, chromium:910920
Change-Id: I1a32b544d7ac8ae4a71c17b1051ce03034895ce8
Originally-reviewed-on: https://chromium-review.googlesource.com/c/1367684
No-Try: true
No-Presubmit: true
No-Treechecks: true
Reviewed-on: https://chromium-review.googlesource.com/c/1369953
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Clemens Hammacher <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.2@{v8#15}
Cr-Branched-From: 6acd03c-refs/heads/7.2.502@{#1}
Cr-Branched-From: b03041d-refs/heads/master@{#57910}
joyeecheung pushed a commit to joyeecheung/v8 that referenced this pull request May 9, 2019
Improve code generation for stores with write barriers slightly by using the
assembler's dedicated scratch registers (x16 and x17 on Arm64, ip on Arm)
instead of allocating temporaries.

To do this, we've done two things:

  - Use ip as a scratch register when loading page flags.

  - TurboAssembler::CallRecordWriteStub() now takes the offset of the slot
    that's written to rather than its address, removing the need to allocate a
    temporary register for it.

In essence, we've gone from:

```
;; Do the store.
stur x19, [x9, v8#15]
;; Check *destination* object page flags and jump out-of-line.
and x4, x9, #0xfffffffffff80000
ldr x4, [x4, v8#8]
tbnz x4, v8#2, #+0x1e7c
|     ;; Check *source* object page flags.
| `-> and x4, x19, #0xfffffffffff80000
|     ldr x4, [xM, v8#8]
|,--- tbz x4, #1, #-0x1e80
|     ;; Compute address of slot.
|     add x5, x9, #0xf (15)
|     ;; Setup arguments to RecordWrite
|     stp x2, x3, [sp, #-32]!
|     stp x4, lr, [sp, v8#16]
|     stp x0, x1, [sp, #-16]!
|     mov x0, x9 ;; Object address in x9
|     mov x1, x5 ;; Slot address in x5
|     movz x2, #0x0
|     movz x3, #0x100000000
|     ;; Call RecordWrite
|     ldr x16, pc+2056
|     blr x16
```

Which allocates x4 and x5 as temporaries.

To:

```
stur x19, [x9, v8#15]
and x16, x9, #0xfffffffffff80000 ;; Using x16 instead of allocating x4.
ldr x16, [x16, v8#8]
tbnz x16, v8#2, #+0x1e7c
| `-> and x16, x19, #0xfffffffffff80000
|     ldr x16, [xM, v8#8]
|,--- tbz x16, #1, #-0x1e80
|     stp x2, x3, [sp, #-32]!
|     stp x4, lr, [sp, v8#16]
|     stp x0, x1, [sp, #-16]!
|     mov x0, x9            ;; Object address still in x9.
|     add x1, x9, #0xf (15) ;; Compute the slot address directly.
|     movz x2, #0x0
|     movz x3, #0x100000000
|     ldr x16, pc+2056
|     blr x16
```

Finally, `RecordWriteField()` does not need an extra scratch register anymore.

Change-Id: Icb71310e7b8ab1ca83ced250851456166b337d00
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505793
Commit-Queue: Pierre Langlois <[email protected]>
Reviewed-by: Sigurd Schneider <[email protected]>
Reviewed-by: Ulan Degenbaev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#61153}
Teemperor pushed a commit to Teemperor/v8 that referenced this pull request May 25, 2019
Revision: 4c7cabb

BUG=chromium:940003
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Idbe4357696886da3c56fb2d20e7a9add3f831379
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522989
Reviewed-by: Ulan Degenbaev <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.4@{v8#15}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
backwardn pushed a commit to backwardn/v8 that referenced this pull request Nov 10, 2019
Code from ARES-6 Basic:

  ldur w11, [x5, v8#15]
  asr w11, w11, #1
  sxtw x11, w11

With this CL:

  ldur w11, [x5, v8#15]
  sbfx x11, x11, #1, v8#31

This increases performance of Ares6 Basic by ~2% on Cortex-A53.
Also reduces the snapshot by ~2000 instructions.

Change-Id: Ie9801da730f832337306422d2a9c63461d9e5690
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849530
Reviewed-by: Michael Starzinger <[email protected]>
Commit-Queue: Martyn Capewell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#64235}
billti pushed a commit to billti/v8 that referenced this pull request Dec 20, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I1e7efa3ae671d66a64b0c0dc4a6835636975fe84
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1971710
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.0@{v8#15}
Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2}
Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
billti pushed a commit to billti/v8 that referenced this pull request Apr 6, 2020
Revision: a2e971c

BUG=chromium:1051017
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Iabda50b698a19ceec61812f37c1384e5605ea78f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056856
Reviewed-by: Georg Neis <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.1@{v8#15}
Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1}
Cr-Branched-From: f22c213-refs/heads/master@{#66031}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Sep 2, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ia8cc27fd3bd9a62509b0f7e1f7530ffe437dff98
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2283238
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#15}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Revision: 6f17f5d

BUG=chromium:1000094,v8:8510
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Iffa509777aee4ffa05960b2784b47afe7b439b5e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1820940
Reviewed-by: Mythri Alle <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.8@{v8#15}
Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1}
Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic1f4bcd78dd4cc9169301f9d73128343b08d40ff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771338
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.7@{v8#15}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
…scriptors on AIX."

This reverts commit 539cefa.

Reason for revert: Waiting for LGTM from hablich@

Original change's description:
> Merged: PPC: allow for calling CFunctions without function descriptors on AIX.
> 
> Revision: 07ee86a
> 
> BUG=v8:9766
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​[email protected]
> 
> Change-Id: I4b9d625917280bef2f7c0a4d1c6dec262b1a0ec9
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866813
> Reviewed-by: Michael Starzinger <[email protected]>
> Commit-Queue: Milad Farazmand <[email protected]>
> Cr-Commit-Position: refs/branch-heads/7.9@{v8#13}
> Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
> Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}

[email protected],[email protected],[email protected],[email protected],[email protected]

Change-Id: I2e26c400a21f25d98a81956055de16cc93d103ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9766
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871754
Reviewed-by: Milad Farazmand <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.9@{v8#15}
Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie9303c00fe732cdbde8a9ebb77f0166b0be8d7ec
Reviewed-on: https://chromium-review.googlesource.com/c/1456300
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{v8#15}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I262b91cf58eda0bc56ecdd522bff612279090689
Reviewed-on: https://chromium-review.googlesource.com/c/1298392
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.1@{v8#15}
Cr-Branched-From: f70aaa8-refs/heads/7.1.302@{#1}
Cr-Branched-From: 1dbcc78-refs/heads/master@{#56462}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ibf719cc6d80bb5e56436a0b84aa73747ebbf9cd8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1663558
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.6@{v8#15}
Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1}
Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I25ba47df139733d671ddc537b0638189f3b709fb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588734
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.5@{v8#15}
Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1}
Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ieffb3aeffc1aee5519af87d6329826f4a7c9ba82
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2166255
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.3@{v8#15}
Cr-Branched-From: 1668abd-refs/heads/8.3.110@{#1}
Cr-Branched-From: 04a7a68-refs/heads/master@{#66926}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I36e0cbf7e2f9e03ba1089b15f8fc78ad57bd3149
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213984
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{v8#15}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 13, 2023
Change-Id: I57b3e40df00ed56c6640cda1a0b405c4f7ff3643
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4604845
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#15}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 12, 2023
Change-Id: If7556eeb06c8e84f87695aceef99bfe5d9b699a5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4670834
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.6@{v8#15}
Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3}
Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 3, 2023
Change-Id: I014b0843740230555775ffc536cbc5596ef5a5d7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4815812
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.7@{v8#15}
Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Oct 1, 2023
Change-Id: Ide8a9f9b5691d2b788266f896e1ebbc0b6cea2c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4885220
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.8@{v8#15}
Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1}
Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Nov 21, 2023
Change-Id: Ifd26ddcf16ab40b398eaa9e1092e5058306a3791
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5049251
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.0@{v8#15}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Dec 10, 2023
Change-Id: I92c1627782e72e758d5cc2695dbd1271e022b98f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5104628
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#15}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Mar 8, 2024
Change-Id: I8e03bc808a3e17d56d0766a3e055b1a684c64096
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5355588
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.3@{#15}
Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1}
Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot pushed a commit that referenced this pull request Mar 28, 2024
Change-Id: Id34c1ba30c9816a0da89339cb7953a518b8df86a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5403013
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.4@{#15}
Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1}
Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
probablytom pushed a commit to probablytom/v8 that referenced this pull request Apr 11, 2024
Change-Id: I68013b3eec8d254a6171925455da4fa59505b99f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5241101
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.2@{v8#15}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request May 13, 2024
Change-Id: I5b4b87233aedcd08789eec94036a1549e8c9ea7f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5534418
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.5@{#15}
Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1}
Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot pushed a commit that referenced this pull request May 22, 2024
Change-Id: Ib3760c9df78e4b5966423da34848c931d69be399
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5559665
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.6@{#15}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Jun 24, 2024
Change-Id: I8e10f1c144dcc42f916de37df5a1e76a3142349e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5648936
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.7@{#15}
Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1}
Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot pushed a commit that referenced this pull request Aug 7, 2024
Change-Id: I348997e241d8a48ccc3a52bb204b4f5dc2b8ddd8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5768793
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.8@{#15}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Aug 30, 2024
Change-Id: If57569b1de9023c3a1b95d49bf2bb154d202b27d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5827185
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.9@{#15}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Sep 23, 2024
Change-Id: I86512df5d7a0ce62770fde92805ec562121217aa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5882613
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.0@{#15}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Nov 11, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8731547652191656449

Change-Id: Iab461ce83da26ea2370bf2a76a5216296418fbfa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6012004
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.1@{#15}
Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1}
Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot pushed a commit that referenced this pull request Nov 19, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8730825329174627281

Change-Id: I2ef218bd539847496ef35e39573939e1ef4430e5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6032401
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.2@{#15}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Jan 14, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8725777380342066177

Change-Id: I4c326bb8e7aa311a22b53bd1f85ff8a88c8b1592
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6174346
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.3@{#15}
Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1}
Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot pushed a commit that referenced this pull request Feb 11, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8723218771604711409

Change-Id: I470681644820e013781d8fc42943dae767749a57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6253742
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.4@{#15}
Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1}
Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot pushed a commit that referenced this pull request Mar 14, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8720410831125245761

Change-Id: I3327c82b0ff5ff416444d4b655796f3d8299c1e0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6354228
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.5@{#15}
Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1}
Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
digitalhurricane-io pushed a commit to digitalhurricane-io/v8 that referenced this pull request Apr 2, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8720410831125245761

Change-Id: I3327c82b0ff5ff416444d4b655796f3d8299c1e0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6354228
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.5@{v8#15}
Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1}
Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
hubot pushed a commit that referenced this pull request Apr 22, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8716874341200623281

Change-Id: Icc866b658723249bbd423027c321f88d07563644
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6479714
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.6@{#15}
Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1}
Cr-Branched-From: f6be482-refs/heads/main@{#99571}
hubot pushed a commit that referenced this pull request May 15, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8714791743309668641

Change-Id: I3e2c2c3e11a26733dd3c754d93deb51b60150a97
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6551882
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.7@{#15}
Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1}
Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot pushed a commit that referenced this pull request May 30, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8713445810978959089

Change-Id: If9e5aca1f857be8f615faac77517afab8e181e76
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6605996
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.8@{#15}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Jul 8, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8709925364168713777

Change-Id: Icae724dddef7f84e5682409d15bb77f81e329d0b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6713924
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.9@{#15}
Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1}
Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot pushed a commit that referenced this pull request Sep 16, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8703544885293434369

Change-Id: I411e205ebb44dd087e36106201b06d5a9ac3ea81
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6956547
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.0@{#15}
Cr-Branched-From: 4ec2f43-refs/heads/14.0.365@{#1}
Cr-Branched-From: a88b570-refs/heads/main@{#101731}
hubot pushed a commit that referenced this pull request Sep 19, 2025
IsAnyHole and SafeIsAnyHole need to DCHECK and actual check
(respectively) whether the value they are checking is in the main cage,
in order for the hole value range check to actually be valid.

However, the range check is cheaper than the cage check, and most things
aren't holes. So, we can do the cage check only if the range check is
successful, under the assumption that most things won't be holes.

This should speed up heap verification, which has to check every heap
object for hole-ness. There's another hole check in there which checked
for RO space, for which I've done a similar trick.

Bug: 434179415
(cherry picked from commit 7934170)

Change-Id: Ic4395a38e6a14da23ff7b25717f6e8d414a589ec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6965030
Reviewed-by: Jakob Kummerow <[email protected]>
Auto-Submit: Leszek Swirski <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.1@{#15}
Cr-Branched-From: 1f4839b-refs/heads/14.1.146@{#1}
Cr-Branched-From: cd6944c-refs/heads/main@{#102149}
hubot pushed a commit that referenced this pull request Oct 17, 2025
This e.g. allows us to optimize the access of `x` even though there's
a conditional labeled break. Not `y` though due to the condition:

```
  lbl: {
    x;
    if (a) break lbl;
    y;
  }
  x; y;
```

Bug: 449760249
(cherry picked from commit b371b4f)

Change-Id: Ib79884655ae589cdfeca78d280885a90b60474a2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7054723
Auto-Submit: Toon Verwaest <[email protected]>
Commit-Queue: Leszek Swirski <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.2@{#15}
Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1}
Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot pushed a commit that referenced this pull request Nov 10, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8698547517914707041

Change-Id: I8aa2c0944ea883d0924a007d381eaacec183d22b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7139659
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.3@{#15}
Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1}
Cr-Branched-From: 01af089-refs/heads/main@{#103352}
hubot pushed a commit that referenced this pull request Dec 10, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8695879058884042401

Change-Id: I557503fdd95bf791e3d2ce4c27445cff05172f7c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7246190
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.4@{#15}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant