Skip to content

[platform] fix uninitialized variable #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bryonglodencissp wants to merge 1 commit into from
Closed

[platform] fix uninitialized variable #11

bryonglodencissp wants to merge 1 commit into from

Conversation

@bryonglodencissp
Copy link

@bryonglodencissp bryonglodencissp commented Sep 10, 2016 •
edited
Loading

On line number 628 of time.cc, the variable ticks may be accessed without an initialized value. And while the return value of TimeTicks::HighResolutionNow will never be zero, it's always good to initialize variables, because if we try to access a value before it gets assigned any actual (non-garbage) value, then it results in undefined behavior.

@natorion
Copy link
Member

natorion commented Sep 12, 2016

Thanks for the PR. V8 is not accepting PRs on GitHub. Please use the Chromium Codereview tool. More information can be found at https://github.com/v8/v8/wiki/Contributing.

@natorion natorion closed this Sep 12, 2016
@natorion
Copy link
Member

natorion commented Sep 12, 2016

See https://bugs.chromium.org/p/chromium/issues/detail?id=646005 as the tracking bug.

@littledan
Copy link
Contributor

littledan commented Sep 12, 2016

@bryongloden Thanks for pointing out this issue. I really appreciate contributions like this. Let me know if you have any problems following up on the bug in the Chrome bug tracker. Sorry for the extra overhead of going someplace rather than GitHub!

kisg pushed a commit to paul99/v8mips that referenced this pull request Sep 28, 2016
@verwaest
Revert of Don't use different function scopes when parsing with temp …
9e2b40a 
…zones (patchset v8#11 id:200001 of https://codereview.chromium.org/2368313002/ )

Reason for revert:
Revert due to asm.js slowdown

Original issue's description:
> Don't use different function scopes when parsing with temp zones
>
> Previously we'd have a scope in the main zone, and another in the temp zone. Then we carefully copied back data to the main zone. This CL changes it so that the scope is just fixed up to only contain data from the main zone. That avoids additional copies and additional allocations; while not increasing the care that needs to be taken. This will also make it easier to abort preparsing while parsing using a temp zone.
>
> BUG=
>
> Committed: https://crrev.com/f41e7ebd62b32e861b6aa14ad8bfce3018d03c3c
> Cr-Commit-Position: refs/heads/master@{#39800}

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2379533003
Cr-Commit-Position: refs/heads/master@{#39821}
danbev pushed a commit to danbev/v8 that referenced this pull request Sep 30, 2016
@mlippautz
Revert of "[heap] Switch to 500k pages" (patchset v8#11 id:220001 of h…
1617043 
…ttps://codereview.chromium.org/2232653003/ )

Reason for revert:
Breaks benchmark with --turbo on avx2

https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/9895

Original issue's description:
> Reland of "[heap] Switch to 500k pages"
>
> Decrease regular heap object size to 400k. In a follow up, we can now get rid of
> the new space border page while keeping the 1M minimum new space size.
>
> BUG=chromium:636331
>
> This reverts commit 555c961.
>
> Committed: https://crrev.com/20e2ea80e169e85c5b8231adc02901fb6c989609
> Cr-Commit-Position: refs/heads/master@{#38608}

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:636331

Review-Url: https://codereview.chromium.org/2239323002
Cr-Commit-Position: refs/heads/master@{#38613}
targos pushed a commit to nodejs/v8 that referenced this pull request Sep 30, 2016
Version 5.4.500.6
be716d3 
Cr-Commit-Position: refs/branch-heads/5.4@{v8#11}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
kisg pushed a commit to paul99/v8mips that referenced this pull request Oct 14, 2016
@dtig
Revert of [wasm] Fix bounds check for zero initial memory. (patchset v…
2c45630 
…8#11 id:200001 of https://codereview.chromium.org/2416543002/ )

Reason for revert:
Reverting because of failure on V8 Linux64 GC Stress

http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/8572

Original issue's description:
> [wasm] Fix bounds check for zero initial memory.
>
> Currently when memory size references are updated with zero initial memory during GrowMemory/Relocation of Instance objects, the bounds check does not take into account the size of memtype.
>
> [email protected], [email protected]
>
> Committed: https://crrev.com/70416a2b360c0d993cffb48284b143d484d1e290
> Cr-Commit-Position: refs/heads/master@{#40326}

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2416393002
Cr-Commit-Position: refs/heads/master@{#40328}
targos pushed a commit to nodejs/v8 that referenced this pull request Nov 5, 2016
Version 5.5.372.5
e4aec06 
Cr-Commit-Position: refs/branch-heads/5.5@{v8#11}
Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1}
Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
cameni pushed a commit to Outerra/v8 that referenced this pull request Nov 30, 2016
Merged: s390: using uintptr to fix gcc error
74e82e5 
Revision: 9d1d387

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected], [email protected]
BUG=

Review-Url: https://codereview.chromium.org/2525813002
Cr-Commit-Position: refs/branch-heads/5.6@{v8#11}
Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1}
Cr-Branched-From: 879f659-refs/heads/master@{#41014}
kisg pushed a commit to paul99/v8mips that referenced this pull request Dec 14, 2016
@alexkozy
Revert of Store SharedFunctionInfos of a Script in a FixedArray index…
3dea2c8 
…ed by their ID (patchset v8#11 id:190001 of https://codereview.chromium.org/2547483002/ )

Reason for revert:
LiveEdit is broken in some cases.

Original issue's description:
> Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID
>
> Now that SharedFunctionInfos have a unique ID (and the IDs are dense),
> we can use them as an index into an array, instead of using a
> WeakFixedArray where we have to do a linear scan.
>
> Hooking up liveedit is a bit more involved, see
> https://docs.google.com/presentation/d/1FtNa3U7WsF5bPhY9uGoJG5Y9hnz5VBDabfOWpb4unWI/edit
> for an overview
>
> BUG=v8:5589
> [email protected],[email protected]
>
> Committed: https://crrev.com/6595e7405769dc9d49e9568d61485efc6d468baf
> Cr-Commit-Position: refs/heads/master@{#41600}

[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5589,chromium:673950
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2578433002
Cr-Commit-Position: refs/heads/master@{#41684}
kisg pushed a commit to paul99/v8mips that referenced this pull request Dec 22, 2016
@natorion
Revert of [TypeFeedbackVector] Root literal arrays in function litera…
aa8a208 
…ls slots (patchset v8#11 id:370001 of https://codereview.chromium.org/2504153002/ )

Reason for revert:
Speculative revert because of blocked roll: https://codereview.chromium.org/2596013002/

Original issue's description:
> [TypeFeedbackVector] Root literal arrays in function literals slots
>
> Literal arrays and feedback vectors for a function can be garbage
> collected if we don't have a rooted closure for the function, which
> happens often. It's expensive to come back from this (recreating
> boilerplates and gathering feedback again), and the cost is
> disproportionate if the function was inlined into optimized code.
>
> To guard against losing these arrays when we need them, we'll now
> create literal arrays when creating the feedback vector for the outer
> closure, and root them strongly in that vector.
>
> BUG=v8:5456
>
> Review-Url: https://codereview.chromium.org/2504153002
> Cr-Commit-Position: refs/heads/master@{#41893}
> Committed: https://chromium.googlesource.com/v8/v8/+/93df094081f04c629c3df2e40318de90ce5e0fb9

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5456

Review-Url: https://codereview.chromium.org/2597163002
Cr-Commit-Position: refs/heads/master@{#41917}
hubot pushed a commit that referenced this pull request Dec 22, 2016
@natorion
Version 5.7.324.2 (cherry-pick)
65e3722 
Merged aa8a208

Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (patchset #11 id:370001 of https://codereview.chromium.org/2504153002/ )

[email protected]

Review-Url: https://codereview.chromium.org/2592393002 .
Cr-Commit-Position: refs/heads/5.7.324@{#3}
Cr-Branched-From: 2041c50-refs/heads/master@{#41902}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jan 17, 2017
@mi-ac
Revert of [complier] Enable parallel eager inner function compilation…
6715439 
… with compiler dispatcher. (patchset v8#11 id:260001 of https://codereview.chromium.org/2611313002/ )

Reason for revert:
Some crashes on mac:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/11982/steps/Ignition%20-%20turbofan/logs/regress-crbug-429159
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/10966

Original issue's description:
> [complier] Enable parallel eager inner function compilation with compiler dispatcher.
>
> Enable enqueueing of eager inner function compilation onto the compiler
> dispatcher. This enables these tasks to be performed in parallel to
> compilation of the outer functio (only for Ignition functions).
> We currently synchronize to ensure all inner function compilations
>  are complete before executing the outer function - future work will
> allow outer function execution to happenin parallel to inner function
> compilation.
>
> BUG=v8:5203,v8:5215
>
> Review-Url: https://codereview.chromium.org/2611313002
> Cr-Commit-Position: refs/heads/master@{#42413}
> Committed: https://chromium.googlesource.com/v8/v8/+/f12661a1ece4e9c9cb8df5c2d349db960356e604

[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5203,v8:5215

Review-Url: https://codereview.chromium.org/2637123002
Cr-Commit-Position: refs/heads/master@{#42416}
hubot pushed a commit that referenced this pull request Jan 19, 2017
Version 5.7.492.4
e785353 
Cr-Commit-Position: refs/branch-heads/5.7@{#11}
Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1}
Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
hubot pushed a commit that referenced this pull request Mar 2, 2017
Merged: s390: Fix logic to check for overflow
bb90d7e 
Revision: ef2a9e2

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected], [email protected], [email protected]
BUG=

Review-Url: https://codereview.chromium.org/2728763005
Cr-Commit-Position: refs/branch-heads/5.8@{#11}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
hubot pushed a commit that referenced this pull request Apr 17, 2017
@bmeurer
Merged: [turbofan] Use unreliable receiver maps for __proto__ lowering.
5cc93b4 
Revision: 136c712

BUG=chromium:711195,v8:5267,v8:6241
[email protected]
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Id6e9bf726c268d525c33b363b4358d565b41535f
Reviewed-on: https://chromium-review.googlesource.com/479731
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/5.9@{#11}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Version 5.3.332.8
d909155 
Cr-Commit-Position: refs/branch-heads/5.3@{#11}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
hubot pushed a commit that referenced this pull request Apr 28, 2017
@jeisinger
Version 4.9.385.9 (cherry-pick)
9aaa195 
Merged 9b7035d

LookupIterator should find private symbols on JSProxies

BUG=chromium:571365
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1612093004 .

Cr-Commit-Position: refs/branch-heads/4.9@{#11}
Cr-Branched-From: 2fea296-refs/heads/4.9.385@{#1}
Cr-Branched-From: 0c1430a-refs/heads/master@{#33306}
hubot pushed a commit that referenced this pull request Apr 28, 2017
@mlippautz
Version 5.1.281.8 (cherry-pick)
8375510 
Merged 6e281f1

[heap] Fix SemiSpace::Commit/GrowTo to deal with OOM

BUG=chromium:581412,chromium:601041,chromium:601417
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1892043002 .

Cr-Commit-Position: refs/branch-heads/5.1@{#11}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
hubot pushed a commit that referenced this pull request Apr 28, 2017
@ripsawridge
Version 5.2.361.7 (cherry-pick)
38dfd6c 
Merged b71f1cc

Bugfix: Crankshaft array literals with incorrect values.

BUG=chromium:606021
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/2010503002 .

Cr-Commit-Position: refs/branch-heads/5.2@{#11}
Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1}
Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Version 4.7.80.6
a2feb51 
Cr-Commit-Position: refs/branch-heads/4.7@{#11}
Cr-Branched-From: f3c8926-refs/heads/master@{#31014}
hubot pushed a commit that referenced this pull request Apr 28, 2017
@jeisinger
Also disable handle zapping for GN release BUILDS
2371116 
BUG=chromium:318206
[email protected], [email protected]
LOG=n

Review URL: https://codereview.chromium.org/1751843002 .

Cr-Commit-Position: refs/branch-heads/5.0@{#11}
Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1}
Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
hubot pushed a commit that referenced this pull request Apr 28, 2017
@natorion
Version 4.8.271.8 (cherry-pick)
561ecce 
Merged 833fb7d
Merged 9864129

[debugger] track debugger feature usage via histogram.

[debugger] only track LiveEdit if source changes.

[email protected]
BUG=v8:4596

Review URL: https://codereview.chromium.org/1510433002 .

Cr-Commit-Position: refs/branch-heads/4.8@{#11}
Cr-Branched-From: 10449d4-refs/heads/4.8.271@{#1}
Cr-Branched-From: 2ebd5fc-refs/heads/master@{#31941}
kisg pushed a commit to paul99/v8mips that referenced this pull request May 18, 2017
@mi-ac
Revert of [csa] Add assertions to CSA (patchset v8#11 id:200001 of ht…
72edb75 
…tps://codereview.chromium.org/2847923003/ )

Reason for revert:
Seems to have made nosnap debug very slow and also leads to check failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/13248

Original issue's description:
> [csa] Add assertions to CSA
>
> This adds a bunch of assertions to CSA, mostly about documenting and checking
> parameter types.
>
> Drive-by-change: Removed unused function.
>
> BUG=v8:6325
>
> Review-Url: https://codereview.chromium.org/2847923003
> Cr-Commit-Position: refs/heads/master@{#45398}
> Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6325

Review-Url: https://codereview.chromium.org/2892023002
Cr-Commit-Position: refs/heads/master@{#45401}
hubot pushed a commit that referenced this pull request Jun 1, 2017
@rmcilroy
Revert "Merged: [Interpreter] Allocate context registers as temporary…
a3fea5e 
… registers."

This reverts commit 16d77bb.

Reason for revert: breaks build

Original change's description:
> Merged: [Interpreter] Allocate context registers as temporary registers.
> 
> Revision: c68df41
> 
> BUG=chromium:716265,v8:6322
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​mythria
> 
> Change-Id: Ieaf426865f90c4dc8d59a4c1e545748e7b7b34e2
> Reviewed-on: https://chromium-review.googlesource.com/519169
> Reviewed-by: Mythri Alle <[email protected]>
> Cr-Commit-Position: refs/branch-heads/6.0@{#9}
> Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{#1}
> Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}

[email protected],[email protected]
BUG=chromium:716265,v8:6322

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I5f04c3f27c246e00654e5c786c7f55e9d0b758e8
Reviewed-on: https://chromium-review.googlesource.com/519410
Commit-Queue: Michael Achenbach <[email protected]>
Reviewed-by: Ross McIlroy <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.0@{#11}
Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{#1}
Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}
hubot pushed a commit that referenced this pull request Jul 26, 2017
Version 6.1.534.5
eb91f0f 
[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I86963f2c155ae3db46e470f5d6f20503fe67c7d1
Reviewed-on: https://chromium-review.googlesource.com/585975
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.1@{#11}
Cr-Branched-From: 1bf2e10-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c43-refs/heads/master@{#46746}
hubot pushed a commit that referenced this pull request Sep 11, 2017
@jaro-sevcik
Merged: [turbofan] Fix arm backend matching of (x >>> 24) & 0xffff.
08fe06d 
Revision: b1c1228

BUG=chromium:739902
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I9b6ddf251e08667983a49005441e8931b5511418
Reviewed-on: https://chromium-review.googlesource.com/660098
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.2@{#11}
Cr-Branched-From: efa2ac4-refs/heads/6.2.414@{#1}
Cr-Branched-From: a861ebb-refs/heads/master@{#47693}
hubot pushed a commit that referenced this pull request Oct 17, 2017
@jaro-sevcik
Merged: [profiler] Fix heap iteration to ignore deoptimized code obje…
8f9b2a6 
…cts.

Revision: 6aa9f43

BUG=chromium:763073
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: If8a8ebf9e176e862912010deb1a54ae484bd45e3
Reviewed-on: https://chromium-review.googlesource.com/722639
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#11}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 4, 2023
Version 11.6.189.8
114ee23 
Change-Id: Ie103e708d82466e0fccc79babd2feb7fe944dd24
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4663203
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.6@{v8#11}
Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3}
Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Aug 27, 2023
Version 11.7.439.6
d58d4c4 
Change-Id: I69788c6a5236be72532e1253155e664d65814810
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4806900
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.7@{v8#11}
Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1}
Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Sep 15, 2023
Version 11.8.172.6
748d336 
Change-Id: I4302bbcbd23b1860de7222d4826c5757401e5449
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4863815
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.8@{v8#11}
Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1}
Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Nov 21, 2023
Version 12.0.267.6
d2947dc 
Change-Id: I305bc66e2db90dce942c55c5b3f4b242a4d624a2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5048792
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.0@{v8#11}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Dec 10, 2023
Version 12.1.285.6
21e09a5 
Change-Id: I556aec69f67781d3196db597b707bebf98e9066d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5101514
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#11}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Feb 29, 2024
Version 12.3.219.6
d69e828 
Change-Id: Ie63adc188762d1a7652692bf3bb5181eebfedd82
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331841
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.3@{#11}
Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1}
Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot pushed a commit that referenced this pull request Mar 25, 2024
Version 12.4.254.6
08addf7 
Change-Id: I77887400451b3e24f8f6c3f56cb2cd1c7fd5ef98
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5387591
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.4@{#11}
Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1}
Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
probablytom pushed a commit to probablytom/v8 that referenced this pull request Apr 11, 2024
Version 12.2.281.6
8d801a3 
Change-Id: Ibc710e6e60cce7ae12f4d4e9f6931c0ee8455ec9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5237508
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.2@{v8#11}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request Apr 26, 2024
Version 12.5.227.6
d12774b 
Change-Id: I44ddfad89d2d19dd03c970c8ced88bdabcc2578b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5491629
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.5@{#11}
Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1}
Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot pushed a commit that referenced this pull request May 21, 2024
Version 12.6.228.7
2072d92 
Change-Id: I81b91a3ce4f6c98061fa0361e90e6f68c0d90c7a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5553158
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.6@{#11}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Jun 18, 2024
Version 12.7.224.6
6ba466d 
Change-Id: I5dc0cc313f7a27539bfc9573c6424bcd0a18196d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5635540
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.7@{#11}
Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1}
Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot pushed a commit that referenced this pull request Aug 2, 2024
Version 12.8.374.6
f7d8ec4 
Change-Id: I31a784f8dbc6aa0d9115b89070125bd47b10876c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5759380
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.8@{#11}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Aug 28, 2024
Version 12.9.202.6
8d743c6 
Change-Id: Ibbdc30f13d9a246977bca722456a9d7a87e7bd4f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5822885
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.9@{#11}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
CuiLam pushed a commit to CuiLam/v8 that referenced this pull request Sep 4, 2024
Version 11.9.169.6
ef8134c 
Change-Id: I77bd60aeeb1a5557fafb7f7f92cd209c31382e7d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4974343
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.9@{v8#11}
Cr-Branched-From: 3eb7d73-refs/heads/11.9.169@{#1}
Cr-Branched-From: 1a13bf9-refs/heads/main@{#90218}
hubot pushed a commit that referenced this pull request Sep 20, 2024
Version 13.0.245.6
3ff60a8 
Change-Id: I2466541bd993f849ed33ea6bcd4a3b49a98f6647
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5876447
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.0@{#11}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Nov 4, 2024
Version 13.1.201.6
e9dba06 
Version incremented at https://cr-buildbucket.appspot.com/build/8732173337487018193

Change-Id: I86d45ab039348902df840d3fbc0d67da7810fa92
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5989412
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.1@{#11}
Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1}
Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot pushed a commit that referenced this pull request Nov 19, 2024
Version 13.2.152.6
bd95850 
Version incremented at https://cr-buildbucket.appspot.com/build/8730847224130862385

Change-Id: I42bcfc293929272e618621b71cff276971914c1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6035013
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.2@{#11}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Jan 13, 2025
Version 13.3.415.6
1043edb 
Version incremented at https://cr-buildbucket.appspot.com/build/8725871374667844833

Change-Id: Ic85e8303470d59fdf14435f4fa443e37ede2a763
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6170318
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.3@{#11}
Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1}
Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot pushed a commit that referenced this pull request Feb 10, 2025
Version 13.4.114.6
ed3b55d 
Version incremented at https://cr-buildbucket.appspot.com/build/8723296910803332961

Change-Id: Ib80d4adf44ec9204041aac2f5cec5c1b848db9d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6248282
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.4@{#11}
Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1}
Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot pushed a commit that referenced this pull request Mar 12, 2025
Version 13.5.212.6
f7dc8b0 
Version incremented at https://cr-buildbucket.appspot.com/build/8720613731344536833

Change-Id: I698383074ad180b208e2b1f9131f68a8f35465b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6347256
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.5@{#11}
Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1}
Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
digitalhurricane-io pushed a commit to digitalhurricane-io/v8 that referenced this pull request Apr 2, 2025
@digitalhurricane-io
Version 13.5.212.6
3e7b3cc 
Version incremented at https://cr-buildbucket.appspot.com/build/8720613731344536833

Change-Id: I698383074ad180b208e2b1f9131f68a8f35465b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6347256
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.5@{v8#11}
Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1}
Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
hubot pushed a commit that referenced this pull request Apr 14, 2025
Version 13.6.233.6
2bc178b 
Version incremented at https://cr-buildbucket.appspot.com/build/8717585521276163489

Change-Id: I7c195b5fc78adc981b60996b2a3fd1872a46d884
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6454511
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.6@{#11}
Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1}
Cr-Branched-From: f6be482-refs/heads/main@{#99571}
hubot pushed a commit that referenced this pull request May 6, 2025
Version 13.7.152.6
4cbf76b 
Version incremented at https://cr-buildbucket.appspot.com/build/8715617307058356577

Change-Id: I1918878c2b0885ea23333918fe846815520e0d2f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6512258
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.7@{#11}
Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1}
Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot pushed a commit that referenced this pull request May 29, 2025
Version 13.8.258.6
e38fbf1 
Version incremented at https://cr-buildbucket.appspot.com/build/8713498094098243601

Change-Id: I9a6a4b1522b2d72b8c0adad6b0f16fb8aaa13644
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6605160
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.8@{#11}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Jul 3, 2025
Version 13.9.205.6
e87a76c 
Version incremented at https://cr-buildbucket.appspot.com/build/8710380803442017073

Change-Id: Ib3b6d2bb9d995421c657933656ed02bfcef9db6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6701189
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.9@{#11}
Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1}
Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot pushed a commit that referenced this pull request Sep 16, 2025
Version 14.0.365.6
59c8e02 
Version incremented at https://cr-buildbucket.appspot.com/build/8703583765842741185

Change-Id: Idbf5e92819f6cdb74c9c7e9bdf97fdb79201b19d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6950889
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.0@{#11}
Cr-Branched-From: 4ec2f43-refs/heads/14.0.365@{#1}
Cr-Branched-From: a88b570-refs/heads/main@{#101731}
hubot pushed a commit that referenced this pull request Sep 18, 2025
@zjiaz
Merged: [loong64][mips64][wasmfx] Add a simple continuation wrapper
ebe9e6f 
Port commit a0a8b02

(cherry picked from commit 51d117f)

Bug: 445872937
Change-Id: I9e801fab253fa88e394cbe80ef0e0a20cf46750a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6966035
Reviewed-by: Thibaud Michaud <[email protected]>
Auto-Submit: Zhao Jiazhong <[email protected]>
Commit-Queue: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.1@{#11}
Cr-Branched-From: 1f4839b-refs/heads/14.1.146@{#1}
Cr-Branched-From: cd6944c-refs/heads/main@{#102149}
hubot pushed a commit that referenced this pull request Oct 16, 2025
Merged: [regexp] Fix potential overflow on 32-bit builds
5858215 
In RegExpMatchGlobalAtom_OneCharPattern, if subject is allocated at a
high address, it is possible that `block + stride * max_count`
overflows on 32-bit builds on a 64-bit platform.
Fix this by comparing `stride * max_count` against the remaining length.

Fixed: 449767585
(cherry picked from commit 05f9ca4)

Change-Id: I6949ca0f5e14bad02cf8522429335f5a1cceb5b9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7045722
Commit-Queue: Jakob Linke <[email protected]>
Auto-Submit: Patrick Thier <[email protected]>
Reviewed-by: Jakob Linke <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.2@{#11}
Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1}
Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot pushed a commit that referenced this pull request Nov 5, 2025
Version 14.3.127.6
3f6338e 
Version incremented at https://cr-buildbucket.appspot.com/build/8699034854777724161

Change-Id: I7dcf7d888c286197c450bec1361b22720dda6a1f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7122992
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.3@{#11}
Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1}
Cr-Branched-From: 01af089-refs/heads/main@{#103352}
hubot pushed a commit that referenced this pull request Dec 5, 2025
Version 14.4.258.6
93b3eaf 
Version incremented at https://cr-buildbucket.appspot.com/build/8696332233674429745

Change-Id: I3e6ecee2f66477023a8a70bb219fca6305c0e79f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7228310
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.4@{#11}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryonglodencissp @natorion @littledan