Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 819e184
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 451d38b
Choose a head ref
  • 8 commits
  • 8 files changed
  • 4 contributors

Commits on Jul 21, 2020

  1. Merged: [weakrefs] Make unregister_token undefined on popped WeakCells 

    The unregister_token slot is iterated as a custom weak pointer slot,
which means the heap verifier treats it as a strong slot. Currently,
popped WeakCells (that is, WeakCells for which the owning
FinalizationRegistry's finalizer has already been invoked) neither
clears out the unregister_token slot nor marks it, which trips the heap
verifier.

(cherry picked from commit 93c0be4)

[email protected]
NOTRY=true

Bug: chromium:1102161
Change-Id: I176b8422218653da97023f9eda33997729f4e9c3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309153
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.4@{#38}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    @syg
    syg authored and Commit Bot committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    cbd72a3 View commit details
    Browse the repository at this point in the history

  2. Version 8.4.371.20 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie6c89a872af4cc5a80e34d352c32bb913cc3948a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309291
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{#39}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    V8 Autoroll committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    dac453b View commit details
    Browse the repository at this point in the history

  3. Merged: [liftoff] Handle unordered register pairs 

    For 64-bit binary operations, Liftoff on arm made the assumption that
register pairs are always ordered, i.e. the register code for the low
word is lower than the register code for the high word.
Ensuring this was only implemented in {GetUnusedRegister} in
https://crrev.com/c/2168875. Other cases were missing though, e.g.
return values, but also different places were we
construct register pairs internally.

Thus, this CL removes this constraint again and instead handles
unordered register pairs in 64-bit binary operations on arm.

TBR=​[email protected]

(cherry picked from commit b429b8f)

Bug: chromium:1101304
No-Try: true
No-Tree-Checks: true
No-Presubmit: true
Change-Id: Ib52a0bfb620b180e99b2785206779b550a98e1d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308338
Commit-Queue: Clemens Backes <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.4@{#40}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    @backes
    backes authored and Commit Bot committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    4e154dd View commit details
    Browse the repository at this point in the history

  4. Version 8.4.371.21 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I130ea6c1bcbce0dc1ae12defd763d9d663bd371a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309299
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{#41}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    V8 Autoroll committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    d29bde7 View commit details
    Browse the repository at this point in the history

  5. Merged: [Promise.allSettled] Fix [[AlreadyCalled]] checking in elemen… 

    …t closures

(cherry picked from commit 26df3fd)

NOTRY=true

Bug: chromium:1105318
Change-Id: I7b1c57b7ff7beaaa53c19a270d5a8c36b11baf17
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301082
Reviewed-by: Sathya Gunasekaran  <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#68903}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307178
Cr-Commit-Position: refs/branch-heads/8.4@{#42}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    @syg
    syg authored and Commit Bot committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    ed6417a View commit details
    Browse the repository at this point in the history

  6. Version 8.4.371.22 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ia9d25742c9a04ee89fed1ea327ffa991b434503d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310082
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{#43}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    V8 Autoroll committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    483421e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Whitespace to trigger builders 

    TBR: [email protected]
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I17095b9edc4b222ffd5cc29ff955e14042b34884
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330018
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.4@{#44}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    Liviu Rau authored and Commit Bot committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    bbabf81 View commit details
    Browse the repository at this point in the history

  2. Version 8.4.371.23 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: If2a3b2f547ea523ecf92dd2fb8d48e180190e469
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2329623
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{#45}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
    V8 Autoroll committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    451d38b View commit details
    Browse the repository at this point in the history
Loading