Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 14 commits
- 21 files changed
- 7 contributors
Commits on Mar 8, 2018
-
Merged: Revert "Reland: Reimplement Object.entries/values as CSA to o…
…ptimize performance." This reverts commit 03e9d41. Reason for revert: Correctness issues, see https://crbug.com/804159. Bug: chromium:804159 Original change's description: > Reland: Reimplement Object.entries/values as CSA to optimize performance. > > Add Object.entries/values builtins to debug-evaluate.cc whitelist macro. > This fix revert commit of https://chromium-review.googlesource.com/c/v8/v8/+/859937 > Original is https://chromium-review.googlesource.com/c/v8/v8/+/810504 > >> Reimplements Object.entries/values as CSA to optimize performance. See more detail about https://bugs.chromium.org/p/v8/issues/ Issue 6804. > > This reverts commit 1b49f72. > > Bug: v8:6804 > Change-Id: I57e8b66e1c4ece2abb52e1630a97fbfd4070d810 > Reviewed-on: https://chromium-review.googlesource.com/860679 > Commit-Queue: Yang Guo <[email protected]> > Reviewed-by: Yang Guo <[email protected]> > Cr-Commit-Position: refs/heads/master@{#50492} [email protected],[email protected],[email protected],[email protected],[email protected] NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:6804 Change-Id: I39b1854ca7c2f57819ba377f84560356d3756bfb Reviewed-on: https://chromium-review.googlesource.com/877886 Reviewed-by: Jakob Gruber <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#50746} Reviewed-on: https://chromium-review.googlesource.com/955083 Cr-Commit-Position: refs/branch-heads/6.5@{#63} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
Commits on Mar 12, 2018
-
Merged: [runtime] Properly calculate upper bound for NOF in_object_pr…
…operties Revision: 0d26307 BUG=chromium:817499 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: I5ce7203243c0ac84d654a106131f20725833766a Reviewed-on: https://chromium-review.googlesource.com/958471 Reviewed-by: Igor Sheludko <[email protected]> Cr-Commit-Position: refs/branch-heads/6.5@{#65} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
-
Merged: [arm64] Fix compile error in Simulator
Some compilers complain that ConvertReturn is private in SimulatorBase, but used in the arm64 Simulator. This CL fixes this by making ConvertReturn protected. [email protected] NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:7541 Change-Id: Ic36eeb6edbca59982714fe10e142cf2d1dbc5ecd Originally-reviewed-on: https://chromium-review.googlesource.com/955689 Reviewed-on: https://chromium-review.googlesource.com/958901 Reviewed-by: Andreas Haas <[email protected]> Commit-Queue: Clemens Hammacher <[email protected]> Cr-Commit-Position: refs/branch-heads/6.5@{#67} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
-
Merged: [heap] Make setting use_tasks_ explicit
At the moment the flag is set too late, it is possible that the GC still tries to post tasks in Isolate::Deinit when the isolate is already disconnected from the platform, see the referenced bug. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=[email protected] Bug: chromium:810739 Change-Id: Ibcd226cb44cc903f2a46e7cccf682b3938c9d408 Reviewed-on: https://chromium-review.googlesource.com/915942 Reviewed-by: Ulan Degenbaev <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#51274}(cherry picked from commit 1e9504b) Reviewed-on: https://chromium-review.googlesource.com/958961 Cr-Commit-Position: refs/branch-heads/6.5@{#69} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
-
Revert "Merged: [heap] Make setting use_tasks_ explicit"
This reverts commit c2a6be0. Reason for revert: A second CL is needed to fix this issue, and the second CL is not ready yet for backmerge. Original change's description: > Merged: [heap] Make setting use_tasks_ explicit > > At the moment the flag is set too late, it is possible that the GC still > tries to post tasks in Isolate::Deinit when the isolate is already > disconnected from the platform, see the referenced bug. > > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=[email protected] > > Bug: chromium:810739 > Change-Id: Ibcd226cb44cc903f2a46e7cccf682b3938c9d408 > Reviewed-on: https://chromium-review.googlesource.com/915942 > Reviewed-by: Ulan Degenbaev <[email protected]> > Commit-Queue: Andreas Haas <[email protected]> > Cr-Original-Commit-Position: refs/heads/master@{#51274}(cherry picked from commit 1e9504b) > Reviewed-on: https://chromium-review.googlesource.com/958961 > Cr-Commit-Position: refs/branch-heads/6.5@{#69} > Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} > Cr-Branched-From: 594a1a0-refs/heads/master@{#50664} [email protected],[email protected] Change-Id: I12ffd87eb2242ff33c6f83cb28349dfcd8a069d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:810739 Reviewed-on: https://chromium-review.googlesource.com/958910 Reviewed-by: Andreas Haas <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Commit-Position: refs/branch-heads/6.5@{#71} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
Commits on Mar 13, 2018
-
Merged: Squashed multiple commits.
Merged: [profiler] use Sleep() on windows for long profile intervals. Revision: 15c0c3a Merged: [profiler] fix sleeping on windows for long intervals. Revision: 43e2fb1 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Bug: v8:7535 Change-Id: If426b1282e4b4c0ab765624f681415fe943f5170 Reviewed-on: https://chromium-review.googlesource.com/960845 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Ali Ijaz Sheikh <[email protected]> Cr-Commit-Position: refs/branch-heads/6.5@{#73} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2bc5f56...9d37823