Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1e6ebba
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8772d17
Choose a head ref
  • 5 commits
  • 7 files changed
  • 4 contributors

Commits on Aug 26, 2019

  1. Merged: [turbofan] Fix memory corruption 

    Revision: f16a3a7

BUG=chromium:997057
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I2cbdf028a5c4c50728477cc08e583094297deaa6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1768365
Reviewed-by: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.7@{#16}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
    @MayaLekova
    MayaLekova committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    399156f View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Merged: [regexp] Dont attempt to match '^' before the start of the st… 

    …ring

This fixes an invalid assumption when emitting code for matching '^'
(start of line) in multiline regexps and '\b', '\B' in general.

What we used to do: if the current trace's cp_offset (the offset from
the current position) was non-zero, we assumed that we were looking at
subject string index 1 or greater (i.e.: not at the start of the string
or before).

This is no longer valid since cp_offsets can now be negative.

This CL changes the logic to omit start- and bounds-checks only for
strictly positive cp_offsets, where the above assumption still holds.

(cherry picked from commit 1990b1e)

Tbr: [email protected]
No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: chromium:996391
Change-Id: I79be4fc295c6f0b63e41c13d1e91fdd00f2f2b42
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771794
Commit-Queue: Erik Corry <[email protected]>
Auto-Submit: Jakob Gruber <[email protected]>
Reviewed-by: Erik Corry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#63424}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781680
Reviewed-by: Jakob Gruber <[email protected]>
Commit-Queue: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.7@{#17}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
    @schuay
    schuay authored and Commit Bot committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b0ea26d View commit details
    Browse the repository at this point in the history

  2. Version 7.7.299.9 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I2221693817984e2eff40a8a97f288e9be18429e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781197
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.7@{#18}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
    V8 Autoroll committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    13ef268 View commit details
    Browse the repository at this point in the history

  3. Merged: [torque] Check for prototype before loading it 

    Revision: bdcc750

BUG=chromium:999310
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Tbr: [email protected]
Change-Id: I70f3671e9cfa96e14e64ab7d69ac425c17571da0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782823
Commit-Queue: Sigurd Schneider <[email protected]>
Reviewed-by: Sigurd Schneider <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.7@{#19}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
    @sigurdschneider
    sigurdschneider authored and Commit Bot committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    4ebefd2 View commit details
    Browse the repository at this point in the history

  4. Version 7.7.299.10 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I4f05928eaa82e0ebcb8d1823cf704b5937ea93f1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782731
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.7@{#20}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
    V8 Autoroll committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    8772d17 View commit details
    Browse the repository at this point in the history
Loading