Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0dd78c7
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c9ffe2c
Choose a head ref
  • 6 commits
  • 9 files changed
  • 3 contributors

Commits on Apr 9, 2019

  1. Merged: [zone] Fix peak memory accounting 

    When switching from atomicops to std::atomic, I introduced a bug that
makes us miss the actual peak memory consumption, and only report the
second-highest memory usage in each zone.
This CL fixes that.

TBR=​[email protected]

Bug: chromium:939724
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I9bdab84beadc7c78488449cd5d5be6ee64601370
Originally-reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541227
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559731
Commit-Queue: Clemens Hammacher <[email protected]>
Reviewed-by: Clemens Hammacher <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.4@{#39}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
    @backes
    backes authored and Commit Bot committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    cdab8b8 View commit details
    Browse the repository at this point in the history

  2. Version 7.4.288.19 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Iaf99c67e4f8b0d9d8127fbb1e688fd1c05d39b14
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559406
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.4@{#40}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
    V8 Autoroll committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    9134f6e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Merged: [masm] make LoadCodeObjectEntry compatible with duplicated IET 

    On LoadCodeObjectEntry check for IsOffHeapTrampoline instead of
BuiltinIndexOffset so LoadCodeObjectEntry can correctly jump to the
on-heap trampoline when we use --interpreted-frames-native-stack.

R=​[email protected], [email protected]

Tbr: [email protected]
No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: v8:8911
Change-Id: I172d4735671726d32328de246990b513106e3a7f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516692
Commit-Queue: Jakob Gruber <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#60288}(cherry picked from commit 1c15454)
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569431
Cr-Commit-Position: refs/branch-heads/7.4@{#41}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
    @mmarchini
    mmarchini authored and Commit Bot committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    113a33f View commit details
    Browse the repository at this point in the history

  2. Version 7.4.288.20 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: If160346ecc888405874de2d4ba4e11c78ecd3880
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568589
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.4@{#42}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
    V8 Autoroll committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    70558a5 View commit details
    Browse the repository at this point in the history

  3. Merged: [wasm] Protect callbacks by their own lock 

    Callbacks can be called and deleted from any thread, so they need to be
protected by a mutex. The deleted comment in {NotifyOnEvent} is
outdated.
Use a separate mutex such that callbacks can call back into the
NativeModule or CompilationState without deadlocking.

[email protected]

Bug: v8:8904, v8:8689
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I29500836b6335e6a5eb2412c1c0d1f2843034f92
Originally-reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505457
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569433
Commit-Queue: Clemens Hammacher <[email protected]>
Reviewed-by: Michael Starzinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/7.4@{#43}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
    @backes
    backes authored and Commit Bot committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    bc0e105 View commit details
    Browse the repository at this point in the history

  4. Version 7.4.288.21 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie04da406ee590c7f4f381088846c703357afd55a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568592
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.4@{#44}
Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1}
Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
    V8 Autoroll committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    c9ffe2c View commit details
    Browse the repository at this point in the history
Loading