-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Comparing changes
Open a pull request
base repository: v8/v8
base: 02c660a
head repository: v8/v8
compare: bb29462
- 10 commits
- 17 files changed
- 5 contributors
Commits on Oct 21, 2025
-
Merged: [regexp] Fix a possible off-by-one in Trace::cp_offset
.. which was itself guaranteed to be within kMinCPOffset and kMaxCPOffset. But some callers then went on to subtract 1, therefore exceeding kMinCPOffset. Ideally, callers would check that their updated value is still in bounds, and take appropriate action if not. But unfortunately, some current callers (e.g. in RegExpMacroAssembler) *have* no appropriate action, since they cannot abort. So this CL instead takes the approach of adding a kCPOffsetSlack instead, making the range checks in Trace stricter in order to allow caller "misbehavior". We also change cp_offset range DCHECKs into CHECKs since I'm not fully convinced that we correctly observe bounds everywhere. (cherry picked from commit ddf1b5d) Fixed: 451663011 Change-Id: Ib50685d00a490a2959880bdd2fbeae5228a55997 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7037653 Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Jakob Linke <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#103102} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7062471 Cr-Commit-Position: refs/branch-heads/14.2@{#19} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
Configuration menu - View commit details
-
Copy full SHA for 3682dea - Browse repository at this point
Copy the full SHA 3682deaView commit details -
Version incremented at https://cr-buildbucket.appspot.com/build/8700414946798185777 Change-Id: I85337930632c3f6222d5825310c7493949b51aa6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7063502 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#20} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
V8 Autoroll committedOct 21, 2025 Configuration menu - View commit details
-
Copy full SHA for bc4dafa - Browse repository at this point
Copy the full SHA bc4dafaView commit details -
Merged: [json] Parser: Early return if Expect() fails
Expect()/ExpectNext() used to simply set the cursor to the end of the input if the expectation failed. The issue is that a failed expectation can trigger a GC due to allocation of the Exception object. To avoid surprises, Expect() and ExpectNext() now return a bool value indicating if the expectation failed. Checking of this value is enforced and all current usages are replaced by a Macro that returns early if an exception was thrown. Drive-by: Also force checking the return value of Check(). Fixed: 452296415 (cherry picked from commit 50eba5e) Change-Id: Ica951ecda9052e37f68b01293d245c8c2533694e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7062140 Auto-Submit: Patrick Thier <[email protected]> Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Igor Sheludko <[email protected]> Commit-Queue: Patrick Thier <[email protected]> Cr-Commit-Position: refs/branch-heads/14.2@{#21} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
pthier authored and V8 LUCI CQ committedOct 21, 2025 Configuration menu - View commit details
-
Copy full SHA for 421defa - Browse repository at this point
Copy the full SHA 421defaView commit details -
Version incremented at https://cr-buildbucket.appspot.com/build/8700414570493537825 Change-Id: I2adf36c25e8073f3d9b70cdb42c2feebbc750286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7064513 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#22} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
V8 Autoroll committedOct 21, 2025 Configuration menu - View commit details
-
Copy full SHA for 9b63996 - Browse repository at this point
Copy the full SHA 9b63996View commit details -
Merged: [loong64][compiler] Port some optimizations for write barrier
Port commit 25a1089 - [compiler] Invoke method for skipped indirect write barrier Port commit cc26a34 - [compiler] Save link register in write barrier verification Port commit 8112cb4 - [compiler] Reduce wb verification performance overhead Port commit d2b19ba - [compiler] Emit proper instruction on indirect write barrier Port commit a1d0bf6 - [codegen] Improve WB verification for allocation folding (cherry picked from commit 4e4d546) Bug: 453522647 Change-Id: I2e8ad32f53a07d6168f8e929021aebdb7d473851 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7061793 Reviewed-by: Lutz Vahl <[email protected]> Commit-Queue: Lutz Vahl <[email protected]> Cr-Commit-Position: refs/branch-heads/14.2@{#23} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
Configuration menu - View commit details
-
Copy full SHA for 02331aa - Browse repository at this point
Copy the full SHA 02331aaView commit details -
Version incremented at https://cr-buildbucket.appspot.com/build/8700413248767608465 Change-Id: Idcc418d935fcaeb381a7d68fc30fbfa521d28b38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7063018 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#24} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
V8 Autoroll committedOct 21, 2025 Configuration menu - View commit details
-
Copy full SHA for d28be62 - Browse repository at this point
Copy the full SHA d28be62View commit details -
Merged: [loong64][wasmfx] Simplify active stack update
Port commit b67ef5a (cherry picked from commit a905bbe) Bug: 453522647 Change-Id: I1bf5a34f1e5450c8265452a68108c2916c7bf47c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7060794 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Zhao Jiazhong <[email protected]> Cr-Commit-Position: refs/branch-heads/14.2@{#25} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
Configuration menu - View commit details
-
Copy full SHA for 2e8c762 - Browse repository at this point
Copy the full SHA 2e8c762View commit details -
Version incremented at https://cr-buildbucket.appspot.com/build/8700410418589710433 Change-Id: I8b632466b4f748a9bfa4c00b0d288d01149f3346 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7063916 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#26} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
V8 Autoroll committedOct 21, 2025 Configuration menu - View commit details
-
Copy full SHA for 426f057 - Browse repository at this point
Copy the full SHA 426f057View commit details -
Merged: [maglev] Don't find property load continuations across try-ca…
…tch blocks The search for polymorphic property load continuations now stops at try-catch boundaries. Previously, it would scan across them, which could cause it to visit the try-block start once in the first continuation, and cause the second continuation to think it's inside the handler. Drive-by, clean-up the predicate around merge points (to be more explicit about loop headers only not having merge points when loop peeling), and DCHECK that the source position table state doesn't change, since there's nothing in the continuation finding that would make it change. Includes followup fix in https://crrev.com/c/7035734: IsOffsetAPolymorphicContinuationInterrupt should return _true_ at merge points etc., not _false_ (cherry picked from commit d05f2fc) (cherry picked from commit 5b4749d) Fixed: 449549329 Change-Id: I70ae036247fa863ab612d22b90fbe663fdc15104 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7062521 Commit-Queue: Leszek Swirski <[email protected]> Reviewed-by: Lutz Vahl <[email protected]> Reviewed-by: Marja Hölttä <[email protected]> Cr-Commit-Position: refs/branch-heads/14.2@{#27} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
Configuration menu - View commit details
-
Copy full SHA for f8c4d12 - Browse repository at this point
Copy the full SHA f8c4d12View commit details -
Version incremented at https://cr-buildbucket.appspot.com/build/8700405889121757953 Change-Id: I5131c0fb06862389dbf571a7481c579cba17d8b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7063125 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#28} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
V8 Autoroll committedOct 21, 2025 Configuration menu - View commit details
-
Copy full SHA for bb29462 - Browse repository at this point
Copy the full SHA bb29462View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 02c660a...bb29462