Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 6 commits
- 9 files changed
- 3 contributors
Commits on Apr 9, 2019
-
Merged: [zone] Fix peak memory accounting
When switching from atomicops to std::atomic, I introduced a bug that makes us miss the actual peak memory consumption, and only report the second-highest memory usage in each zone. This CL fixes that. TBR=[email protected] Bug: chromium:939724 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I9bdab84beadc7c78488449cd5d5be6ee64601370 Originally-reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559731 Commit-Queue: Clemens Hammacher <[email protected]> Reviewed-by: Clemens Hammacher <[email protected]> Cr-Commit-Position: refs/branch-heads/7.4@{#39} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
Commits on Apr 16, 2019
-
Merged: [masm] make LoadCodeObjectEntry compatible with duplicated IET
On LoadCodeObjectEntry check for IsOffHeapTrampoline instead of BuiltinIndexOffset so LoadCodeObjectEntry can correctly jump to the on-heap trampoline when we use --interpreted-frames-native-stack. R=[email protected], [email protected] Tbr: [email protected] No-Try: true No-Presubmit: true No-Treechecks: true Bug: v8:8911 Change-Id: I172d4735671726d32328de246990b513106e3a7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516692 Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#60288}(cherry picked from commit 1c15454) Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569431 Cr-Commit-Position: refs/branch-heads/7.4@{#41} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
-
Merged: [wasm] Protect callbacks by their own lock
Callbacks can be called and deleted from any thread, so they need to be protected by a mutex. The deleted comment in {NotifyOnEvent} is outdated. Use a separate mutex such that callbacks can call back into the NativeModule or CompilationState without deadlocking. [email protected] Bug: v8:8904, v8:8689 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I29500836b6335e6a5eb2412c1c0d1f2843034f92 Originally-reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505457 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569433 Commit-Queue: Clemens Hammacher <[email protected]> Reviewed-by: Michael Starzinger <[email protected]> Cr-Commit-Position: refs/branch-heads/7.4@{#43} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7.4.288.18...7.4.288.21