Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 8 commits
- 11 files changed
- 5 contributors
Commits on Oct 17, 2018
-
Merged: [wasm] Threads imply structured cloning
In the existing implementation, the structured cloning flag is only set at the startup of the renderer process. In other words, if structured cloning or wasm threads are turned on when the renderer process starts up, then structured cloning is enabled. However, with the origin trial for wasm threads it's possible that wasm threads get turned on only later when the webpages loads. With this CL we now always also check the wasm threads flag in addition to checking the structured cloning flag. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=[email protected] Bug: v8:8304 Change-Id: I49da6bd76a4cc38abc01fbe0c9707c6b17a8de3f Reviewed-on: https://chromium-review.googlesource.com/c/1280444 Reviewed-by: Michael Starzinger <[email protected]> Commit-Queue: Andreas Haas <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#56629}(cherry picked from commit c41fb39) Reviewed-on: https://chromium-review.googlesource.com/c/1286332 Reviewed-by: Clemens Hammacher <[email protected]> Cr-Commit-Position: refs/branch-heads/7.0@{#59} Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1} Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
Commits on Oct 18, 2018
-
Merged: [coverage] Filter out singleton ranges that alias full ranges
Block coverage is based on a system of ranges that can either have both a start and end position, or only a start position (so-called singleton ranges). When formatting coverage information, singletons are expanded until the end of the immediate full parent range. E.g. in: {0, 10} // Full range. {5, -1} // Singleton range. the singleton range is expanded to {5, 10}. Singletons are produced mostly for continuation counters that track whether we execute past a specific language construct. Unfortunately, continuation counters can turn up in spots that confuse our post-processing. For example: if (true) { ... block1 ... } else { ... block2 ... } If block1 produces a continuation counter, it could end up with the same start position as the else-branch counter. Since we merge identical blocks, the else-branch could incorrectly end up with an execution count of one. We need to avoid merging such cases. A full range should always take precedence over a singleton range; a singleton range should never expand to completely fill a full range. An additional post-processing pass ensures this. [email protected] No-Try: true No-Presubmit: true No-Treechecks: true Bug: v8:8237 Change-Id: Idb3ec7b2feddc0585313810b9c8be1e9f4ec64bf Reviewed-on: https://chromium-review.googlesource.com/c/1273095 Reviewed-by: Georg Neis <[email protected]> Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#56531}(cherry picked from commit aac2f8c) Reviewed-on: https://chromium-review.googlesource.com/c/1288640 Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/branch-heads/7.0@{#61} Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1} Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
Commits on Oct 19, 2018
-
Merged: [debug] fix scaling prefix patching for debug evaluate
Revision: ac1660c BUG=chromium:882664 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Change-Id: Idcf912987b0cbe0a96e904de65779ee8c5391098 Reviewed-on: https://chromium-review.googlesource.com/c/1290789 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/branch-heads/7.0@{#63} Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1} Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
Commits on Oct 23, 2018
-
[test] Update builders.pyl to master version
NOTRY=true [email protected] Bug: chromium:830557 Change-Id: I024dcb3c0e2e89899595bf02a6d2ec2f19b2cae3 Reviewed-on: https://chromium-review.googlesource.com/c/1296470 Commit-Queue: Michael Achenbach <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Reviewed-by: Sergiy Byelozyorov <[email protected]> Cr-Commit-Position: refs/branch-heads/7.0@{#65} Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1} Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7.0.276.28...7.0.276.32