Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.9.427.22
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.9.427.23
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 14, 2018

  1. Merged: [wasm] Return immediately if code generation is not allowed 

    There was a bug in WebAssembly.instantiate in the case where a CSP
disallows WebAssembly compilation. In this case the promise returned by
WebAssembly.instantiate was rejected immediately because of the CSP,
but then compilation was started anyways, and the promise was resolved
after compilation for a second time, which caused the crash. With this
CL we do not start compilation if CSP disallows WebAssembly compilation.

Revision: cecd2ed

[email protected]
BUG=chromium:881978
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Id174944361e6fbee899df7894d404f42fcb76218
Reviewed-on: https://chromium-review.googlesource.com/1225977
Reviewed-by: Clemens Hammacher <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.9@{#47}
Cr-Branched-From: d7b61ab-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d-refs/heads/master@{#54504}
    @gahaas
    gahaas committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    ae7a5f8 View commit details
    Browse the repository at this point in the history

  2. Version 6.9.427.23 

    [email protected]

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: Ie778c4fed4210e68e8b771ac888ac76604567ead
Reviewed-on: https://chromium-review.googlesource.com/1226416
Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6.9@{#48}
Cr-Branched-From: d7b61ab-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d-refs/heads/master@{#54504}
    V8 Autoroll committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    40b7c57 View commit details
    Browse the repository at this point in the history
Loading