Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.6.346.24
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.6.346.27
Choose a head ref
  • 6 commits
  • 6 files changed
  • 3 contributors

Commits on Apr 25, 2018

  1. Merged: [wasm] Call AsyncInstantiate directly when instantiating a mo…

    …dule object
    
    WebAssembly.instantiate is polymorphic, it can either take a module
    object as parameter, or a buffer source which should be compiled first.
    To share code between the two implementations, the module object was
    first passed to a promise (i.e. which is the result of compilation).
    However, passing the module object to a promise has a side effect if
    the module object has a then function. To avoid this side effect I
    remove this code sharing and call AsyncInstantiate directly in case
    the parameter is a module object.
    
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECK=true
    
    R=​[email protected]
    
    Bug: chromium:836141
    Change-Id: I67b76d0d7761c5aeb2cf1deda45b6842e494eed4
    Reviewed-on: https://chromium-review.googlesource.com/1025774
    Reviewed-by: Michael Starzinger <[email protected]>
    Commit-Queue: Andreas Haas <[email protected]>
    Cr-Original-Commit-Position: refs/heads/master@{#52755}(cherry picked from commit 49712d8)
    Reviewed-on: https://chromium-review.googlesource.com/1027875
    Cr-Commit-Position: refs/branch-heads/6.6@{#49}
    Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
    Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
    gahaas authored and Commit Bot committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    6324c5a View commit details
    Browse the repository at this point in the history
  2. Version 6.6.346.25

    [email protected]
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I03245898f86ca3c870c37378d777acd86b814496
    Reviewed-on: https://chromium-review.googlesource.com/1027897
    Reviewed-by: v8 autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/6.6@{#50}
    Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
    Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
    V8 Autoroll committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    991129c View commit details
    Browse the repository at this point in the history
  3. Merged: [keys] Don't keep chain of OrderedHashSets in KeyAccumulator

    Revision: 7bb79b9
    
    BUG=chromium:831984
    LOG=N
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    [email protected]
    
    Change-Id: Iba6a94ea2b96627311d1cd3685e3dbd1bcaf341e
    Reviewed-on: https://chromium-review.googlesource.com/1028233
    Reviewed-by: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/branch-heads/6.6@{#51}
    Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
    Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
    camillobruni committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    cb12999 View commit details
    Browse the repository at this point in the history
  4. Version 6.6.346.26

    [email protected]
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Ia27466c88ceda8580d36d30e112aeab01ec94eae
    Reviewed-on: https://chromium-review.googlesource.com/1027806
    Reviewed-by: v8 autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/6.6@{#52}
    Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
    Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
    V8 Autoroll committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    5121094 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Merged: [wasm] Do an additional IsWasmModuleObject check during insta…

    …ntiation
    
    When WebAssembly.instantiate or WebAssembly.instantiateStreaming is
    called in JavaScript, internally we transfrom it into
    WebAssembly.compile(buffer).then(WebAssembly.instantiate). However,
    modifying the prototype of WebAssembly.Module can change the result of
    WebAssembly.compile(buffer). With this CL we make sure that even if the
    result of WebAssembly.compile is modified, there is still no type
    confusion. In the long term we have to do a refactoring and remove
    this internal transformation.
    
    R=​[email protected]
    
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECK=true
    
    Bug: chromium:837417
    Change-Id: I376068b8b8b01b991ec450162da6a62ae7030c62
    Reviewed-on: https://chromium-review.googlesource.com/1032392
    Commit-Queue: Andreas Haas <[email protected]>
    Reviewed-by: Michael Starzinger <[email protected]>
    Cr-Original-Commit-Position: refs/heads/master@{#52859}(cherry picked from commit 441e6d4)
    Reviewed-on: https://chromium-review.googlesource.com/1034058
    Cr-Commit-Position: refs/branch-heads/6.6@{#53}
    Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
    Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
    gahaas authored and Commit Bot committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    1f1bcb7 View commit details
    Browse the repository at this point in the history
  2. Version 6.6.346.27

    [email protected]
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I46e2d601fdd675ef5c4f44b2b0886cfe35d9b193
    Reviewed-on: https://chromium-review.googlesource.com/1034595
    Reviewed-by: v8 autoroll <[email protected]>
    Cr-Commit-Position: refs/branch-heads/6.6@{#54}
    Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
    Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
    V8 Autoroll committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    0215201 View commit details
    Browse the repository at this point in the history
Loading