Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.

...

4 commits
4 files changed
2 contributors

Commits on Dec 11, 2017

Merged: [typedarray] Fix signed-ness of pointer comparisons

While the affected values must be valid addresses & thus will not overflow
the IntPtr type, they need to be interpreted as unsigned int comparisons.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Bug: chromium:792549, v8:7123, v8:3590
Change-Id: I864b50c8dbdc297d70bf83c74a83cc466c5f3eb0
Reviewed-on: https://chromium-review.googlesource.com/814395
Commit-Queue: Peter Marshall <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#49937}(cherry picked from commit b3009cc)
Reviewed-on: https://chromium-review.googlesource.com/819690
Commit-Queue: Jakob Gruber <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#101}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

schuay authored and Commit Bot committed Dec 11, 2017

Version 6.3.292.47

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I180c7e6270b4b16c754259c5facd6536f3fdc897
Reviewed-on: https://chromium-review.googlesource.com/819711
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#102}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

V8 Autoroll committed Dec 11, 2017

Commits on Dec 13, 2017

[coverage] Do not reset JSFunction::code post-deoptimization

When enabling any coverage mode (other than best-effort), we trigger
deoptimization of all functions on the heap.

Prior to the recent removal of the weak list of optimized functions [0],
we'd unlink optimized code from all relevant JSFunctions during the call
to DeoptimizeAll.

After the weak-list-removal, this was no longer the case, hence this [1]
change which attempts to reset the code object from the
SharedFunctionInfo for all found JSFunction objects.

But this can create a situation in which JSFunctions are set up
incorrectly s.t. they have unoptimized code but no feedback vector.

This CL fixes that by leaving JSFunction objects untouched and relying
on self-healing mechanisms (CompileLazyDeoptimizedCode) to fix up
JSFunction::code.

[0] https://crrev.com/f0acede9bb05155c25ee87e81b4b587e8a76f690
[1] https://crrev.com/c/647596/5/src/debug/debug-coverage.cc

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Bug: chromium:786784, chromium:791940, v8:6637
Change-Id: I13191f4c8800a0d72894b959105189dc09ca693e
Reviewed-on: https://chromium-review.googlesource.com/813615
Commit-Queue: Jakob Gruber <[email protected]>
Reviewed-by: Michael Starzinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#49932}
Reviewed-on: https://chromium-review.googlesource.com/822616
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#103}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

schuay authored and Commit Bot committed Dec 13, 2017

Version 6.3.292.48

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I2996e43c900950c3d07f52991a034c51c4760b4f
Reviewed-on: https://chromium-review.googlesource.com/823942
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#104}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

V8 Autoroll committed Dec 13, 2017