Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 18 commits
- 16 files changed
- 8 contributors
Commits on Aug 14, 2024
-
Merged: [runtime] Empty scope info + not compiled = no outer
Bug: 354758515 (cherry picked from commit 636350e) Change-Id: I33900b6aadd92da18a24a16b1a3c69fa02860fa5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5784823 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Deepti Gandluri <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#26} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
-
Merged: [wasm] Disallow WebAssembly.promising with asmjs
Throw a TypeError to match the behavior of creating a WebAssembly.promising from a JS function. [email protected] Bug: 355015467 (cherry picked from commit 7ab6d85) Change-Id: Ia3fdffbfab715bd82320b72ad362427c875d2ace Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5785867 Commit-Queue: Deepti Gandluri <[email protected]> Reviewed-by: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#28} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
Commits on Aug 15, 2024
-
Merged: Revert "[intl] Fix {minute: '2-digit'}"
This reverts commit b615443. Reason for revert: Possibly web incompatible; see issue 358045506 Original change's description: > [intl] Fix {minute: '2-digit'} > > Set the correct ICU option flag to respect all field length for pattern > matching. > > Fixed: 40855035 > Change-Id: I4b89301e4ad98e3db97708a309d11823da8c026f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5646178 > Reviewed-by: Shu-yu Guo <[email protected]> > Commit-Queue: Frank Tang <[email protected]> > Cr-Commit-Position: refs/heads/main@{#94613} Bug: 358045506 (cherry picked from commit 2947a4e) Change-Id: Iefb23af4b4847fa6e281ed6354e5a7c8fd75849a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789880 Reviewed-by: Deepti Gandluri <[email protected]> Commit-Queue: Deepti Gandluri <[email protected]> Auto-Submit: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#30} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
Commits on Aug 19, 2024
-
Merged: [compiler] Ensure old SFIs stay alive for merging
When merging two scripts, we decide whether to use new or old SFIs in one pass over the script info list, and patch old SFIs (in bytecode constant pools) with new ones in another pass. If there is a GC that clears some of the weak script info list pointers between these two passes, then various assumptions break, leading to SFIs in the published result pointing at the wrong script. Make sure that any old SFIs that were encountered in the first pass stay alive for the second pass. Bug: 355575275 (cherry picked from commit b2b082c) Change-Id: Id15a6c6e67544bbaad561312ccf8a9816f8d98f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797603 Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Patrick Thier <[email protected]> Auto-Submit: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#32} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
Commits on Aug 20, 2024
-
Merged: [wasm] Spill all loop inputs before entering loop
This avoids having to load the value back into a register if it was spilled inside of the loop. [email protected] (cherry picked from commit 9797576) Bug: chromium:360700873 Change-Id: I91f1e3c736547d25ec8aa8721c32105d49139309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5800569 Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#34} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
Commits on Aug 21, 2024
-
Revert "Merged: [compiler] Ensure old SFIs stay alive for merging"
This reverts commit 284b51f. Reason for revert: Crashes on 128 branch Original change's description: > Merged: [compiler] Ensure old SFIs stay alive for merging > > When merging two scripts, we decide whether to use new or old SFIs in > one pass over the script info list, and patch old SFIs (in bytecode > constant pools) with new ones in another pass. If there is a GC that > clears some of the weak script info list pointers between these two > passes, then various assumptions break, leading to SFIs in the published > result pointing at the wrong script. > > Make sure that any old SFIs that were encountered in the first pass stay > alive for the second pass. > > Bug: 355575275 > (cherry picked from commit b2b082c) > > Change-Id: Id15a6c6e67544bbaad561312ccf8a9816f8d98f2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797603 > Reviewed-by: Patrick Thier <[email protected]> > Commit-Queue: Patrick Thier <[email protected]> > Auto-Submit: Leszek Swirski <[email protected]> > Cr-Commit-Position: refs/branch-heads/12.8@{#32} > Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} > Cr-Branched-From: 451b63e-refs/heads/main@{#95151} Bug: 355575275 Change-Id: Ib5f4473312dcc91a102dd7fc40e108904149ff8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5801505 Auto-Submit: Deepti Gandluri <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#36} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
-
Revert "Merged: [runtime] Empty scope info + not compiled = no outer"
This reverts commit 67169ad. Reason for revert: Crashes on 128 branch Original change's description: > Merged: [runtime] Empty scope info + not compiled = no outer > > Bug: 354758515 > > (cherry picked from commit 636350e) > > Change-Id: I33900b6aadd92da18a24a16b1a3c69fa02860fa5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5784823 > Reviewed-by: Shu-yu Guo <[email protected]> > Commit-Queue: Deepti Gandluri <[email protected]> > Cr-Commit-Position: refs/branch-heads/12.8@{#26} > Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} > Cr-Branched-From: 451b63e-refs/heads/main@{#95151} Bug: 354758515 Change-Id: I27043daa070e7af09b3efa6fcae53a5847210f05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797857 Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Deepti Gandluri <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#38} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
-
Revert "Merged: [compiler] Multiple fixes for reuse_scope_infos"
This reverts commit bedbc5a. Reason for revert: Crashes on 128 branch Original change's description: > Merged: [compiler] Multiple fixes for reuse_scope_infos > > - Also reuse the scope_info of the function itself. It might be in > RO_SPACE in case the script is in the snapshot, and it would be a > shame to recreate it. > - Make sure we don't drop (or forget to pick up) scope infos for newly > compiled sfis that already existed in the script > - Make sure to reattach scope info chains wherever an outer scope info > exists first. Due to code caches with spotty coverage we might see > unexpected SFI/scope info combinations. > > This also adds a flag to run verification on scope info reuse after > merging. > > Bug: 352673356 > > (cherry picked from commit 67dd629) > > Change-Id: I79d4b24b248720a2f0f5fd7c0df3975282459f2c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5785868 > Reviewed-by: Shu-yu Guo <[email protected]> > Commit-Queue: Deepti Gandluri <[email protected]> > Cr-Commit-Position: refs/branch-heads/12.8@{#24} > Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} > Cr-Branched-From: 451b63e-refs/heads/main@{#95151} Bug: 352673356 Change-Id: I69243a44727dbde5c0e7cfe9591fb77e53b8b46b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5797858 Auto-Submit: Deepti Gandluri <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#40} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
Commits on Aug 23, 2024
-
Merged: [turbofan] Handle Type::None() in SameValue
Bug: chromium:351865302 (cherry picked from commit f784b0b) Change-Id: Idf6bf9276d5510376594f31ee563e4a0bee617f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5806588 Reviewed-by: Matthias Liedtke <[email protected]> Commit-Queue: Nico Hartmann <[email protected]> Auto-Submit: Nico Hartmann <[email protected]> Commit-Queue: Matthias Liedtke <[email protected]> Cr-Commit-Position: refs/branch-heads/12.8@{#42} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
-
Change-Id: I11c0c6d8e9b412a5f674ed8b2c057314c172414a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5804198 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#43} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 12.8.374.13...12.8.374.22