Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 11.3.244.4
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 11.3.244.8
Choose a head ref
  • 8 commits
  • 6 files changed
  • 3 contributors

Commits on Apr 3, 2023

  1. [builtins][pgo] Add Win{32,64} instrumented builder config 

    Windows uses a right-to-left function arguments evaluation order.
To support optimisation for this variant, we generate two more
profiles for x86 and x64 which use Windows to build the instrumented V8.

This change adds the GN config to build a instrumented V8 using Windows.
It is part of a multi-change CL and deployed in the following order:

1*) Add GN args for instrumented builds (https://crrev.com/c/4388886).
2) Add Windows builders (https://crrev.com/c/4388887)
3) Add Windows tracks to PGO builder (https://crrev.com/c/4388421)
4) Refactor profiling script (https://crrev.com/c/4388888)
5) Include r-l-profiles in V8 builds (https://crrev.com/c/4388577)

Additionally, this change sets a default for the v8-target-cpu parameter
of the profile_only.py script. We remove the parameter in the PGO
builder in 3) and rename it in 4).

This change needs to be cherry-picked to active 11.2+ release branches.

Bug: v8:13647
Change-Id: Ifd2e07ad71ea43eb18ee6f8f119680d17e1b1ef7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4393855
Reviewed-by: Lutz Vahl <[email protected]>
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Alexander Schulze <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.3@{#8}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    @alexanderschulze
    alexanderschulze authored and V8 LUCI CQ committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    97a84c9 View commit details
    Browse the repository at this point in the history

  2. Version 11.3.244.5 

    Change-Id: Id61001846b0415be62494f5a2a969abc4a6e77d7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4393487
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.3@{#9}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    V8 Autoroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    1480e0a View commit details
    Browse the repository at this point in the history

  3. [builtins][pgo] Add Win{32,64} builder tests 

    Bug: v8:13647
Change-Id: I09ec3633f87e6f15ec07dfce569da1f1ac4a3a25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394667
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Alexander Schulze <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.3@{#10}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    @alexanderschulze
    alexanderschulze authored and V8 LUCI CQ committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9532078 View commit details
    Browse the repository at this point in the history

  4. Version 11.3.244.6 

    Change-Id: Icc2d581825da72c84aaa24a0ab8ac446533f3fe8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4393491
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.3@{#11}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    V8 Autoroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9111310 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Whitespace change 

    Bug: v8:13647
Change-Id: Iefe061b35def8290e51d02537ea6a0f3b7da38f3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4397687
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Alexander Schulze <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.3@{#12}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    @alexanderschulze
    alexanderschulze authored and V8 LUCI CQ committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    7720b48 View commit details
    Browse the repository at this point in the history

  2. Version 11.3.244.7 

    Change-Id: I271d2d7a332b572089a65df2a6bb7345f7d7d493
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4397762
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.3@{#13}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    V8 Autoroll committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    dc97ada View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. [runtime] Make Error.captureStackTrace() a no-op for global object 

    (cherry picked from commit fa81078)

Bug: chromium:1432210
Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690
Commit-Queue: Igor Sheludko <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Auto-Submit: Igor Sheludko <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#87045}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4419051
Reviewed-by: Igor Sheludko <[email protected]>
Reviewed-by: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.3@{#14}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    @isheludko
    isheludko committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    4d08e2d View commit details
    Browse the repository at this point in the history

  2. Version 11.3.244.8 

    Change-Id: I76c1b9dc182d25492d24429c59c54067b5f53981
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4419826
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.3@{#15}
Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1}
Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
    V8 Autoroll committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0e75d85 View commit details
    Browse the repository at this point in the history
Loading