Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10.7.193.20
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 10.7.193.22
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Nov 7, 2022

  1. Merged: [compiler] fix bug in inlining of Array.At 

    The inlined version of Array.At was only checking the kind of the
maps, rather than the maps themselves. When the feedback was
containing an array map that "supports_fast_array_iteration", then its
kind was added to the list of supported kinds. If this Array.at was
later called with a non-array map with the same kind, then the object
would be wrongly treated as an array.

This is now fixed: inlining Array.at checks the maps directly rather
than only their kinds.

Bug: chromium:1377775
(cherry picked from commit 0ce2731)

Change-Id: I36fc5cbf4d2aebbd364b41d2caaee4beea956a36
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3990746
Reviewed-by: Tobias Tebbi <[email protected]>
Commit-Queue: Darius Mercadier <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.7@{#40}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
    @DadaIsCrazy
    DadaIsCrazy authored and V8 LUCI CQ committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ed52913 View commit details
    Browse the repository at this point in the history

  2. Version 10.7.193.21 

    Change-Id: I5ed4cafb7ef8b42dd9846640913ed15c5e230130
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4006747
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.7@{#41}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
    V8 Autoroll committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    dda1f22 View commit details
    Browse the repository at this point in the history

  3. Merged: [compiler] Fix mutable heap number object reference leak 

    (cherry picked from commit 6411212)

Bug: chromium:1380063
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I6cffab1478388c9db560ecd5169d958db97c26d7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4008363
Reviewed-by: Igor Sheludko <[email protected]>
Commit-Queue: Maya Lekova <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.7@{#42}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
    @MayaLekova
    MayaLekova authored and V8 LUCI CQ committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    6a84365 View commit details
    Browse the repository at this point in the history

  4. Version 10.7.193.22 

    Change-Id: I87bf47e7b1c92aed20ac975261322a722386e0c0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4009245
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.7@{#43}
Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1}
Cr-Branched-From: 9521696-refs/heads/main@{#83201}
    V8 Autoroll committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0768a17 View commit details
    Browse the repository at this point in the history
Loading