Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.

...

4 commits
12 files changed
3 contributors

Commits on Apr 21, 2022

Merged: Revert "[interpreter] Optimize strict equal boolean"

This reverts commit 62632c0.

Reason for revert: Performance regressions crbug.com/1315724

Original change's description:
> [interpreter] Optimize strict equal boolean
>
> For strict equal boolean literal like "a===true"
> or "a===false", we could generate TestReferenceEqual
> rather than TestStrictEqual. And in `execution_result()->IsTest()`
> case, we could directly emit JumpIfTrue/JumpIfFalse.
>
> E.g.
> ```
> a === true
> ```
> Generated Bytecode From:
> ```
> LdaGlobal
> Star1
> LdaTrue
> TestEqualStrict
> ```
> To:
> ```
> LdaGlobal
> Star1
> LdaTrue
> TestReferenceEqual
> ```
>
> E.g.
> ```
> if (a === true)
> ```
> Generated Bytecode From:
> ```
> LdaGlobal
> Star1
> LdaTrue
> TestEqualStrict
> JumpIfFalse
> ```
> To
> ```
> LdaGlobal
> JumpIfTrue
> Jump
> ```
>
>
> Bug: v8:6403
> Change-Id: Ieaca147acd2d523ac0d2466e7861afb2d29a1310
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568923
> Reviewed-by: Leszek Swirski <[email protected]>
> Reviewed-by: Tobias Tebbi <[email protected]>
> Commit-Queue: 王澳 <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#79935}

(cherry picked from commit 3b772a2)

No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: v8:6403, chromium:1315724
Change-Id: I65c520590093724e838f738c795d229687efb9de
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3592752
Reviewed-by: Tobias Tebbi <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Jakob Linke <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#80010}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599476
Cr-Commit-Position: refs/branch-heads/10.2@{#4}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}

schuay authored and V8 LUCI CQ committed Apr 21, 2022

Version 10.2.154.3

Change-Id: I04771d55c06ff8422efa86f0dcee044f3693b819
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599313
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.2@{#5}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}

V8 Autoroll committed Apr 21, 2022

Commits on May 6, 2022

Merged: [wasm] Fix Int64Lowering for tagged stack-passed parameters

When lowering signatures, we must preserve the separation of parameters
into tagged and untagged sections.

Fixed: chromium:1320614
(cherry picked from commit 8062598)

Change-Id: I3bc49748a35f40664963b3576fb762e5679e6728
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632514
Reviewed-by: Shu-yu Guo <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.2@{#6}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}

jakobkummerow authored and V8 LUCI CQ committed May 6, 2022

Version 10.2.154.4

Change-Id: I8596a2bb5734118374b0c0d25af249940f3c7307
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632520
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.2@{#7}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}

V8 Autoroll committed May 6, 2022