Revert "[arm64] Use CHECK (instead of DCHECK) in CheckVeennerPool"

victorgomes · V8 LUCI CQ · commit ff7708376913 · 2026-01-05T02:54:06.000-08:00
This reverts commit 30c0047. Reason for revert: b/462213735 Original change's description: > [arm64] Use CHECK (instead of DCHECK) in CheckVeennerPool > > This is a hardening measure to prevent potential data corruption > by crashing immediately if the invariant is ever violated in release > mode. > > Bug: 435640828 > Change-Id: Idc10542a68d52747aa1e8500ae3ef3a2cf138330 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7014092 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/main@{#102961} Bug: 435640828 Change-Id: Ia31d6e24dbb5dea1f10bfcf7a32849f9a0eb4253 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7369391 Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#104492}
diff --git a/src/codegen/arm64/assembler-arm64.cc b/src/codegen/arm64/assembler-arm64.cc
@@ -4953,7 +4953,7 @@ void Assembler::CheckVeneerPool(bool force_emit, bool require_jump,
     return;
   }
 
-  CHECK_LT(pc_offset(), unresolved_branches_first_limit());
+  DCHECK(pc_offset() < unresolved_branches_first_limit());
 
   // Some short sequence of instruction mustn't be broken up by veneer pool
   // emission, such sequences are protected by calls to BlockVeneerPoolFor and

Original file line number	Diff line number	Diff line change
`@@ -4953,7 +4953,7 @@ void Assembler::CheckVeneerPool(bool force_emit, bool require_jump,`
`4953`	`4953`	`return;`
`4954`	`4954`	`}`
`4955`	`4955`
`4956`		`- CHECK_LT(pc_offset(), unresolved_branches_first_limit());`
	`4956`	`+ DCHECK(pc_offset() < unresolved_branches_first_limit());`
`4957`	`4957`
`4958`	`4958`	`// Some short sequence of instruction mustn't be broken up by veneer pool`
`4959`	`4959`	`// emission, such sequences are protected by calls to BlockVeneerPoolFor and`