[objects] improve module linked status DCHECKs

legendecas · V8 LUCI CQ · commit ff34ae20c8e3 · 2025-10-20T03:11:11.000-07:00
Improve DCHECKs that requires a module to be linked. This includes kLinked, kEvaluated, kEvaluatingAsync, kErrored and the missing kEvaluating. kEvaluating can be found when a cyclic module is been evaluated synchronously. Refs: nodejs/node#60111 (comment) Change-Id: Ie0b9be22f2d3b8208571d8b419da3505b9f57b65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7031498 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net> Cr-Commit-Position: refs/heads/main@{#103203}
diff --git a/src/objects/module.cc b/src/objects/module.cc
@@ -223,8 +223,7 @@ bool Module::Instantiate(Isolate* isolate, Handle<Module> module,
     DCHECK_EQ(module->status(), kUnlinked);
     return false;
   }
-  DCHECK(module->status() == kLinked || module->status() == kEvaluated ||
-         module->status() == kEvaluatingAsync || module->status() == kErrored);
+  DCHECK_GE(module->status(), kLinked);
   DCHECK(stack.empty());
   return true;
 }
@@ -488,8 +487,7 @@ bool Module::IsGraphAsync(Isolate* isolate) const {
   // Only SourceTextModules may be async.
   if (!IsSourceTextModule(*this)) return false;
   Tagged<SourceTextModule> root = Cast<SourceTextModule>(*this);
-  DCHECK(root->status() == kLinked || root->status() == kEvaluated ||
-         root->status() == kEvaluatingAsync || root->status() == kErrored);
+  DCHECK_GE(root->status(), kLinked);
 
   Zone zone(isolate->allocator(), ZONE_NAME);
   const size_t bucket_count = 2;
