Merged: Revert "[arm64] Use CHECK (instead of DCHECK) in CheckVeennerPool"

victorgomes · V8 LUCI CQ · commit fa87f225625d · 2026-01-12T16:07:58.000-08:00
This reverts commit 30c0047. Reason for revert: b/462213735 Original change's description: > [arm64] Use CHECK (instead of DCHECK) in CheckVeennerPool > > This is a hardening measure to prevent potential data corruption > by crashing immediately if the invariant is ever violated in release > mode. > > Bug: 435640828 > Change-Id: Idc10542a68d52747aa1e8500ae3ef3a2cf138330 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7014092 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/main@{#102961} Bug: 462213735 Fixed: 475265929 (cherry picked from commit ff77083) Change-Id: I6078b69e87243a1bfbee279ffa42bb3abe8a534c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7452031 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/branch-heads/14.3@{#34} Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1} Cr-Branched-From: 01af089-refs/heads/main@{#103352}
diff --git a/src/codegen/arm64/assembler-arm64.cc b/src/codegen/arm64/assembler-arm64.cc
@@ -4968,7 +4968,7 @@ void Assembler::CheckVeneerPool(bool force_emit, bool require_jump,
     return;
   }
 
-  CHECK_LT(pc_offset(), unresolved_branches_first_limit());
+  DCHECK(pc_offset() < unresolved_branches_first_limit());
 
   // Some short sequence of instruction mustn't be broken up by veneer pool
   // emission, such sequences are protected by calls to BlockVeneerPoolFor and

Original file line number	Diff line number	Diff line change
`@@ -4968,7 +4968,7 @@ void Assembler::CheckVeneerPool(bool force_emit, bool require_jump,`
`4968`	`4968`	`return;`
`4969`	`4969`	`}`
`4970`	`4970`
`4971`		`- CHECK_LT(pc_offset(), unresolved_branches_first_limit());`
	`4971`	`+ DCHECK(pc_offset() < unresolved_branches_first_limit());`
`4972`	`4972`
`4973`	`4973`	`// Some short sequence of instruction mustn't be broken up by veneer pool`
`4974`	`4974`	`// emission, such sequences are protected by calls to BlockVeneerPoolFor and`