[runtime] Make Error.captureStackTrace() a no-op for global object

isheludko · V8 LUCI CQ · commit fa81078cca69 · 2023-04-12T15:01:43.000Z
Bug: chromium:1432210 Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#87045}
diff --git a/src/builtins/builtins-error.cc b/src/builtins/builtins-error.cc
@@ -35,6 +35,9 @@ BUILTIN(ErrorCaptureStackTrace) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kInvalidArgument, object_obj));
   }
+  if (object_obj->IsJSGlobalProxy()) {
+    return ReadOnlyRoots(isolate).undefined_value();
+  }
 
   Handle<JSObject> object = Handle<JSObject>::cast(object_obj);
   Handle<Object> caller = args.atOrUndefined(isolate, 2);

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,9 @@ BUILTIN(ErrorCaptureStackTrace) {`
`35`	`35`	`THROW_NEW_ERROR_RETURN_FAILURE(`
`36`	`36`	`isolate, NewTypeError(MessageTemplate::kInvalidArgument, object_obj));`
`37`	`37`	`}`
	`38`	`+ if (object_obj->IsJSGlobalProxy()) {`
	`39`	`+ return ReadOnlyRoots(isolate).undefined_value();`
	`40`	`+ }`
`38`	`41`
`39`	`42`	`Handle<JSObject> object = Handle<JSObject>::cast(object_obj);`
`40`	`43`	`Handle<Object> caller = args.atOrUndefined(isolate, 2);`