[osr] Ensure trying to osr does not skip loop interrupts

o- · V8 LUCI CQ · commit f915fa4c9f41 · 2024-10-21T12:30:04.000Z
Fixed: 374013413 Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#96708}
diff --git a/src/codegen/compiler.cc b/src/codegen/compiler.cc
@@ -1350,7 +1350,14 @@ MaybeHandle<Code> GetOrCompileOptimized(
   }
 
   // Do not optimize when debugger needs to hook into every call.
-  if (isolate->debug()->needs_check_on_function_call()) return {};
+  if (isolate->debug()->needs_check_on_function_call()) {
+    // Reset the OSR urgency to avoid triggering this compilation request on
+    // every iteration and thereby skipping other interrupts.
+    if (IsOSR(osr_offset)) {
+      function->feedback_vector()->reset_osr_urgency();
+    }
+    return {};
+  }
 
   // Do not optimize if we need to be able to set break points.
   if (shared->HasBreakInfo(isolate)) return {};
diff --git a/test/debugger/regress/regress-374013413.js b/test/debugger/regress/regress-374013413.js
@@ -0,0 +1,15 @@
+// Copyright 2024 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --enable-inspector
+
+var Debug = debug.Debug;
+Debug.sendMessageForMethodChecked('Runtime.enable', {});
+const {msgid, msg} = Debug.createMessage('Runtime.evaluate', {
+  expression: 'while(true) {}',
+  throwOnSideEffect: true,
+  timeout: 1000,
+})
+Debug.sendMessage(msg);
+Debug.takeReplyChecked(msgid).toString();
